From nobody Thu Oct 22 17:31:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j9Y9k4LQMz6xP26 for ; Thu, 22 Oct 2026 17:31:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j9Y9k2h2Sz3H2y for ; Thu, 22 Oct 2026 17:31:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792690314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4txFj3/9RC87CEWbCgxtrN34xRG/+cDo9q3ugnkfa9M=; b=lyc6RZjliAJp7cIbc9s6GyDMiVTUVeEwNsfm3ylinmqqJMGIh+s/hUfNEKEi6R0nGI7Vnz cjRXNo+OMBrYvLM01He5TtZLld0S4qVuhkuIaWmfNl47vhysAj3sDu+igKWH7bFs12emw1 2CsBwAQAgHq+W3Srys/k9ypoN/WaUdW2AfYdcV0szCa4xZIfB4yJWpGGSXyAQVbgEK6wV7 J0PSkwXz0CMU39qaLJuNmuY2osHGtcBrJup6SXoN0RAEjzYPxQkOuYB/+iS21P42uxCg4u SDP6APyvXbAOqhhgoAbbMOWGsMplXw3VBSbMu3eD96Hybxt5+xR4HX56n1iGxQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792690314; b=xg3ktHON4fcLYH8Oz+puYhEZoBvFzanEZBdUm5nQgqTOm5o9Bq9fXQ7TKEDp4IrHocLYnL wxncBfDFbHSzjaukzdtOwT3VTU19cMkQ51/6RoD1X34aoLSk4r6rCCq8LEF0fQOKvg0vMy 7DKlOvZtXd3WwCEE11Vde6kdoEzUwAaFEfQYyFlzIkgPuMulHI2qTT9Hicb4olZvblaeCD GGUdvbPCc3kZbB6NpId+H/Y51PeVdxYringu+R7BdaDibPYS1ZwRh9jR1Frqknaq6kFCkh py00OhjMzAA9ht1CxsZqy6PuB+9JReZr0XGT2ZXQxwtMCDsrE4CbwbVn1zYAwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792690314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4txFj3/9RC87CEWbCgxtrN34xRG/+cDo9q3ugnkfa9M=; b=ih4/kjODPxSviK1IK14DHXcm8DxbCYSVRbL6vPQ2ltvw5XmL9fO9m2I55nEKs3xmNhScr+ a3ub40RoaQgfCD8q6mMDr8Yo36w2KS6PAWJvtFPpQATxd9Qfiq1M/jHj9HRW2AaQxdXJWU aMfq13tmRGKdB+Ivu33OZOrK4aCVrz6nw6keMfP0ZkM+EQL3FlMCiwIVwh5h84gVDfCR0u r2Uiup4ZsdPfiGSeVongJksppfHHQVBf4q72q8ScvpN4IL5RzVaKVHx+6DYbf9rom+2GJ8 zGW7VxUNG6jbHY0RKaOJv6AndkAYoqOT/9SbaPcNPIzVHYbEgyRSRv4ENg5pUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j9Y9k2LTYzrlf for ; Thu, 22 Oct 2026 17:31:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ee03 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 22 Oct 2026 17:31:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Hayzam Sherif From: Mark Johnston Subject: git: b580923138a0 - stable/15 - vmm: Normalize a zero PIT count before starting channel 0 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b580923138a0ead596d3614d2cc73c5fbcb076c2 Auto-Submitted: auto-generated Date: Thu, 22 Oct 2026 17:31:54 +0000 Message-Id: <6ada488a.3ee03.6924dead@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b580923138a0ead596d3614d2cc73c5fbcb076c2 commit b580923138a0ead596d3614d2cc73c5fbcb076c2 Author: Hayzam Sherif AuthorDate: 2026-09-21 16:33:36 +0000 Commit: Mark Johnston CommitDate: 2026-10-22 15:45:40 +0000 vmm: Normalize a zero PIT count before starting channel 0 pit_timer_start_cntr0() does not schedule a callout when the initial count is zero. The counter write handler normalizes a programmed zero count only after calling it, leaving an initially unarmed channel 0 without a scheduled timer event. Move the existing normalization before the timer-start call. Retain the historical 0xffff representation of a zero count. Reviewed by: markj MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59749 (cherry picked from commit 3330226fd33ae6b747c9edc97315244360ad5e54) --- sys/amd64/vmm/io/vatpit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/amd64/vmm/io/vatpit.c b/sys/amd64/vmm/io/vatpit.c index 31b6c2ad0f89..595c2e070c7a 100644 --- a/sys/amd64/vmm/io/vatpit.c +++ b/sys/amd64/vmm/io/vatpit.c @@ -401,14 +401,14 @@ vatpit_handler(struct vm *vm, bool in, int port, int bytes, uint32_t *eax) c->frbyte = 0; c->crbyte = 0; c->initial = c->cr[0] | (uint16_t)c->cr[1] << 8; + if (c->initial == 0) + c->initial = 0xffff; binuptime(&c->now_bt); /* Start an interval timer for channel 0 */ if (port == TIMER_CNTR0) { c->callout_bt = c->now_bt; pit_timer_start_cntr0(vatpit); } - if (c->initial == 0) - c->initial = 0xffff; } } VATPIT_UNLOCK(vatpit);