From nobody Sun Oct 18 08:13:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j6rzJ1Jv8z6jy4B for ; Sun, 18 Oct 2026 08:13:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j6rzH5mwMz3LPG for ; Sun, 18 Oct 2026 08:13:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792311211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a86Q1JhbWhwIwJ08Vfl3lDAzw53DhcmX1NuJlLl/kDw=; b=f/kO1raWYg2u0Mu7uwLRleh+OI4Zkgwb/fw/X/wg6rmflAei3XDmv28mh6bXOpUQ6D/4+g QPt8NZZN41WCm3Urr6DxyIuIpoVke6IejZ2Hp2mVRvWG0i7xfySsUBI7xZ+ltAeflhNCsR p/wLHRy9823x9YaC8taXxMdl9WdkSrUg+/dZC6sLax8CT0tQNIlYDwO/8epfCJwlWZCfTc tdFxPelsFliuYAx/pN3XgY68zvYc0Kqapu1U43jzc3lwbJOPV5fg56jPN4h3Y8tAPAP+wI Lqz/2CfPNSeMnmhyw/OqGR4K/J3Ms5wlp7RavXprknPRH1BMRSmryVhNJvASAw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792311211; b=LazvVqtqCm3T2o0c+794+usEXBIQtjVe5e5SqBJZ/P83BujFPVsVgzFRvhlP6T/PGFll5u ogB60lKk2lItyQ5I69Pq5iDzzJIV8ea7PS3nwqcfZSEt95mp6EEmsETl9ylPEJHbWS13kN z8UToyzqipf0vO7z+Y1yljvoAUv0lttTKN0e/JzBk6UTYr2NOMrNZ5w06YM6kdTENfZ45V uTheuqnh+44k15OgxsQaW6i/w3kDHh9wfgvfG4g8wtgYyvDBgm61XoWY4g81LuA3rIyCj1 sI6c/0x3c6A2Z1rdTct2iorUgxE/DXQG4fVWmCeQfSteP6Yu4NnP6yC++HXRJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792311211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a86Q1JhbWhwIwJ08Vfl3lDAzw53DhcmX1NuJlLl/kDw=; b=MCQ4U5Oacl5D9JBYN+w5movov4MZzOwPMYiSoHfuXgg2i9seC7b4hvgBBaX78AicS3rzYQ 4iLrH/6nZZuSfIjU7e/PsXuebfOHimvNObhNWb0HPd1OE1oQA/mTzUly5vUV4xXyeoxLHB +b/29GE3KUr1WZ5mwSAwNXMI+K/Mj51D2CaWhGitqq2IV6aWwDioCaMbe84w7+cfF/BVAs 6xr9Zbrmd9ePL+lVFvYlzMCEjJ47W2ErXIqjliX6p0lV5P4kFFTrQGp7clpGmcCfy+Y3u+ tCbYekUos/gOmWleRI48TxZP3E7ykqkwERWB12r/ARCLJf5BHLxIoin9NI97BQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j6rzH5NPYzhxd for ; Sun, 18 Oct 2026 08:13:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 323bd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 18 Oct 2026 08:13:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 747ee16a11ad - stable/15 - sound: Lock around mixer_set*() in mixer_init() for consistency List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 747ee16a11ade01a9d07d9dc6955c61dd0fcd258 Auto-Submitted: auto-generated Date: Sun, 18 Oct 2026 08:13:31 +0000 Message-Id: <6ad47fab.323bd.2871ef3c@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=747ee16a11ade01a9d07d9dc6955c61dd0fcd258 commit 747ee16a11ade01a9d07d9dc6955c61dd0fcd258 Author: Christos Margiolis AuthorDate: 2026-09-18 18:18:20 +0000 Commit: Christos Margiolis CommitDate: 2026-10-18 08:10:49 +0000 sound: Lock around mixer_set*() in mixer_init() for consistency Sponsored by: The FreeBSD Foundation MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D59110 (cherry picked from commit 47cf9dc7861371edcfdb85a38e2c240f430ccb28) --- sys/dev/sound/pcm/mixer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index ff591cef799f..e3782e7ace04 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -557,6 +557,9 @@ mixer_init(device_t dev, kobj_class_t cls, void *devinfo) if (m == NULL) return (-1); + /* There is no need to lock here, but do it for consistency. */ + mtx_lock(m->lock); + for (i = 0; i < SOUND_MIXER_NRDEVICES; i++) { v = snd_mixerdefaults[i]; @@ -572,6 +575,8 @@ mixer_init(device_t dev, kobj_class_t cls, void *devinfo) mixer_setrecsrc(m, 0); /* Set default input. */ + mtx_unlock(m->lock); + snddev->mixer = m; if (bootverbose) {