From nobody Thu Oct 15 07:49:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j50ZX0bWcz6vQ11 for ; Thu, 15 Oct 2026 07:49:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j50ZW5XdCz4Hlt for ; Thu, 15 Oct 2026 07:49:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792050547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDgu0ZHv2hOgjYYZIT+Mw4S46XEvnCPffXUlspdx5Ys=; b=MIyEToeCOdjogGKwWOiDYLBKAj85A+zXE8SUwKpxwmnQbJv5yo+Hb93ytoZGsZvTdipz2C xhtH7iA4VBriwYtgp/iSdWopgMwe/41gBB8K29g72QPl/fPtHvHFyhoFMSNOMBQvrqXeE7 heM4ejF9L8c3fLK/x65rj6RcO4E5F2LOUtRjq0yfNijw2WXwvxvM6ivTyJl9eikdo47xml pdeypLPNbp4E7AQVKAgb83s3vTjElo/8FrGVKqj6TuktLZ9aEQ/9JvCWFw+PUhvCHIoxjZ N10FcdRbLx9oPGEaajzsvnevG+bTZ451W+QzDWfIBgKRVxm+t56SdXrEMeo3AA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792050547; b=mCoIt1dYiC+Ys2IXYuVl9Rio/KFgsBGWatYcTaEHUi8s0L8hjcJ0rVlYMo7KgcA7uJmfZB 5KnHNB6G/6fnOzNmLVED5RzFQ0btiTStehbkg7Oc83k+RAoyYzVJc9NXj7RVDU1AHAxjkg VwCjOzZKl+MSzsGFpGCVLC3hLwv3c3AOg/TZm8t4inSN6rxZZYeO8/Af5hTn4nCc2Po6o7 G4qAcm6eaJJeRySBEPun785/QfRLehrRaxcUAEQwutvhDht52exdoc/mSkmK2SuKx3gVxW wkEpub3vVol/+bRS1TdZfLMNakWNeBxXVIf8cOsB3L0aKt0PbKK94OFtPVb8uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792050547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YDgu0ZHv2hOgjYYZIT+Mw4S46XEvnCPffXUlspdx5Ys=; b=OynB2N9/znIAINxPZK4IUebz999w/zp/r8T+AxR1ZbtFRGmj+g+cr5KChw/253OuWCaHSY LePiwJ3pdrwr1W1loxWi/HiD/QUVA6/gpxalmcFFjpJWu0Btd/tHr0wp9xGilseEzzHOul 8RHzvnbgph4TsMNtehrpXZ1dsRvJd9B4RvKCWjRE+oCbK6j0xRlajldQ17aYke33Owdbld sUzglx41soobm29yDVaxByVl7As1+b9EiFazmRRieeVT6wEOmZDTL8wR5ZX/4VTA7u0xsj f1Thuv3Kz6M9YNI1FifX1O++XhgStOddyw5fEEr2U8ntu1cjRGsKKj+AfaEyUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j50ZW47KrzMxW for ; Thu, 15 Oct 2026 07:49:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ddaf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 15 Oct 2026 07:49:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Piotr Kubaj Subject: git: ceaf30c92ed7 - stable/15 - virtio_gpu: use an X8R8G8B8 resource on big-endian guests List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 Auto-Submitted: auto-generated Date: Thu, 15 Oct 2026 07:49:02 +0000 Message-Id: <6ad0856e.1ddaf.369fce26@gitrepo.freebsd.org> The branch stable/15 has been updated by pkubaj: URL: https://cgit.FreeBSD.org/src/commit/?id=ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 commit ceaf30c92ed7a44f532e24742ed08bcf730c8ac1 Author: Piotr Kubaj AuthorDate: 2026-09-28 08:43:35 +0000 Commit: Piotr Kubaj CommitDate: 2026-10-15 07:40:39 +0000 virtio_gpu: use an X8R8G8B8 resource on big-endian guests The virtio-gpu resource formats are defined by byte order in memory, while vt(4) and the X server (through vt_fb and the fb mmap) write native 32-bit 0x00RRGGBB pixels into the shadow framebuffer. On a big-endian guest such as powerpc64 those pixels land in memory as 00 RR GG BB, which the host interprets under B8G8R8X8 with red and blue swapped and the padding byte taken as blue: white renders yellow and blue renders black. Request X8R8G8B8 on big-endian guests instead, which is also what the Linux driver does (DRM_FORMAT_HOST_XRGB8888). Reproduced with a colour test pattern on a powerpc64 QEMU pseries guest using the identically coded out-of-tree fork of this driver (graphics/virtio-gpu-qemu-kmod); little-endian guests are unchanged. Differential Revision: https://reviews.freebsd.org/D60085 Approved by: jhibbits MFC after: 1 week (cherry picked from commit 7cf02164a517824c07faed91c009be90f2f17ec0) --- sys/dev/virtio/gpu/virtio_gpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/dev/virtio/gpu/virtio_gpu.c b/sys/dev/virtio/gpu/virtio_gpu.c index b95bae9fe286..2cbfc472909c 100644 --- a/sys/dev/virtio/gpu/virtio_gpu.c +++ b/sys/dev/virtio/gpu/virtio_gpu.c @@ -61,6 +61,12 @@ /* The guest can allocate resource IDs, we only need one */ #define VTGPU_RESOURCE_ID 1 +#if _BYTE_ORDER == _BIG_ENDIAN +#define VTGPU_FORMAT VIRTIO_GPU_FORMAT_X8R8G8B8_UNORM +#else +#define VTGPU_FORMAT VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM +#endif + struct vtgpu_softc { /* Must be first so we can cast from info -> softc */ struct fb_info vtgpu_fb_info; @@ -556,7 +562,7 @@ vtgpu_create_2d(struct vtgpu_softc *sc) atomic_fetchadd_64(&sc->vtgpu_next_fence, 1)); s.req.resource_id = htole32(VTGPU_RESOURCE_ID); - s.req.format = htole32(VIRTIO_GPU_FORMAT_B8G8R8X8_UNORM); + s.req.format = htole32(VTGPU_FORMAT); s.req.width = htole32(sc->vtgpu_fb_info.fb_width); s.req.height = htole32(sc->vtgpu_fb_info.fb_height);