From nobody Wed Oct 14 19:35:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j4hHt1PqWz4nB50 for ; Wed, 14 Oct 2026 19:35:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j4hHs6xZnz3Dcs for ; Wed, 14 Oct 2026 19:35:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792006522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zFSYSpNV/a25gNbNn9RaA832wtkGu/lWgJGQCYsqBh4=; b=uTjRyvaFV53cIgjD4jZIfPY/g10nJL/nf5zJThQH3FFzwrIxFlwOl2yVwgU8FLRZ60D3yf 7eCWbXM4cEkW6n8JRlCLNqJKr3wFYzaVblkzJnRIh+OGHWbmSmT5HvTpvYwIWSmStTq+Ba MaSND9OOPntdX/+4gLqqWh5ky1HwC7hAA9HgwqXP99XV72OODfK8azjNU9ATfqRMWHYIEQ 1yI4cu5D4YlzKR5IGG7O8EpO0PEHc9lYnIUiieSSZEoqZXgxhIUGyFjZArtD2R+1jPmyeO M9XpQggATH4EbI7SaxxcMd67WjSrP3jZomvwBDph8RmEv0olsJTofg2AbdYj0Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792006522; b=hC2wGJrQUPZ8IabRmWUhp9Fj0iJzXR9sKkw79g/xHUwlj/dwzpfZQfUPmGq/LxOI/7/lbZ kmv3Uk6BNhP74Z+k2GcShvxw8ZCJV7QJx9uZVPoTWsgeT/k9VYpxNaa/SR7JyvOadYcsbu EbhQkXla9QbHYcaf+BvdIoNsoD/X8rGqqbzqD88AN4aL54yv3MGm8xslE0W62dacIL4ZoH Eux/lWM4S41FQRhGm4zIW/Pp639185SddUCXi77mnIWrV5RaT/4LlWMG5KLl1yuLEc6rcu JgooGCTRgTLS9iCGMn5eu62P+bS+305OSvRoL+2UcYYGMagmpPSIS5YG4R9EVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792006522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zFSYSpNV/a25gNbNn9RaA832wtkGu/lWgJGQCYsqBh4=; b=RdATlHUZyJUZBl28MUvAzoX/VIAso0CbL3GwxX8vKy3pXbEFQoh1X1Mc9tToM2mqz2eieH RrfgAB8vBPSAqDTnfV1/PwP/R6vNDsSmnnKztwbYR3GnhVKbrK6EEYD4eGokTCBbdcXL68 k06uv5UYAFh0FhVOLDrpp2yEDWIYba0J+PKzegeX7XxRyWNBzTisJsNW8jnLaBPju/YSi+ vPPu6TzIf4n0pGdLO+0O9XEProsNM64wSQRVj9B3jjvGCGA66eKetebeRtQRr+ShYxjugJ gWehEGQ5VA3jBVOR4x7bCzyWD9blwdwHdxqYCtdwLA11GRsSUXuqJVM/rsx+ig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j4hHs5jyGz1Fgd for ; Wed, 14 Oct 2026 19:35:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e827 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 14 Oct 2026 19:35:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 1da1ad38d073 - main - tests/netpfil: reference manual pages in atf_skip statements List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1da1ad38d0731fb39e6685383fa9aa0a503b241f Auto-Submitted: auto-generated Date: Wed, 14 Oct 2026 19:35:16 +0000 Message-Id: <6acfd974.1e827.75753168@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=1da1ad38d0731fb39e6685383fa9aa0a503b241f commit 1da1ad38d0731fb39e6685383fa9aa0a503b241f Author: Gleb Smirnoff AuthorDate: 2026-10-13 06:35:56 +0000 Commit: Gleb Smirnoff CommitDate: 2026-10-14 19:35:07 +0000 tests/netpfil: reference manual pages in atf_skip statements For those modules that don't have a manual page spell out full name of a loadable module. --- tests/sys/netpfil/common/nat.sh | 2 +- tests/sys/netpfil/common/utils.subr | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/sys/netpfil/common/nat.sh b/tests/sys/netpfil/common/nat.sh index 2b828dc03fdc..5f44be9e2577 100644 --- a/tests/sys/netpfil/common/nat.sh +++ b/tests/sys/netpfil/common/nat.sh @@ -103,7 +103,7 @@ userspace_nat_body() firewall_init $firewall if ! kldstat -q -m ipdivert; then - atf_skip "This test requires ipdivert module loaded" + atf_skip "This test requires divert(4)" fi epair_host_nat=$(vnet_mkepair) diff --git a/tests/sys/netpfil/common/utils.subr b/tests/sys/netpfil/common/utils.subr index f5013098f5f2..fd4a842f31c4 100644 --- a/tests/sys/netpfil/common/utils.subr +++ b/tests/sys/netpfil/common/utils.subr @@ -86,21 +86,21 @@ firewall_init() if [ ${firewall} == "ipfw" ]; then if ! kldstat -q -m ipfw; then - atf_skip "This test requires ipfw" + atf_skip "This test requires ipfw(4)" elif [ $(sysctl -n net.inet.ip.fw.default_to_accept) -ne 1 ]; then atf_skip "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable" fi elif [ ${firewall} == "pf" ]; then if [ ! -c /dev/pf ]; then - atf_skip "This test requires pf" + atf_skip "This test requires pf(4)" fi elif [ ${firewall} == "ipf" ]; then if ! kldstat -q -m ipfilter; then - atf_skip "This test requires ipf" + atf_skip "This test requires ipf(4)" fi elif [ ${firewall} == "ipfnat" ]; then if ! kldstat -q -m ipfilter; then - atf_skip "This test requires ipf" + atf_skip "This test requires ipf(4)" fi else atf_fail "$fw is not a valid firewall to initialize" @@ -113,7 +113,7 @@ dummynet_init() firewall=$1 if ! kldstat -q -m dummynet; then - atf_skip "This test requires dummynet" + atf_skip "This test requires dummynet(4)" fi case $firewall in @@ -121,7 +121,7 @@ dummynet_init() # Nothing. This is okay. ;; *) - atf_skip "${firewall} does not support dummynet" + atf_skip "${firewall} does not support dummynet(4)" ;; esac } @@ -131,7 +131,7 @@ nat_init() firewall=$1 if [ ${firewall} == "ipfw" ]; then if ! kldstat -q -m ipfw_nat; then - atf_skip "This test requires ipfw_nat" + atf_skip "This test requires ipfw_nat.ko loaded" fi fi }