From nobody Wed Oct 14 16:03:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j4bb8239yz6vmYN for ; Wed, 14 Oct 2026 16:03:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j4bb75Mtyz4YBw for ; Wed, 14 Oct 2026 16:03:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791993795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5kfCbfWyUahJE4LWnWyVLn89ZFpEFLemliullDx/O6s=; b=I7yUgrOpvxForDda+PTMWgg+zju9T6X00N9FEptXe89AjlQkXIUYIG5C8ZydKjd87fXvji 8v6AGXx5fwUyIgjHhbBhx06b379Q92lRWsjrqtTy268pOMEROV3eIRd3v7aeWOVCkhceb7 kP4hwDyNUfqMe9ukV6nR2C3/7RYT+PLb+fDwZEL+CHHmpl+Tku5/cdRxcpjTlsBFXTjoXM nQqX/3jJD1YkvUleTbP3hWaocigEDwXwSbw7UffSr0BvutrMM4pMyPCVnAzbrgEnhPKwYf w4p3eo6H8LjmtwaDtMTYc4MHh/OXHSFT8xYIObp+UEvezmSaPp7OGm2PacauoA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791993795; b=TRybP2+L1IYbLSYEG3+7qQg5z4NRRsR9xzHoHMlTts1hZRcpmORrXaYum0apGWX4iqrQA8 75g/BtsywbCvXNHaDtSUP/yPXCNAue3fPYOSYPRFHMx9vWP8HbBcvWzKBtKwZItvVXOQUB 9MWWZxmeUNA5WopvAQWnG4QKLh4WcntDxfDpUg6bGzZ7CXvrO3ZLFrHuJeQo9j7mX8V2RT bSPFnFbcskAMi0KArMAnhVaBXf56uyiq3qURWg7MXQhK/lHuNwhPsiVkqmPE8WJdWGj6d4 kjk7O2kEDt8qhUY6UG0rB5JpGpvepboMkEwn6Gi7/wNw/AUkGM7GJCHyECHBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791993795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5kfCbfWyUahJE4LWnWyVLn89ZFpEFLemliullDx/O6s=; b=nihuKK2nmIlcbt7t+61MWb7LsdgsXYuPS7pV+2E8Icn0ixgt4yVuhgrXwyk1FWzb3jfX0J TxB6cnrT0Mopk2E4aw4AB6Ut9xC1FrNEJL2OjIKwciMP4dLeRKsmG1ObvEESGwmbAOuRQg OOrHI9Lj97ChpJ8d/1VKgB93jZ2L5ytxJZHy4k+OM+7+z4BmohwcpwfzDlMxkpdgGaIy7H Cmt/u2PutOsgiGL5KILAkwOkva74D9VjVqawrnsT8PRi5bbHLlusKYlKFf+dal5XqAVZ/M ccXh1Zj0Ckqjedx+/9fISLLmVFZgqCASNP9QnhHI12kJ2rgk1WgTHflye/rtmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j4bb74Rs5z187M for ; Wed, 14 Oct 2026 16:03:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2724d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 14 Oct 2026 16:03:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 99a3150f0615 - stable/14 - bhyve: Improve HDA stream descriptor validation List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 99a3150f0615241d38acd75eddd15ea48caa3abe Auto-Submitted: auto-generated Date: Wed, 14 Oct 2026 16:03:15 +0000 Message-Id: <6acfa7c3.2724d.36642dd6@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=99a3150f0615241d38acd75eddd15ea48caa3abe commit 99a3150f0615241d38acd75eddd15ea48caa3abe Author: Mark Johnston AuthorDate: 2026-10-13 19:58:36 +0000 Commit: Mark Johnston CommitDate: 2026-10-14 16:03:06 +0000 bhyve: Improve HDA stream descriptor validation The length of each block in the stream must be non-zero. This is assumed in hda_transfer(), otherwise an out-of-bounds read or write is possible. Use atomic loads to access stream descriptor fields, since they are guest-controlled. Make sure that the descriptor array is suitably aligned so that we can drop the __packed annotation from the structure definition; per section 3.3.42 of the HDA spec the BDL pointer is supposed to be 128-byte aligned, in fact. Approved by: so Security: FreeBSD-SA-26:72.bhyve Security: CVE-2026-101310 Reported by: Brian Delgado from Intel using Anthropic Opus 4.8 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60678 --- usr.sbin/bhyve/pci_hda.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/usr.sbin/bhyve/pci_hda.c b/usr.sbin/bhyve/pci_hda.c index 58481af71a4c..3a29ee386f8f 100644 --- a/usr.sbin/bhyve/pci_hda.c +++ b/usr.sbin/bhyve/pci_hda.c @@ -29,6 +29,9 @@ #include #include + +#include + #include #include "pci_hda.h" @@ -82,7 +85,7 @@ struct hda_bdle { uint32_t addrh; uint32_t len; uint32_t ioc; -} __packed; +}; struct hda_bdle_desc { void *addr; @@ -625,8 +628,9 @@ hda_stream_start(struct hda_softc *sc, uint8_t stream_ind) bdl_paddr = bdpl | (bdpu << 32); bdl_vaddr = hda_dma_get_vaddr(sc, bdl_paddr, HDA_BDL_ENTRY_LEN * bdl_cnt); - if (!bdl_vaddr) { - DPRINTF("Fail to get the guest virtual address"); + if (bdl_vaddr == NULL || + (uintptr_t)bdl_vaddr % HDA_DMA_ACCESS_LEN != 0) { + DPRINTF("Invalid guest virtual address %p", bdl_vaddr); return (-1); } @@ -637,11 +641,14 @@ hda_stream_start(struct hda_softc *sc, uint8_t stream_ind) bdle = (struct hda_bdle *)bdl_vaddr; for (size_t i = 0; i < bdl_cnt; i++, bdle++) { - bdle_sz = bdle->len; - assert(!(bdle_sz % HDA_DMA_ACCESS_LEN)); + bdle_sz = atomic_load_32(&bdle->len); + if (bdle_sz % HDA_DMA_ACCESS_LEN != 0 || bdle_sz == 0) { + DPRINTF("Invalid BDLE length: 0x%x", bdle_sz); + return (-1); + } - bdle_addrl = bdle->addrl; - bdle_addrh = bdle->addrh; + bdle_addrl = atomic_load_32(&bdle->addrl); + bdle_addrh = atomic_load_32(&bdle->addrh); bdle_paddr = bdle_addrl | (bdle_addrh << 32); bdle_vaddr = hda_dma_get_vaddr(sc, bdle_paddr, bdle_sz); @@ -653,7 +660,7 @@ hda_stream_start(struct hda_softc *sc, uint8_t stream_ind) bdle_desc = &st->bdl[i]; bdle_desc->addr = bdle_vaddr; bdle_desc->len = bdle_sz; - bdle_desc->ioc = bdle->ioc; + bdle_desc->ioc = atomic_load_32(&bdle->ioc); DPRINTF("bdle: 0x%zx bdle_sz: 0x%x", i, bdle_sz); }