From nobody Tue Oct 13 13:08:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3vmc4bx2z6whPv for ; Tue, 13 Oct 2026 13:09:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3vmc1zjKz3C3h for ; Tue, 13 Oct 2026 13:09:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791896944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/X829JiJJkDQm9tCkIkMhlPdxbwGUhhDeS8V07N8qOI=; b=Q/cMud3LA4K24hBfL/vuT565LFoWTXgZovxOD8hNz7GMrBmmmjagrt6tGfQpN2cD4f9Ym4 elUfWVbjS2ArI/WpbqePgM3D/4B7/n7XcxxfkChaNvZJwO4PvweQIED+oUr18MHGb+XcqV NI27191orHiGCMqIehU68U61Kr8JFPpDfF4OtFB86NTRngeMHkPY8iAaMjNXrRjgBpT5xb flzDnSzY9lSEEyz4See7jFb+5/ulnJxWj8zSSIFeaQpf7eD4o9YCmw7oiAhajW4YaANM6u mbocKGxazt7VePaHVsRzlwtMXhq3Rj8w/goEx0Gl27SKilkbnPkblXuYz0e7cw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791896944; b=iBPU6eZoQb4BUQfLXMWPZyRWgCVSLLUP+xKcigRwlbAFThaGE6qhdFr0q3aQatxyyVAHcL fnVN/DiG5jOzaCajiiUdFa3d0Ki/op8xEh5/6tMTY4beVy7n7ol5OPIPFYLm0uem+SNrYk 87oNGVDRXTak0MUfmmxUR5jRhHf3IdbtDmWY6R5zeReGSSJ/d2GqL4Pl+xTNwhLIMkVC7g hUakJkRU4ZWt5SdCyMov7r7iSkYohLQlq7OBjNHuR+2FV2Kh5MLU1UMl7woTxz06JxtY6t wHNGH5lmLNsz5Qo5obpE7Dtvq6xmEMp3NpTa4GD0Egvg2CCTEwGdxK4fpQ7H2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791896944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/X829JiJJkDQm9tCkIkMhlPdxbwGUhhDeS8V07N8qOI=; b=ysCAwOMzTZdwTJ4BJN7/Tne+QiqeJFaAk0Vdr7NBmVFSl1Sn/5bh8EcsFdZImEjpjUDLmk SsAuu9edFCTmThJ13RWwB1fG5cYAxsydcBzMCD0mNwSSINPl/BchumOYlZotAXmn07Q9aU QPREbHwATGzt23XwFmpN7/XwspG3qil+ihG/wf5OMlz9S0seTsmzXeSvIqQ13kuugCEZey ypimF/tVY0OBbSTu26zMu+YFiOFOy1I4pI57d73tH5sqO8FB2UBYA4r+vTSVjYqqoyfnGS 62BAoj4P8muSeh0c0nU/aVpWCzOGA3thF2gKwrLSQ/x8OnOxDudAEj3xyuFN9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j3vmc0jvszGRP for ; Tue, 13 Oct 2026 13:09:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f059 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 13 Oct 2026 13:08:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: f4ff995e361f - main - pfil: Avoid potential mbuf tag leak List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4ff995e361fa72cea240c4dbac2d0931965c80f Auto-Submitted: auto-generated Date: Tue, 13 Oct 2026 13:08:59 +0000 Message-Id: <6ace2d6b.3f059.39514407@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=f4ff995e361fa72cea240c4dbac2d0931965c80f commit f4ff995e361fa72cea240c4dbac2d0931965c80f Author: Andrew Gallatin AuthorDate: 2026-10-13 13:01:26 +0000 Commit: Andrew Gallatin CommitDate: 2026-10-13 13:08:18 +0000 pfil: Avoid potential mbuf tag leak In '398254f9999e mbuf: simplify m_free' we removed tag processing on m_free() of M_NOFREE mbufs. It is possible that a packet filter could attach a tag to this stack mbuf and call m_free() on it, meaning that 398254f9999e may have introduced a tag leak. However,if a tag is attached without anyone calling m_free(), then this leak was pre-existing. Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D60686 Fixes: 398254f9999e Sponsored by: Netflix --- sys/net/pfil.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/pfil.c b/sys/net/pfil.c index fae150839eb3..400ea4d97fb4 100644 --- a/sys/net/pfil.c +++ b/sys/net/pfil.c @@ -139,6 +139,8 @@ pfil_fake_mbuf(pfil_mbuf_chk_t func, void *mem, u_int len, struct ifnet *ifp, */ rv = PFIL_REALLOCED; } + if (!SLIST_EMPTY(&m.m_pkthdr.tags)) + m_tag_delete_chain(&m, NULL); return (rv); }