From nobody Mon Oct 12 15:28:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3LwW6JTnz6vxk1 for ; Mon, 12 Oct 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3LwW4kQKz3PXw for ; Mon, 12 Oct 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791818939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C0pSrFOQUBXGXeh9QapiIy890ljoSt7sduXcLo1bW9M=; b=bMb+fCVI4E3PGEH1pet3WOKEiuEoOLMqoh2OBs+4QrzoTIqOSi1+z3yzqsK3Jw8q7kd/pN L0i6Kg3quo9F81Z4/DENbt6TalC63cYMNh/W6CeXNSaspv6xsvR9oZabkCPqWMrURBsXno YRK/PRZkVbhDqSNFqi8WFxKKT42q2nH1XIiqaBA5WRVir4QaLPJqZqAWXhn/SE3R/biXx4 +Ye4TnI+y4UZmXJfRF/stpvDrK84gBglJgdGybq9hzhf+t4IDjQxIFrpTPBEs7Xb0D0Ff/ 6w8kmgrv39kHAMaQuBrFR+x4PTc9vS1F3KwZ8tBBa9VHJxqcDMGct/zBI8XxIg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791818939; b=dgnvOZEydkzPUe6OIqki+vuX48VFXSJ9wQFk/upe4R/6bUQAuUYCsGio9BRx6ARIA9qFXe V1MtwUpNUH6CQAnWKOACGkx4PEo8HPXCOANr8vEUbgr5Yp6CK/cUJVVv7MSfcVkR3dd/39 cLpMvcSg/JOSmLK4oFDMeFVOcpsZ8g8KPrz4cwBiQZOEQUyrZ0TSbd6vcLJhsltkFmDK2n yhfLFZxtiqgwL9WAJvjY3OHiqLlFZtaXbCl+GcT3o1t4D8AT5kSMwkZHV5nZCuHp1pfRDL wdI3W6VdlUvWgzvcHZJkQLCKokDXi7vtasAohrONsGmkAMThdk4xnT33S6xUJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791818939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C0pSrFOQUBXGXeh9QapiIy890ljoSt7sduXcLo1bW9M=; b=jQVXOMORSRD0Wa4R8zZl2TlSdCyDKg/5y0xxpbc9fAmXIp6EnNWWdGHOZ9BG/sxN8ApJJH kLQb5dLzbQuLga7PQE3yPFWzCNU8HAHm2Iv7A7VaNjOwC4e+60UZ398aBTvIlfmJo+uJ0W 8M8fyJWIUu5I063a5Z1sxF4PsGBg/zSpB0+2vAB3KklkfMI/dctymmVyzGHftGcDfUbHLc yZ60NcqNMR6cT2tNkCTHYOjE8iQroV4Ls+3FWEjHpiIH8pruwpLZy35BfClj78r4ts/Ab3 TC7MC17nSu1gFoG3elO6Z/fipCAcKGnLL7S38XiloAN9EOAPOxXcR7ehuZdBaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j3LwW3ljfzbTV for ; Mon, 12 Oct 2026 15:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c5f8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Oct 2026 15:28:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kevin Bowling From: Ed Maste Subject: git: 07d5d9ca2e6f - stable/15 - aq: Use the common RSS key without options RSS List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 07d5d9ca2e6fe5a5373b4dd8aa7d2bc809bbf80d Auto-Submitted: auto-generated Date: Mon, 12 Oct 2026 15:28:54 +0000 Message-Id: <6accfcb6.1c5f8.4a805d5f@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=07d5d9ca2e6fe5a5373b4dd8aa7d2bc809bbf80d commit 07d5d9ca2e6fe5a5373b4dd8aa7d2bc809bbf80d Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:17 +0000 Commit: Ed Maste CommitDate: 2026-10-12 15:27:45 +0000 aq: Use the common RSS key without options RSS Fetch the common RSS key independently of options RSS instead of generating a private key in non-RSS kernels. Keep the existing software-RSS or round-robin indirection policy and hardware key serialization unchanged. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59793 (cherry picked from commit 772994d7748287be70fe850ec9e1117d4e7b1747) --- sys/dev/aq/aq_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/aq/aq_main.c b/sys/dev/aq/aq_main.c index 92a6cbde858a..e0d0d1727a95 100644 --- a/sys/dev/aq/aq_main.c +++ b/sys/dev/aq/aq_main.c @@ -506,12 +506,13 @@ aq_if_attach_post(if_ctx_t ctx) aq_add_stats_sysctls(softc); /* RSS */ uint32_t rss_qs = MIN(softc->rx_rings_count, HW_ATL_RSS_INDIRECTION_QUEUES_MAX); -#ifdef RSS + _Static_assert(sizeof(softc->rss_key) == RSS_KEYSIZE, + "RSS key size mismatch"); rss_getkey(softc->rss_key); +#ifdef RSS for (int i = nitems(softc->rss_table); i--;) softc->rss_table[i] = rss_get_indirection_to_bucket(i) % rss_qs; #else - arc4rand(softc->rss_key, HW_ATL_RSS_HASHKEY_SIZE, 0); for (int i = nitems(softc->rss_table); i--;) softc->rss_table[i] = i % rss_qs; #endif