From nobody Mon Oct 12 15:26:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3LsN0t1hz6vxHZ for ; Mon, 12 Oct 2026 15:26:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3LsM64NSz3NRW for ; Mon, 12 Oct 2026 15:26:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791818775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PuUd+DLH4rO6W56dVwy/piqBSMlcyhgVfgBPcoOSVDs=; b=JsxLtuE3ZmCaasz78aBDCnvINJ/rUH49YLIytpxfeTrE5CANPEPCY8wKehgZbchY3Cv/58 POVUWeYXl57fkrOcomGRaUa/2QcaIGoEFJ+MK+VgHnrMOeWbvXWZ9uuAz/NYOBnAeolPfs SJblWYHYICrpOBrHedBof8njHGg8SCZCso1tN8c6Cf/JzxbUDBPccThnNRZFxHrcBVXpsQ kXaIAqS9dkXXNpmBYsteS41ViMxuKKyp9dWIcbal3B3y5CmQcw51qgUns23IzlPTO2Nmpx hjt5u3Yv/oSh/80R5wOmxnYhPqSYxS9BkdTu2McwdgrDoP1Jc1h2Mbr9HzdtGg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791818775; b=d3SkApdBi1jzmkmirqahY/qNLxTrZQknmj0I+TGeV3+Ajngd/VN3o6aANaZwq4ziYSAO1G f3fOXyRf120wchtHquCaW03s8+PBgFDYLiAYk1BHTlG3ILBloZTI98mZGny5ii+AZTvQcN XEHG7+DFff3gmRM2zsgdRJO19NFoIS7LIPgilZw+s4MJdW7apiJKgJ33pD/D614QMmPTxa AfqI3rpqQb9iKczsOJbuUagHWo0RmhnXU9VLQS2TysV76YilD9ML3Dbkw0ao9zANTX/yHe QRlEcZekKfFo6KQoTeCV/xbtRvXTn96ycq5+5a/pZdF9vdHUYG6VftPgOSb6cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791818775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PuUd+DLH4rO6W56dVwy/piqBSMlcyhgVfgBPcoOSVDs=; b=Z5IDpbOWYSChutwzQlU56pGSUBmvkMsSlTP5MRHayrMr51D4GpPgh8Wo1MNelT1ASwO7NP TdQUxI6OguCBO+TAzaFVNzrn75WEFejOV/wK6FBb4CBvKTJIyHxr/vZPweSOfqtA6BQEge CzllzgX7zARQ6WxodeCrZvaaSvldm7u2sI0EfGwDib1uyx9C5bhnOcIUj/+nPrCj7zghaz z5KJJv1au7c6A+Ek1HHOBnxjSHWrVu5am/t8M3/LBhLDJP1lqQ0BKrdu0LWXlVTZ9/JXWP JClLll1oYVixXRR1TcjZBeunfhoHoasTPncui6ztAy2kzM8lSKl9zCq+AbcmAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j3LsM4chZzbNl for ; Mon, 12 Oct 2026 15:26:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c4bc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Oct 2026 15:26:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 6c44e6e9aa7d - stable/15 - mgb: Correct TX interrupt bit List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6c44e6e9aa7de1f96bf7b308b79a6ed30be17ee9 Auto-Submitted: auto-generated Date: Mon, 12 Oct 2026 15:26:15 +0000 Message-Id: <6accfc17.1c4bc.234fcf35@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=6c44e6e9aa7de1f96bf7b308b79a6ed30be17ee9 commit 6c44e6e9aa7de1f96bf7b308b79a6ed30be17ee9 Author: Ed Maste AuthorDate: 2026-10-09 19:10:18 +0000 Commit: Ed Maste CommitDate: 2026-10-12 15:25:53 +0000 mgb: Correct TX interrupt bit The TX interrupt handler checked MGB_INTR_STS_RX(qidx) instead of MGB_INTR_STS_TX(qidx) -- presumably a copy-paste issue. Because the driver does not use TX interrupts so there was no actual issue in practice. Reviewed by: adrian Sponsored by: The FreeBSD Foundation Fixes: 8890ab7758b8 ("Introduce if_mgb driver for Microchip LAN743x PCIe NIC") Differential Revision: https://reviews.freebsd.org/D60550 (cherry picked from commit 6c3f2b8be268de075d60387158f2889140851725) --- sys/dev/mgb/if_mgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/mgb/if_mgb.c b/sys/dev/mgb/if_mgb.c index 53a69f480784..60f93bb0615d 100644 --- a/sys/dev/mgb/if_mgb.c +++ b/sys/dev/mgb/if_mgb.c @@ -800,7 +800,7 @@ mgb_admin_intr(void *xsc) /* XXX: TX interrupts should not occur */ if ((intr_sts & MGB_INTR_STS_TX_ANY) != 0) { for (qidx = 0; qidx < scctx->isc_ntxqsets; qidx++) { - if ((intr_sts & MGB_INTR_STS_RX(qidx))) { + if ((intr_sts & MGB_INTR_STS_TX(qidx))) { /* clear the interrupt sts and run handler */ CSR_WRITE_REG(sc, MGB_INTR_ENBL_CLR, MGB_INTR_STS_TX(qidx));