From nobody Mon Oct 12 11:54:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3G9c3QRMz6SyVn for ; Mon, 12 Oct 2026 11:55:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3G9c1rRmz4dHc for ; Mon, 12 Oct 2026 11:55:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791806100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qhGC5bocl3pQ4UTUGCD/eht7oEmTof/vS7AS8XEfKHU=; b=FFydzfjFke+iRnkf+FviK3/HnlpE1I9rJmeBcuDVShZHXlsjGBBh4YfD3oQsPZvOSO4jL5 ZPzqzHtmxcQTN5SPh4hq6pw164YFhpyO3hqFWCwYkUC84Xfl8eDCbyYwXyZP49GIZMnyoX A1YbYngcz/eHGWudgm0neNA15hy7JvWIoLr75x3jbVdD+6pVrVcR+QtsDzqrTnRLAXoUq6 YpG4J2XLA+Pg9srJvWrO2vyrVG1df7NgpoA7eRzNu5Frw1Gga4G1oCUhFtV6ZIaixWZFsf 5a04nG3mWhAnPKKU8sHRlhw6lVtCWzGWvxSFMRCuwyCNNF3kcv0eYD8ZSIxg3A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791806100; b=AOiipMYz9bPLFo2zm7dECL+aT6bEDv1Lz9VklnALH78HyBdU8uUM1R9kVhJJJgEMQ5lrVL 5unsOW+74T9oLlUnK8o7Gfc0klZ6Oney12PmpdaHn4vy1/zNXVMrDHTMqsKcrfirDcmjXr xdI2HFZBEmF8imFs9RlycK0W2c6mfYbHYDyy5iCSpb9XUDIIAbZLn3z9RYrFClpasT5J1i 1P7R9VRST6X3bAU8ocUCRKGtbiZ4in427ikjhsQoExBja2PPfgmIttSB0yQsiNXOXRNRb/ IYBm5DBKn/KX7lIWyCBL2qM4ixbBCjzaBqVNORySkCAZa/pAN6f9Wc9QMgtIpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791806100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qhGC5bocl3pQ4UTUGCD/eht7oEmTof/vS7AS8XEfKHU=; b=LU6vxUNKQ5+8yovAE0fzxIpMoTYVYT6uoOaZjGr1EuejkYOUQz4u/dTktsxYj6xOAmnUed 6+MSOJcUHG0Y009bqG/wDauL/fO/HkAgKgmTsmGzNe89YWKD+BGaLXzHzUmwCJoVt77fua d/3M7kgGrCBHN44ks00yE6UFBoAVaHnjsay9MHVEEYY071OHBxqs1Dph9WE8/PZWWVCwV2 995qNMyKbl5ML7ajInbDKKq7wlLpnNNXCIvhsz0cAXiItRs8vI5jHULqTs53NW8F8tQa2l 0cFPiDfdWmRWU33piL740WGUfFVpQWJHG7exB/7U1iGsXYhSy1/kTuRWGOJcvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j3G9c0vWjzQwf for ; Mon, 12 Oct 2026 11:55:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33fe0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Oct 2026 11:54:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 92d66a6b474f - main - pf: Drain the overload task before a vnet's rules are freed List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 92d66a6b474fa6fe42fbe08002803d79a5af6594 Auto-Submitted: auto-generated Date: Mon, 12 Oct 2026 11:54:55 +0000 Message-Id: <6accca8f.33fe0.4c101e3e@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=92d66a6b474fa6fe42fbe08002803d79a5af6594 commit 92d66a6b474fa6fe42fbe08002803d79a5af6594 Author: R. Christian McDonald AuthorDate: 2026-10-12 11:52:34 +0000 Commit: R. Christian McDonald CommitDate: 2026-10-12 11:52:34 +0000 pf: Drain the overload task before a vnet's rules are freed pf_src_connlimit() queues an entry for pf_overload_task() when a source exceeds max-src-conn or max-src-conn-rate and the rule has an overload table. The entry holds a pointer to the rule, and the task runs from taskqueue_swi with the vnet of the queue. Nothing drained the task when the vnet went away: an entry queued just before could be applied to a rule pf_unload_vnet_purge() had freed, or to a vnet that was gone. Drain the task at the start of pf_unload_vnet_purge(), before the unlinked rules are freed. No packet can queue another by then, as the hooks are already removed. Reviewed by: kp MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60529 --- sys/netpfil/pf/pf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index d125a28a5b76..3dcb0c29e62a 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -2960,6 +2960,9 @@ void pf_unload_vnet_purge(void) { + /* Overload entries reference rules: apply them before rules are freed. */ + taskqueue_drain(taskqueue_swi, &V_pf_overloadtask); + /* * To cleanse up all kifs and rules we need * two runs: first one clears reference flags,