From nobody Mon Oct 12 04:01:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j33fj1j26z6vPDx for ; Mon, 12 Oct 2026 04:01:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j33fh6r7dz4jNc for ; Mon, 12 Oct 2026 04:01:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791777661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OjZDuxO91F0C/YhlWWsQRN9TFu5GavrYEIpiHjl2NOo=; b=e50Fw2DMClLTAf7Lk24hnQOcqt8IHcb2F08/y9DYFmPUyB+VcS5hoMSrnc1hJoKqnwf5b7 cXNqgppHAkFd0LYVzfT3RYXQZxJDujGMIzHLAg9TbaMgILbJNHtiUOrfT4P+2Pxt5MzlnN IWApI9yxjdGOl+D3ZjapcTAemakdY9Nw0/9y8o5ah66SsbGZ+26dptqnPuKZfQuVx8RF13 m25Ak/bvHXEJq/qTEAnWcM8TnRzA9pqk+f+WaRNVdwvpwYvz0zruCbbNgL6C6hpbAs3OVw SgCSh4eixR1d+v0isWZGL9QbzFSno3zJ65ComdmCNwmqfIRaRDlTpUaUhtwkgg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791777661; b=SJjBCVWv9acsZ/B+HXTWt5IgqE4F+hkIgHUFHxdYXtr4/j426ef2qyXFJeXGizxiuxaZio /5FAp2KwjzNiJlhJiY83i4xBlP2x0rcWmaLphvkmdu29lR/4flA6jfQBQDxLZEciiuReon YNEMgFAkwW7VLpv3bwWLveaYTUQdeh20mx4o+gGE3ZFf8sKZKCEd7qdkRSo4qcH6O/x47j x2LU3AYCPkfJVLFdKfAbLGY4trBBtOfJAJtgEyZ3i3eA3Q5clF45pSj3dys5cB+gpuutXp rfM3MVXoOEQD2fyDJj0UyqzzoZfRvRULGJsGSzJjOd2Ye8nFmBy6/8mNK8ooQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791777661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OjZDuxO91F0C/YhlWWsQRN9TFu5GavrYEIpiHjl2NOo=; b=EN7P+3Ccw35vGc4JbyKjE+l5Rj90xzpH4Bj7558/9LFxtHIcdOK5K8n4CeviVrBSBSStgs oG2hX8YoT4AYB6iBigh3yfu4f9l013OxTjb+4QYKg5hAeH4CbZYIdaEup7hVSEv6EJDYQu uII5+C61UCIdDsRAOSl9l6ImFFdkPxAO+TsoWD1oqbnbrzGb+EcAbTq/RO1Ubf8r0SzD5t XEtPhyABIRLYx3DRZh7ahUEJEmrwQKBzPMxm+DZxUHABbQTDaxzhI3mRyEZYS4rwOY15+j EtVWtn+F8m02WWX2lJ00Ntc5TY7sBKSpoXPUuTjtVflUd6wn/k2QwFvG5z8MAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j33fh5vZrz1BHM for ; Mon, 12 Oct 2026 04:01:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19516 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Oct 2026 04:01:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: 344557b3796b - stable/14 - arm: pad minidump page table List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 344557b3796b8fabfe64d826fc245ce2537276b3 Auto-Submitted: auto-generated Date: Mon, 12 Oct 2026 04:01:00 +0000 Message-Id: <6acc5b7c.19516.50ea6d61@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=344557b3796b8fabfe64d826fc245ce2537276b3 commit 344557b3796b8fabfe64d826fc245ce2537276b3 Author: Minsoo Choo AuthorDate: 2026-09-16 00:14:45 +0000 Commit: Minsoo Choo CommitDate: 2026-10-12 04:00:21 +0000 arm: pad minidump page table libkvm locates the sparse page array after the page-rounded PTE table size, but the ARM minidump writer emitted only the unrounded size. When the table size was not page-aligned, libkvm therefore read every dumped physical page at the wrong offset. The mismatch was introduced when libkvm began rounding ptesize. It has affected ARM minidumps since ffdeef323449 ("libkvm: Improve physical address lookup scaling."). It is exposed when the dumped KVA span is not a multiple of 4 MiB. Zero-pad the final PTE page and include the padding in the dump size. Reviewed by: jhb Approved by: jhb (mentor) Fixes: ffdeef323449 ("libkvm: Improve physical address lookup scaling.") MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59716 (cherry picked from commit 4cb357c61c004f4cf27ca12e702b44a81f2752ab) --- sys/arm/arm/minidump_machdep.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/arm/arm/minidump_machdep.c b/sys/arm/arm/minidump_machdep.c index 802b3184ed06..30d838320ba8 100644 --- a/sys/arm/arm/minidump_machdep.c +++ b/sys/arm/arm/minidump_machdep.c @@ -187,7 +187,7 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) /* Calculate dump size. */ mbp = state->msgbufp; - dumpsize = ptesize; + dumpsize = round_page(ptesize); dumpsize += round_page(mbp->msg_size); dumpsize += round_page(nitems(dump_avail) * sizeof(uint64_t)); dumpsize += round_page(BITSET_SIZE(vm_page_dump_pages)); @@ -268,7 +268,9 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) } } if (addr != dumpbuf) { - error = blk_write(di, dumpbuf, 0, addr - dumpbuf); + /* The sparse page array starts at a page-aligned offset. */ + bzero(addr, dumpbuf + sizeof(dumpbuf) - addr); + error = blk_write(di, dumpbuf, 0, sizeof(dumpbuf)); if (error != 0) goto fail; }