From nobody Mon Oct 12 03:59:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j33dN28kHz6vNmP for ; Mon, 12 Oct 2026 03:59:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j33dN0rjPz4gFq for ; Mon, 12 Oct 2026 03:59:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791777592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yAzzINjoAuUdWhsBm1kTEYmGWArWnDRYP7p5KUjrYWI=; b=oHsaUzXpNXk+zxQf3IYm+oyAX3EpKQ8j7Dqy/TybtwWysyon4zZ1MdgVE+xcOaFUoiWKB6 IIpNDDsRYCAXRl5jiNQdHCcmBrcnqPNk0j1pw/waz1bpdVLu67adc7XUo8aHJHj4O6AkDj TRGhHH9HtNsF6+LFkOPkLwrpNkZ3qOOLGwFTrSl22HhGay4hMoJoJgLF4yXpLHAYLhDGQ5 MJ1nhrnV8bR76+jFrp1lYKU2eKl1RqshOcObRh1x3ltbyODQLcANTvlV+gC7wEktzY4Y8J lSsR129wcNqs9kDLhL7GfjF2kCq1CGb8+DDEmW8LoLpwf/433lvXYmxXPBIqBA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791777592; b=BbKptoSeUihg49xW0Pg9ISfKFSoNjyaLRyWhmTrW4I3787yG+m3cdxktehOaScVBdlWYQX GKSipZtPA1DgeyBxL+YiI7Pfhv/xu8ijxPP+C9GYdt01YByeFsyqtOqjgbfAR2+td5f6f2 tch6qs6Db6VGWYduPp5TmjB6kIAYfJ+pwMUk8/I4DEbJxSQBZsUQ+2sAb6PNpdOg5h9K9N FeVw75e4MtQsQhiyb3pTAYomB7JVvRVlhdKb2ehP8P0oI4YQiyUM8KJMfMybvEF+5/vml9 sAjpwqJBZqWUXvWh1591QU2UDn1ub8qptKt0YtYK1sRQjUgzmVZ+rXLrABzVmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791777592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yAzzINjoAuUdWhsBm1kTEYmGWArWnDRYP7p5KUjrYWI=; b=waDxMQ9KzVmXw7/bhxUae77K0+QR7zrIxm/NnkhYxKiIObESykqoYnzLWkQcpZENHBA40L V/KO9Z4qnvfLEKMUp8XuIkTeHxy4VXUcgl5rzKNaHOaBQW13x/f7Nrlkc5Ey9TQ2m2o0lK 6y2JorvGQJALr0m56wj57UFg4f+ZOgHbDSC6uYJJ4r/MoYepefIlUNdCslwtaOJXZTpkY/ dUJ3ZVUDw3gmTbZKj2grcKDG+G0j0NlfKmIa2ZOesXGuFiOzJAdxzG2/f5ox50DRjsHsiD Mmnel1HM8zqXjqRW+njhDJ2XqImb9Y9tHh30YrbaztUhWQWJKpEjGRSp+GjCZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j33dM6yqyz1B46 for ; Mon, 12 Oct 2026 03:59:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19402 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Oct 2026 03:59:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: ff904d783889 - stable/15 - arm: pad minidump page table List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ff904d783889fe99b595e483e543b81dcb63e58c Auto-Submitted: auto-generated Date: Mon, 12 Oct 2026 03:59:51 +0000 Message-Id: <6acc5b37.19402.31c11248@gitrepo.freebsd.org> The branch stable/15 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=ff904d783889fe99b595e483e543b81dcb63e58c commit ff904d783889fe99b595e483e543b81dcb63e58c Author: Minsoo Choo AuthorDate: 2026-09-16 00:14:45 +0000 Commit: Minsoo Choo CommitDate: 2026-10-12 03:59:13 +0000 arm: pad minidump page table libkvm locates the sparse page array after the page-rounded PTE table size, but the ARM minidump writer emitted only the unrounded size. When the table size was not page-aligned, libkvm therefore read every dumped physical page at the wrong offset. The mismatch was introduced when libkvm began rounding ptesize. It has affected ARM minidumps since ffdeef323449 ("libkvm: Improve physical address lookup scaling."). It is exposed when the dumped KVA span is not a multiple of 4 MiB. Zero-pad the final PTE page and include the padding in the dump size. Reviewed by: jhb Approved by: jhb (mentor) Fixes: ffdeef323449 ("libkvm: Improve physical address lookup scaling.") MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59716 (cherry picked from commit 4cb357c61c004f4cf27ca12e702b44a81f2752ab) --- sys/arm/arm/minidump_machdep.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/arm/arm/minidump_machdep.c b/sys/arm/arm/minidump_machdep.c index 2e7fe6ebc51d..6bf2ffd08b33 100644 --- a/sys/arm/arm/minidump_machdep.c +++ b/sys/arm/arm/minidump_machdep.c @@ -187,7 +187,7 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) /* Calculate dump size. */ mbp = state->msgbufp; - dumpsize = ptesize; + dumpsize = round_page(ptesize); dumpsize += round_page(mbp->msg_size); dumpsize += round_page(nitems(dump_avail) * sizeof(uint64_t)); dumpsize += round_page(BITSET_SIZE(vm_page_dump_pages)); @@ -269,7 +269,9 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) } } if (addr != dumpbuf) { - error = blk_write(di, dumpbuf, 0, addr - dumpbuf); + /* The sparse page array starts at a page-aligned offset. */ + bzero(addr, dumpbuf + sizeof(dumpbuf) - addr); + error = blk_write(di, dumpbuf, 0, sizeof(dumpbuf)); if (error != 0) goto fail; }