From nobody Sun Oct 11 16:34:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j2mQt5Ygjz6vQky for ; Sun, 11 Oct 2026 16:34:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j2mQs5nvzz4Fjm for ; Sun, 11 Oct 2026 16:34:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b="UXJAdcs/"; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::1036 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-3a4cdc9025bso488488a91.0 for ; Sun, 11 Oct 2026 09:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791736483; x=1792341283; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0d9aDyKNYTGD/FHsDUmps7APzWJBZiaPDIjIsZOyhKs=; b=UXJAdcs/HlH0fiHSh6dPqYc6c93CW3yGau2mdJcZdWbDli6GQNZNQDBkSsI1LhZtyl fesrxwxZMbOJkj7VP907UfFEXdejoJhl6Qo67Qb29UKwuME2hb4HWXwPp/U5oqxONISf 0WyCy3I4/biJeqtgqd8lO2FiOPtnh1B8KpO6qpym2pgxFGVhBrdtM310KKTayoOwRnd7 7+O0FWBMIqu8tt/DOxqcT9Ix064WsS9u98xt/EIBngJzjq6sU5TqCh1M4Fvu/tPIpUzx lMPFsHsh51sxE6f5UfTjCEifzGby+bXKvbNU+JAlOMLLE9KYOCTitoMVnqfqaf+OZnMh ZWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791736483; x=1792341283; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0d9aDyKNYTGD/FHsDUmps7APzWJBZiaPDIjIsZOyhKs=; b=BRnQI4EbM1dPaKsLnRWuPRLypUjTlQ68qRj7GPLSZlgVTxLfgQgE3IMg7+dEuRTkyq Hx2ccFltSItcXgymoLDaHiTSNUQg2Fh71z3eOwENlxjDxQa/Y1k1Kx+UQKGFK/cdjlc0 et/L9pav5CmW6sf62wk/ojs/IQxCpZEStfZwxywDa8k8tCfejxwFVg2WDs5MQc/asvG1 7uUKY2wyLzL9LB2XhxHw7PtPLrBm8KS8XNukTfBylaGtmruc8C0MtzgWVoSXGnxWFdRD rm6dpULSusV81zdrZl3woobQmoKo5fulMobE3tmFNSsTrmDw1TPzFDf/Bt6SC7WIjUjr jXmg== X-Forwarded-Encrypted: i=1; AKwUvBzgcHunsGFpvb95VmU8L74QKOZCJExBIjEcmURvhVOa62zbakqY3Oh7XVl1ehbOhXd8OtV2KtxQgNbFaz8mBz/Ub2Lb@freebsd.org X-Gm-Message-State: AFq9FYKZH/FZgFz/1fEnSZ8nXoDLRA/+as11sw/tNX8XbsonfUE5cOiV Ix5Bp/T/MpwnA05qBX9KqM8woLccsM5pfydlE8M85qh7I8bQwTi0dKrv X-Gm-Gg: AYBFou2t97CZ0pWS4vnzHLIlKW/MOefvL68yEMzkUbPw1FNQddChoGBOmmut0BE+qj4 DFYSfU4s4/Gvkj586wNzhHqsNZVUAZIOC9MvdDdcFdf2RqEYFuB5IG+Nmplp0ZPbhyeePolWuu+ MSG5n6+9NwzZ6tVb6vwA3/aXXbBj/OLzsdgtL7aD6uEYenc3aaJWraY+0Y02DaBfqyJ+U2KbrQ9 mxC/il7fOZWi+EGVUyI/cKWeuhhWdwteaqcDUg7iMUFs4D0iXw/6/QhJUGkTO24oI8cAUxobaO2 WsqUrYhNtBZmn6muIX84do/wFRq2DK46arXKA+203ANZ+s4WqU8O43UoWRXBuHEECWJQEt3udzn kteOdxeOIXxZ2odzQaBQXLR7YJJhIqHQ2uEmV9wUhfZcKbWIxZF7M0KRcBcCj0eW/OPJO7f5lDB B4WhtFm4pIa/uP5iTPnKix1cEriLRyYPGaOasMvlkA6gjdUzfwGokh1BYppGbYqR3CfaCRMazdg xQB3ApH1TL2e6Y91NBAQA== X-Received: by 2002:a17:90b:540e:b0:3a8:1ffc:391b with SMTP id 98e67ed59e1d1-3ab3a9fc979mr5326019a91.43.1791736483301; Sun, 11 Oct 2026 09:34:43 -0700 (PDT) Received: from smtpclient.apple ([187.15.153.28]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab36ed0daesm12706377a91.5.2026.10.11.09.34.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Oct 2026 09:34:42 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <0C654DF4-A715-4E10-BE12-4F6079E8297F@gmail.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_7535E1C5-491B-48CC-88ED-47C3AEEAE0A1" List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: c01c0a27cb82 - main - openssl: make libcrypto export the same symbols as upstream Date: Sun, 11 Oct 2026 09:34:31 -0700 In-Reply-To: <0DD87313-7217-4F7F-8996-17D1906FC3AF@gmail.com> Cc: Robert Clausecker , Gordon Tetlow , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, "sjg@freebsd.org" To: Konstantin Belousov References: <6ac806da.36b2d.5a40f66f@gitrepo.freebsd.org> <6A686A43-F8C3-4E70-AD36-1F0AF9BA0B8B@freebsd.org> <0DD87313-7217-4F7F-8996-17D1906FC3AF@gmail.com> X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Spamd-Bar: / X-Spamd-Result: default: False [-0.50 / 15.00]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1036:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+] X-Rspamd-Queue-Id: 4j2mQs5nvzz4Fjm --Apple-Mail=_7535E1C5-491B-48CC-88ED-47C3AEEAE0A1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 11, 2026, at 9:21=E2=80=AFAM, Enji Cooper (yaneurabeya) = wrote: >=20 >=20 >> On Oct 11, 2026, at 2:42=E2=80=AFAM, Konstantin Belousov = wrote: >=20 >=20 > =E2=80=A6 >=20 >>> Yes: the reason is that we should strive to promise compatibility, = even to our >>> own bugs. It doesn't hurt to put these symbols in as compat symbols = (which in >>> particular should mean that they won't be accessible by newly = compiled binaries), >>> as the routines do in fact exist. >>>=20 >>> With the next major version of FreeBSD we can then do a somajor bump = and get >>> rid of them if desired. >>=20 >> I fully support both the opinion expressed by Robert, and the = proposed >> solution. >>=20 >> In fact, there _is_ the observable consequence of the ABI breakage. >> The need to be careful and upgrade libcrypto and libssl = simultaneously >> is exactly the breakage. >=20 >=20 > Ok, I understand the concern now and agree. Point noted for the future = since I was a reviewer. > Gordon: could you readd the symbols to a compat section? > Thank you, > -Enji >=20 > PS The whole major/minor SHLIB_NAME/SHLIB_LINK concept isn=E2=80=99t = supported in bsd.lib.mk, but it=E2=80=99s available in = contrib/bmake/mk/lib.mk. I=E2=80=99ll work with sjg@ to introduce that = support and we can work towards removing the symbols and bumping the = SHLIB_VERSION at a later date. I filed a followup issue to track what I described in the `PS` section: = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D299312.= --Apple-Mail=_7535E1C5-491B-48CC-88ED-47C3AEEAE0A1 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Oct 11, 2026, at 9:21=E2=80=AFAM, Enji Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote:


On Oct 11, 2026, at 2:42=E2=80=AFAM, Konstantin Belousov = <kib@FreeBSD.org> = wrote:


=E2=80=A6

Yes: the reason is that we = should strive to promise compatibility, even to our
own bugs. =  It doesn't hurt to put these symbols in as compat symbols (which = in
particular should mean that they won't be accessible by newly = compiled binaries),
as the routines do in fact exist.

With the = next major version of FreeBSD we can then do a somajor bump and = get
rid of them if desired.

I fully support both = the opinion expressed by Robert, and the proposed
solution.

In = fact, there _is_ the observable consequence of the ABI breakage.
The = need to be careful and upgrade libcrypto and libssl simultaneously
is = exactly the breakage.


Ok, I understand the = concern now and agree. Point noted for the future since I was a = reviewer.
Gordon: could you readd the symbols to a compat = section?
Thank you,
-Enji

PS The whole major/minor = SHLIB_NAME/SHLIB_LINK concept isn=E2=80=99t supported in bsd.lib.mk, but = it=E2=80=99s available in contrib/bmake/mk/lib.mk. I=E2=80=99ll work = with sjg@ to introduce that support and we can work towards removing the = symbols and bumping the SHLIB_VERSION at a later = date.

I filed a followup issue to = track what I described in the `PS` section: https:= //bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D299312.
= --Apple-Mail=_7535E1C5-491B-48CC-88ED-47C3AEEAE0A1--