From nobody Sun Oct 11 01:09:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j2MvK71yFz6w8cP for ; Sun, 11 Oct 2026 01:09:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j2MvK6JVmz3JRs for ; Sun, 11 Oct 2026 01:09:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791680973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8m+LBXqocbgerncnopHDH5p9OCzMlZtlHi+/WojEdyE=; b=LH/4MzcqRUzXjCMlTmYjMoL0U5RZK0GCJdudsNBJeCXQyJ8YzDr9/G4u52z4MQDHvb7YHC EioANqEVgnW8y1PgurddI6sJXv4YFUiYwoIW2can8R/C9kJg2VcjfeF/WeBNMIzjanDcHH 7oLbhwGTbNcXGImzNVmADMDss99Ezmg1BX4IKBccXcbpU3IrYLMv7NvBZA+xdMP9Dss3rJ a4rMriVL3Jtrsl2Jxwk8qd5ia+5gZmDRWdfXsM9mYBSXympG9+KYujPr39jKrnv8X+zasl Mh5nfUTdiBYDKjzfaRMkqTPBFqxUWD73gg2ot7lEKm5NFLlZPbnTRToayeLRaw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791680973; b=Cm34AHg9K3tgjk09cx111idSKxZSlgbU3J4C3en5Y8mxZJ+60/RrRqaJGDVv16ofX9SUYz +3TVeN+iM1Mm7OEjdpkJOpVm+uImtdgafU1PiLPoPVuL00uCcq002upDZQVMZ6skA8RlO8 YLPy+IOKQ/yUpnUeIE9F8rFaML4gta8wod0Y7m1vYp8u/QIWCOfqzDNKwoBXMGclWd6Tfu StO9b56E262+h8b4Mll14vwpw8TQ8y7Rrh9bxBgCNR2x8CVgVQsx5z9YT4qQP1jywgPLlx nkejQVxfMoAPBEzIyQz2Hx41mhRY6+KlbCF8OVjpCooF3qTs0A/1NR6DeCb2eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791680973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8m+LBXqocbgerncnopHDH5p9OCzMlZtlHi+/WojEdyE=; b=cdr5mhxDZKZSCq7w+5qdrpa3kD/4aejdBVPlQFMXlyzcKVmcrUgmcNg+/qmUgnofybq10D 0f4ujWZgpsE3SIi6z3VRQRycFa5dtHpTR2+telT4mEQJiaYTJAjvYoPaZ+Kni4TW8a13GI ygPzXgkGe7Nx83gRybMKHliFaaW1GvvQLnVFvB26l+QHIto0oZUaVNqb+Gaa3TfnTdj9dr e3zcxjHZJQHVJYaOixZdQe31tequHSRsYDtZTHylkJGvd7HIoxmtYCMTwdCwCf5268SB2K acP+fZmgwYFuvzRn0ihmzCmpqjeJXBnHuZ+TSLvxbhX/lU3shatt3l518ndOwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j2MvK5MY6zJgB for ; Sun, 11 Oct 2026 01:09:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33a29 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 11 Oct 2026 01:09:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Olivier Cochard From: Kevin Bowling Subject: git: bd54c7bd59df - stable/15 - tpm_tis: release TPM resources after reading response List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: bd54c7bd59dfcc9e6243377f9c560099d2b1f65f Auto-Submitted: auto-generated Date: Sun, 11 Oct 2026 01:09:33 +0000 Message-Id: <6acae1cd.33a29.304522e2@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=bd54c7bd59dfcc9e6243377f9c560099d2b1f65f commit bd54c7bd59dfcc9e6243377f9c560099d2b1f65f Author: Olivier Cochard AuthorDate: 2026-06-26 19:20:30 +0000 Commit: Kevin Bowling CommitDate: 2026-10-11 01:09:23 +0000 tpm_tis: release TPM resources after reading response Per TIS 1.3 section 5.6.12, write commandReady to TPM_STS after reading the response so the TPM can free its ReadFIFO and other internal resources. The subsequent tpmtis_go_ready() provides the second write the spec describes and waits for the state transition. PR: 295103 Reported by: Benoit Sansoni Reviewed by: kevans Approved by: kevans Differential Revision: https://reviews.freebsd.org/D57841 (cherry picked from commit e4c50d86796d07cf90e6a683234e1c0e9ca5e03c) --- sys/dev/tpm/tpm_tis_core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/dev/tpm/tpm_tis_core.c b/sys/dev/tpm/tpm_tis_core.c index d831339342dd..08d37ebcfe19 100644 --- a/sys/dev/tpm/tpm_tis_core.c +++ b/sys/dev/tpm/tpm_tis_core.c @@ -572,6 +572,16 @@ tpmtis_transmit(device_t dev, struct tpm_priv *priv, size_t length) "Failed to read response\n"); return (EIO); } + + /* + * Per TIS 1.3 section 5.6.12, write commandReady after reading the + * response so the TPM can free the ReadFIFO and other internal + * resources. The next tpmtis_go_ready() provides the second + * write the spec mentions, and waits for the state transition, + * so no wait is needed here. + */ + TPM_WRITE_4(sc->dev, TPM_STS, TPM_STS_CMD_RDY); + TPM_WRITE_BARRIER(sc->dev, TPM_STS, 4); tpmtis_relinquish_locality(sc); priv->offset = 0; priv->len = bytes_available;