From nobody Fri Oct 09 18:43:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1bP96NlVz6vt14 for ; Fri, 09 Oct 2026 18:44:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1bP90lgXz4tXf for ; Fri, 09 Oct 2026 18:44:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=cbAaWiEv; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::435 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-88b8f0a1bcdso10124b3a.3 for ; Fri, 09 Oct 2026 11:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791571451; x=1792176251; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=h/DLBw70/X7yR/JG+ucsg95wQrgcdP8GrpvS772B9DQ=; b=cbAaWiEvmKCkHVFyxvugLYgjIt1fSPcjPB1ztoVBDvQGrgAHxSo1hfgSCRBdkv45Wx CIi0SC+W4f4ororfBE5DY9rDInNccjwsPu/1KusRXtK56Xqux2bO6BVkPqKvGqPT3mm8 Mi8Bq7dxFIrexARYirfYHASdIcMV4vJCAhObA5XuzMbjEkdQ4ay2z3caBlDcYM1I/2JX WA0W4CUGYaULc6KxGNqwgsZZV49DewQ+O5U1is1Zcogzxhx8UB7hY7Dh1jMei+nAkklo umHf5JjmV4O1sPzAv8R2e4eAyuuFDAT9SzQJZtGexx7QBRUhEO2Y1SlU3SAKMGxuznaf NVrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791571451; x=1792176251; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=h/DLBw70/X7yR/JG+ucsg95wQrgcdP8GrpvS772B9DQ=; b=YF/trTfk0VKP2dMRVBfAr2wq00mDNdByfiWjJlg6gZWcbinpS4OMwaxGpvHyeMLNu7 hqLq+0cE+ii8IDT3umBWAdVtwAFM18IEMUMlu8i3ysmVgf5kb0NMq2rHrjQErckf3woF Zr6+AmuzvJzRNiWC2xvUB/6jB9QrhE0SYAgGM/nD9tI1i62fRfQVdbSnRQZH2lB+Ag9R Iu2QqQ9zKib9yQETDecrbQf3v0PCsGst2o5Lh2NriSIUaIwAv2riSJN8aDg6HFng/XxR hseX+IC0MDmwcFCw5dEmgkYfjrxZ5lQUUHMZukixdUXINUGUissCQRvVF6q8h3rTHMZ9 PsGw== X-Forwarded-Encrypted: i=1; AKwUvBwBqPzV7h9WUrED68Etoq/HIFJKigjNl6jhNmOfcT9f/gbIBCvyPowQllZoibY6X+QJI+v0BpkEcKfVZtOlqj0DQdYs@freebsd.org X-Gm-Message-State: AFq9FYKEb8pC7w9poCAyVqv9ukekChoNM+QppVt4ecDXu1HvT89T8p7q C+Ph77rk2mXhUYeeJBL1mBbwgsHjbV8qNsoVCvFhJUlKTuaOk8CsDvIM X-Gm-Gg: AYBFou38Q0LAvp9x18y/+aKVoLX5lONzRdqeoqUO6WuUjqz0tvx8XnOKfdPkeXvNvy+ ctrFwiB2MMulozlUss4XjfJXA9aBZ3yaPbYqg1L5SjXG6k6AM/LRkUY0tXV8SWV5JJEbvnnSiHu M+IMf2zJ1lk0gsXY5Jz3PJZ7+KnneqGwdjgdl8N6YJNtiV3bl1v4KUwSKNArMJCjS8IVyncwPeg AYzE2TdjmK4x5axud1Rc96kmIs23rIsUIsVefEIQvKkUOLw4EPUwqI8fxyPFQIjOksT+qyKH8xL n6Lz5gP0+FV5KKVQnAdYX50APrSWpRSmHTYNNWc5iWvjOLynmGu39zOYJLWD/6EVwqaKE/sclzM 6xbxw6uPt3NXda0CvwvJzzBOMCLaZfKVD7YmaDx0yHq2rRDw7EYwbqEQx+eqA0Epa9NFoBhiAdY iDY+im9rsNoBbccKqenp+xTEEqFXXcKZNvUr36P8SeZ1/Szu+vZ+uVd1kWB9gh17ba/JMeYdd1M 8ervy2C5njuuksp6L0i X-Received: by 2002:a05:6a00:3385:b0:886:c8d1:632f with SMTP id d2e1a72fcca58-897c82b072amr2458464b3a.42.1791571450600; Fri, 09 Oct 2026 11:44:10 -0700 (PDT) Received: from smtpclient.apple ([187.15.153.47]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-896c3107194sm1566802b3a.18.2026.10.09.11.44.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Oct 2026 11:44:09 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_BCF9A154-3E24-4CBA-8102-345A7D1C61CA"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: 24d5194306b5 - main - build: Emit a warning for build targets run as root From: "Enji Cooper (yaneurabeya)" In-Reply-To: <6ac9028e.3a17d.35333feb@gitrepo.freebsd.org> Date: Fri, 9 Oct 2026 11:43:57 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <6ac9028e.3a17d.35333feb@gitrepo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_THREE(0.00)[4]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::435:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4j1bP90lgXz4tXf --Apple-Mail=_BCF9A154-3E24-4CBA-8102-345A7D1C61CA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 9, 2026, at 8:04=E2=80=AFAM, Ed Maste = wrote: >=20 > The branch main has been updated by emaste: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D24d5194306b573bf3396858b4c0aa5d4= 20c37c91 >=20 > commit 24d5194306b573bf3396858b4c0aa5d420c37c91 > Author: Ed Maste > AuthorDate: 2025-05-14 15:23:42 +0000 > Commit: Ed Maste > CommitDate: 2026-10-09 15:02:30 +0000 >=20 > build: Emit a warning for build targets run as root >=20 > Build targets should generally be run as an unprivileged user. = Even > though building as root is discouraged many users do so, so just = start > with a warning. >=20 > Reviewed by: brooks > Differential Revision: https://reviews.freebsd.org/D50352 > --- > Makefile.inc1 | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Makefile.inc1 b/Makefile.inc1 > index c1dd1fe836d3..6a228a29ed5d 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -375,6 +375,10 @@ test-system-${_t}: .PHONY > .elif ${MK_LLD_BOOTSTRAP} =3D=3D "yes" > .info SYSTEM_LINKER: libclang will be built for bootstrapping a = cross-linker. > .endif > +BUILD_USER!=3D id -u > +.if ${BUILD_USER} =3D=3D 0 > +.warning Warning: ${.TARGETS} should not be run as root > +.endif > .endif >=20 > # End WITH_SYSTEM_COMPILER / WITH_SYSTEM_LD I don=E2=80=99t think this is the right spot to do this because a lot of = targets like `_libraries` are invoked via submakes. Please see my comments in the Differential. -Enji= --Apple-Mail=_BCF9A154-3E24-4CBA-8102-345A7D1C61CA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrJNe0ACgkQGpE5DjPs NJi+kBAAgXRAUBhOoahdNOiD0pbv3GF3/XonDOC2Hp4oGF/e8IRs3gbeLtEJnQXP 7k2biVLnu8AmllKIimm0sADqjYSkWu2eJc9CjwIvcMShyWtYhvMiN8kJJKD1N7fy PidDXt7sJaeKy/MbcGOlQMCQbud1zG00iK3mXxNiphRYrWhvS6pOa8OLHJEGsQW5 0ydQ6YjjA8ypCuIi/EzlsxZGyT+KUxx87r36Mq2Bqr1XkhDE0UVHtVVWKkFxC3Ir ggVmivVFi724EQgqWunuU4V0FPO5SM4ITKRuEfADPKFKygjox6b8NJZXxCrWJqbu H9Y8ijD9RgI2/4u4Rlzeo6a6SHZnNCx4b4UT/CIH3vfKYZj0YdXDrUJOX9aCLR3t NiUAIp5ehuL8jqWDm0gsjUFwiwgPNqlMPetr+ng0hpYSTf5p5hRuHij7t+b75L/G 4oWOJNTrOxxpxCJ/U3kjIZ2qgzvV+miA3kla7FqMi6nGmqwfNcjcQ6HyLkszU6kJ GyiRKbsN/XlihVeaeb+ZeIPG5vel9cvxx5s7502RUlPGhSacICR/61z00yIXfK2c 7bvY/5lCXVF09wn31OEz/lzXNsMJXVUVPJNm7dm+Z0IJkIt5lkFOTyJtTq87/xT1 hiJ5NWawFkZTTEgonZCNdhvkEyewR0Ne1PfqLi55uO9q4X/1TmA= =IP6A -----END PGP SIGNATURE----- --Apple-Mail=_BCF9A154-3E24-4CBA-8102-345A7D1C61CA--