From nobody Fri Oct 09 10:12:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1N323F2dz6vRR9 for ; Fri, 09 Oct 2026 10:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1N3200nRz4Y79 for ; Fri, 09 Oct 2026 10:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xmo0drK9/gqk6q8AM7RN7A8coyKqJSJGSA7OS2n6dwA=; b=XHAjbgYSFrqhzT2uIlxZIoCY9Qlfo+IwDeZVOxqXkZk6CZzMe8hpfLWZln6iESZpHUNpu+ 9hY/zfJo3xzc7tZioQGL1LEeusvYOqF/sROwl7WwSOpKvGKvarZGiw6gOJI+CXt+5eIHF9 fqeplpp+vwzsyps1kVb0QIkN81Y4PaE5ITQEn6PsnIfu4vJvIhhMXEf25lSDU2oJtuOgdE WQLNys/cRHfOxxpEXsKdSdA3BFQtIcBTktEegB29GQCBRNkym7OvI/e7WxCD82O+JnAn4u ho+7BJVLAFrw6ZhiD0Qf7ln8/X7x4ycb3yHIJ+wvTgppX6VW5eKCuPyzvhtCKA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791540766; b=VYA9VPI6RaARwcZLwauE6A08vxUrBWtwGWjch7nZbWM+mgLZITJ4Pm+X15NAylsdqQRmqs uftn5gKHeUf/gCSTmRkRWJusxzAeBgtoJWa/WWdSY3kj+2L+UexM6Ga99PLQPQTfu5ZmaP KY/4LFBr47pvV6VrGUjgd4Do8U/ifAKnuKjSiwixMOIOKtn0IBQGPU99dcjL7qfGu2fmbP KDm7uShqKQLUM0qbzejntzJaOTeJ8bvCr/70QYF5Mq+KKR9LhueYqmLRPHuqACV+9jmq11 EFqUbVgdgtntUJRPwt90pr8sFuoUIvlxQQiF1EwMo3K8O7JKlbFoc4jLQ6XpRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xmo0drK9/gqk6q8AM7RN7A8coyKqJSJGSA7OS2n6dwA=; b=hwHZLnvcHBN4ZbPsedZbhwfco3VyJVzXXzXBb79MNHmOpufDaTdYwrv7hpjutskpQ0S+rI xDSQ5vomnLGjFWvmZanLRG2oVPoqAaq6ytDWbKem3bJ9Wq+0NRqfOvQKm3VitBmfP/Jc+V UjUF5CKhkqTETSlMC5kqOJfGL4+VazgQUd303lp4Muxhc13WHjs3bQrSCNFxYIHX4JjkIK MRDNG8TzIpXolNaDCHhG6RWVkk0Xf+9NcfN9eVNzjAucJtLuAToJIOeFUg8MtKQz8VMI07 tuUBOoatAzi5Dox3R7sMsjm5QqcDE/+dRaC5ZTwTv4FPKXSxagYkQ2omWbsqxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1N315fnwz1L43 for ; Fri, 09 Oct 2026 10:12:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42e11 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 10:12:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sumit Saxena From: Sumit Saxena Subject: git: 492bd0db44ba - main - if_bnxt: Collect hw stats every 250 milliseconds List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ssaxena X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 492bd0db44bace9475e15dfebdc17076b536533f Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 10:12:45 +0000 Message-Id: <6ac8be1d.42e11.497edc9@gitrepo.freebsd.org> The branch main has been updated by ssaxena: URL: https://cgit.FreeBSD.org/src/commit/?id=492bd0db44bace9475e15dfebdc17076b536533f commit 492bd0db44bace9475e15dfebdc17076b536533f Author: Sumit Saxena AuthorDate: 2026-07-31 15:49:32 +0000 Commit: Sumit Saxena CommitDate: 2026-10-09 08:24:44 +0000 if_bnxt: Collect hw stats every 250 milliseconds bnxt_if_timer() only scheduled bnxt_update_admin_status(), which polls HW stats, once per second. Drop the interval to 250ms so stats collection is timely. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58610 --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index f6aeab9095d6..6768e313f78d 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -4260,6 +4260,10 @@ bnxt_update_admin_status(if_ctx_t ctx) return; } +/* Poll interval for bnxt_update_admin_status(); not sysctl-tunable, unlike + * other driver intervals. */ +#define BNXT_ADMIN_POLL_TICKS (hz / 4) /* 250ms */ + static void bnxt_if_timer(if_ctx_t ctx, uint16_t qid) { @@ -4267,8 +4271,7 @@ bnxt_if_timer(if_ctx_t ctx, uint16_t qid) struct bnxt_softc *softc = iflib_get_softc(ctx); uint64_t ticks_now = ticks; - /* Schedule bnxt_update_admin_status() once per sec */ - if (ticks_now - softc->admin_ticks >= hz) { + if (ticks_now - softc->admin_ticks >= BNXT_ADMIN_POLL_TICKS) { softc->admin_ticks = ticks_now; iflib_admin_intr_deferred(ctx); }