git: a72d720838d2 - stable/14 - kld: Reject kernel modules with PT_LOAD segments where filesz > memsz
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 09 Oct 2026 00:20:49 UTC
The branch stable/14 has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=a72d720838d20ef3b51756ee53e49c66cd0b324b
commit a72d720838d20ef3b51756ee53e49c66cd0b324b
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2026-07-31 17:52:42 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-10-08 18:47:42 +0000
kld: Reject kernel modules with PT_LOAD segments where filesz > memsz
All sorts of places in the ELF loading code assume that filesz <=
memsz, so check that explicitly up front.
Reported by: Jane Smith <thebugfixers@pm.me> (via D57785)
Reviewed by: jrtc27, kib
Differential Revision: https://reviews.freebsd.org/D58542
(cherry picked from commit 486dfbb67e093a461a5ebd97f66be9b345f9de77)
---
sys/kern/link_elf.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sys/kern/link_elf.c b/sys/kern/link_elf.c
index 18826b7a6360..04281a7efd08 100644
--- a/sys/kern/link_elf.c
+++ b/sys/kern/link_elf.c
@@ -1086,6 +1086,14 @@ link_elf_load_file(linker_class_t cls, const char* filename,
error = ENOEXEC;
goto out;
}
+
+ if (phdr->p_memsz < phdr->p_filesz) {
+ link_elf_error(filename,
+ "Invalid program header");
+ error = ENOEXEC;
+ goto out;
+ }
+
/*
* XXX: We just trust they come in right order ??
*/