From nobody Thu Oct 08 20:44:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j12623lxJz4n2qd for ; Thu, 08 Oct 2026 20:44:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j12620kThz4cGc for ; Thu, 08 Oct 2026 20:44:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791492250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GkoTYiyAcGxMp6MHuDTAgv1P5YdDkbIoxF+8NIH8mkw=; b=gMrf75u98BmqrDTUPGv8jWShV22KWtMZQuyvnKAmnRSzBKwIT5PRv6aJwVhV72iksfm2G7 XegIa/Cu/0G39w48Hm8n4wyHuEtbe7mznSIcGXs7Jb87WOtpSQ4aodcZp271VPOuYOsDf2 hkadOTB+dtvnQRTvYTz/Dv7Tra+t7VZQrCLMqFVbiBKE4ZAnfK/F69eqvLi/s8EJTYqbki OAuxyBI+f3ltZB8daH44rUBPioUKXR9FbZAqgWxQx4gmUq23m5ykfoYtPLKmpo56SyjXmp YdtvIy9SjJfzGiRa+AzYyuOO16lGYRWnc/AgXkFr9om6hZS9xtvTx6X7l6ZuTQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791492250; b=prmKm1Q1gtjA2F9j0kMeAxjtgJPzgrof1iil70mlyfeWeA/Awn4xK3to3bYVjecMcE5Ff+ aIU1omu0bfSUjiOar5vdZzJBTjtZhxjn/aP72mUQCcCpVo9vi1PgAe0LLtwo5f2qMN7PEN WMhbynfKm8kfuT0apqG3D9qjDAE+0a9WPpL1MsD9rxV2B3UAkcGCDEGR4M9i4ufE+8lWu9 Sq/OJHKrN1D44uTMe6lClaVVZRTiVxT8GXWR0YTr9JYh6BrzbauiETSUG/mtNac4BoDPLz U3gmqTzzzxuXmjGLuxUmOIWiq22igFwaUhK9v/0Ov9WpeTS2bVy6hL9dUamhXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791492250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GkoTYiyAcGxMp6MHuDTAgv1P5YdDkbIoxF+8NIH8mkw=; b=yQ0Mo/Oo7RL6JJUYTLULs/HlHnj9ZTTZPUFO4ZYNOiqeX7cRmA2vtgDxYjsGPqyTsMpxp/ xx7shFZvGvSfGURl6qCacE3JQ0/LPsDTw0wx0bQE3E8IKPEbe1aCWTVu/49UDFJfUk+DcR tQstCHJWYCUM2SRjgEkrSSKSiImPBfFSN2ogLYM9ghl77NkApKIX2RlMNeQpTMGn2nC4r5 f3IuHq3dTBs6HuLRKUiLbmZleKmVj9vVrwTBQDJGlqo6DWMz4ILZoHPSNPT6V8fiif5DPj nWCrVIJMKz8cq4+nqoQR/53DRywxlYgsoMSCkZPjKkAWYHsJV80Dhc4ZvQYJSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j12616sVlzwWc for ; Thu, 08 Oct 2026 20:44:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27cd3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 08 Oct 2026 20:44:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: e77f9f06e3cc - stable/15 - bhyve: Tidy lobits handling in pci_passthru List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e77f9f06e3cc191a2ebac4fc2c86f37ad3a4d163 Auto-Submitted: auto-generated Date: Thu, 08 Oct 2026 20:44:09 +0000 Message-Id: <6ac80099.27cd3.61e1c01e@gitrepo.freebsd.org> The branch stable/15 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=e77f9f06e3cc191a2ebac4fc2c86f37ad3a4d163 commit e77f9f06e3cc191a2ebac4fc2c86f37ad3a4d163 Author: John Baldwin AuthorDate: 2026-08-26 19:31:01 +0000 Commit: John Baldwin CommitDate: 2026-10-08 20:42:32 +0000 bhyve: Tidy lobits handling in pci_passthru - The lobits field in the "physical" BAR settings is never used, so don't bother setting it. - Expand the comment explaining why the existing lobits are preserved (namely, to preserve the prefetch flag on memory BARs). Reviewed by: bnovkov Differential Revision: https://reviews.freebsd.org/D58894 (cherry picked from commit 0ffad4ce5655cbe412b79185d2b7924d0d72983e) --- usr.sbin/bhyve/pci_passthru.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/usr.sbin/bhyve/pci_passthru.c b/usr.sbin/bhyve/pci_passthru.c index 740d9ad45d03..615b0c639bbe 100644 --- a/usr.sbin/bhyve/pci_passthru.c +++ b/usr.sbin/bhyve/pci_passthru.c @@ -678,12 +678,14 @@ cfginitbar(struct passthru_softc *sc) sc->psc_bar[i].type = bartype; sc->psc_bar[i].size = size; sc->psc_bar[i].addr = base; - sc->psc_bar[i].lobits = 0; /* Allocate the BAR in the guest I/O or MMIO space */ pci_emul_alloc_bar(pi, i, bartype, size); - /* Use same lobits as physical bar */ + /* + * Use same lobits as physical BAR to preserve + * prefetch flag. + */ lobits = (uint8_t)passthru_read_config(&sc->psc_sel, PCIR_BAR(i), 0x01); if (bartype == PCIBAR_MEM32 || bartype == PCIBAR_MEM64) { @@ -691,7 +693,6 @@ cfginitbar(struct passthru_softc *sc) } else { lobits &= ~PCIM_BAR_IO_BASE; } - sc->psc_bar[i].lobits = lobits; pi->pi_bar[i].lobits = lobits; /*