From nobody Thu Oct 08 13:08:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j0r0j69mlz6vdG3 for ; Thu, 08 Oct 2026 13:08:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j0r0j41Sfz4W9Y for ; Thu, 08 Oct 2026 13:08:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791464933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ob1vQayS7pWo+rkooFGTc3tmPwY9bfufK97Ji0mtu7M=; b=ZmyIjga0YFQ4GRPYyheWvfdJgdi8rLqFdRMvPEiPFE960Q1FtxtKf6v+XkKNs+e4kyaoJ+ 3Z8MYVbdevagYqtX4RKLraf02CWXV5F+79RD4MwoZ3PF/d74nmZ2M+7fjWF4mlsTEQNjGk tCQDQTLNHTx9pYAyrJbDff/IXk40KPpK+zQ4dgSld6/vXsNNdk/U015mZMmZsJSaBHaZ2H aKccQLag0/XxdlIdxWEMBAKh+I8HMkPaOANWYVfxbfXK8bZfco9ob/gjY6nApze4XkqGUv ERkLdZPLAGrXv9t9s7r+vyZiolZTvdakEwyFycYgQBB5aY9GII8S9ueBfHWmyw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791464933; b=Y5SPLltPlAzd1vJ/JXSkfJT/UcZ8GeN/KAofpyvrLY+OOaVWs/981/auIzP1zAmfoZ63Bu aGirLVaYRtuA96EeymOwn55xgGB6+fAGVEOrB4XutlTBKDiQVsCIwO12h5AtjSLpUKfNSp bZ2HdB8/JFDennoltmZ0yDJ7DsOcGrQvja3TUeyvC6iik4YF3UOdwYnuXjj9Dr1Sd6h8I/ Gp1NSsqfCfEokK6vUblzC14+vSGA2gUAR9KeNkbio6UnBIeFhv84bPOgHY8XXbmBjK+DOq NH4OJe/OYuyaOumzY7Eqeh0o4Tu15tWa1V6sHfF45M7s1o7LMG64RJd2Spi+Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791464933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ob1vQayS7pWo+rkooFGTc3tmPwY9bfufK97Ji0mtu7M=; b=Dwjy/4gqtu/hQNNfYWLRgUbHSEdeD0V7vEchmDlCbrzq73cIejnglORMnaMHt3IXF16KNv rI83nngA9KQXVEmeqqh6zTCrU6oWgh3RK3/6R7BViOc8jAaK5rMp2d9rYm5zRydDvrpQL/ ACBjkZhMGYvI0hbU628BmfyV10daV8wtvX9IUc5ukDzcmdRtst71kKFDyX+r9NJ7VvxMSI FoZy86zxYDVNe/gxhrGWxjGOWFwPPad0hazNBO7Ev6STev4ItovQ6fOZXuVizEGHVEMCHX N3PbHD67k6SXptNVpOmFbMnjuT3IByX5lOKvP/UwT9whXEWjKB6fer7hje+DWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j0r0j354vzhpH for ; Thu, 08 Oct 2026 13:08:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21933 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 08 Oct 2026 13:08:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: d39b12e9030b - main - sysctl: don't loop when EAGAIN is returned List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d39b12e9030b20410cecbcbb0c22847d7f8b5471 Auto-Submitted: auto-generated Date: Thu, 08 Oct 2026 13:08:48 +0000 Message-Id: <6ac795e0.21933.35ed90c8@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=d39b12e9030b20410cecbcbb0c22847d7f8b5471 commit d39b12e9030b20410cecbcbb0c22847d7f8b5471 Author: Michael Tuexen AuthorDate: 2026-10-08 13:05:11 +0000 Commit: Michael Tuexen CommitDate: 2026-10-08 13:05:11 +0000 sysctl: don't loop when EAGAIN is returned When userland_sysctl() experiences EAGAIN, don't loop internally but leave retrying to the caller. Looping was a problem in case of using tcpsso(8) to switch a TCP stack where the acceptance check of the new TCP stack results in EAGAIN. Reviewed by: kib, glebius MFC after: 1 week MFC to: stable/15 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D60444 --- sys/kern/kern_sysctl.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sys/kern/kern_sysctl.c b/sys/kern/kern_sysctl.c index ad2d4ae22a77..8c63f8073cb4 100644 --- a/sys/kern/kern_sysctl.c +++ b/sys/kern/kern_sysctl.c @@ -2580,14 +2580,9 @@ userland_sysctl(struct thread *td, int *name, u_int namelen, void *old, } CURVNET_SET(TD_TO_VNET(td)); - for (;;) { - req.oldidx = 0; - req.newidx = 0; - error = sysctl_root(0, name, namelen, &req); - if (error != EAGAIN) - break; - kern_yield(PRI_USER); - } + req.oldidx = 0; + req.newidx = 0; + error = sysctl_root(0, name, namelen, &req); CURVNET_RESTORE();