From nobody Wed Oct 07 03:51:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzzhF6lTHz6svpL for ; Wed, 07 Oct 2026 03:51:41 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzzhF1Zh5z4ktx for ; Wed, 07 Oct 2026 03:51:41 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of sobomax@sippysoft.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=sobomax@sippysoft.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3a865731ee4so1186012a91.2 for ; Tue, 06 Oct 2026 20:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791345100; cv=none; d=google.com; s=arc-20260327; b=U8aauBEZd5TOkOY4WlT9J/4e9NUiBU+9y8ro5ZHhZ9mnPvE9PQ2TVX0+2seFiC77mo EG51CT8TUr/3NLhJ1bCRzUmQb/oG6ObkoaVE1lYyXfFsl34Eqve/VlwZv5PmsTBlkGSF SCVE1wD5pD8iWI+rXu+qioEuImyt0SnSdVSBK3zQTxBg3LHCuySCxzklMKecgoJtjrw7 0zKzU1HUdpSBXWBPyt2fCTOhGZgueVi4muRuUeMqnk16zd3B0GLlgIfDV/bqHDYeFaXE XUIbMiizufpii7IaGcVudpo+RoK0O/JvQPmFqfCbMj4mgN/lZQqFe2ti4hwZjEOXIsdB 4UYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=XGC8IzSHsoUfN4rL4lKDuvnYFM4fhlvmydtIamM4Ia0=; fh=Lv87XhJ8YGbMKTkzQ142FTqNF+Su04GRBuZ9jOAt1iA=; b=LMKqxOvBL8m4aKKySQmpUphuUgukFuZZlgpJvEfOkwaSj3QAzRPH08h3PACer/R0lw i/Y4M7sN8L81L9t4mTB7zFICnwHeubwPpSCPN9QrvqyHzpeNZCsky86IPY31RiVB7IKT mADnTTQGKzDBSOipvcw994GJFxXgQZI8riXmETi2qYHYVRMG+vidw60mvEO5DFx4FXnH aYdLwSIdiMeWavZcxeZrI8n3Nvf70Kt5+msTJZnKxmWs5egBChq+VWGlZ/0UZXAqA0lH 0JU8LB7kqh0Nvj3gHhGssy34fS3tRY5J+v8Wr8VPRSPwjAIQqigio7G/ixOrVM78L558 /BvA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791345100; x=1791949900; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XGC8IzSHsoUfN4rL4lKDuvnYFM4fhlvmydtIamM4Ia0=; b=Uh06bxdGnn7uu/HN8kaQtKnAVN02rKYeOJerUcY0dodS6LMBowVbSxMjNewXM8SFrP e0Toz/e+3AtmOAkCs/EhDmQ5I4QnRWukPALuOCR6uNdmq2yZUtRw8qsUzxANdtJx7ymG EGxhW4vXrQOyBWGYbVkDmlLaZCtWgY0yMbxJ6NVC2oFx0KNuBBmJJayQCNQ5AvkeCLVV Vujj3r/QBAj6h2pGHddpk/LRL3DBmblM9wdTR0rDuW9CkcJOxHOm1KNbLLlCBI0Y3lVk TFp3wXsMvT8p3ujTNSbTJLG3MmpsQU2jHrXQsm5m4DZrO/+JybF0upUiDXoqAICDfClM FoQQ== X-Forwarded-Encrypted: i=1; AKwUvBwSCR9FkNMEi3NlQxbBbCBPQy9gtGEub6A8KqOUb/wj4MqPgvoiBdBSV9SpOJ2jcWu22CwJMwaY0lmCpyLeRrksNZJH@freebsd.org X-Gm-Message-State: AFq9FYJb4YGvAF5Y0EZHMPhbIRsUYeIqtMZAavu7x/NUSMbbwObzMdBi sJaF0Wo77kfNoSQP/av3rwleo6JgjAk57fXafzhNbjidNVjL3OH/8k4YguJllh2HyVrhzKNUSij uQjrA7wVuLg2vRGN5ZN6mn3BTfqu4RBkTdIjrYu4vSgdVCOX8sanSA4E= X-Gm-Gg: AYBFou2TonACHAoikr0AA1gVJXis69VQKBLXUpqtz7tHe42Oc5nMa3Ze9K43GIo7jtG wMVZkfzCyKSPDU6nhOiqO812gEOhj8ZJVPAFWv3hkQtFwevc9pDcVCb1xsLcdJoypwoKBrqt3FQ UH9BV5ZuBjFek6vob3eqcHUBxPkhjEwbLPlQSpfQLvqOG3LZYA2ARHdXNdjmNDDISu85fff5Px7 aciGepPOf0tnP57TvXUV7ZRt7ZcyiOASsgytOgczZy4iidtYnBqjAX/gJwm9zPHHaBjOmOnZEBS vii7Ujty7pUuGROb4jUDtrfybT2KRgPYTn7Ne75gT8hA8DwFFmMIKQ== X-Received: by 2002:a17:90b:1344:b0:3a8:7bbc:3f3e with SMTP id 98e67ed59e1d1-3a8a1b0071cmr977730a91.41.1791345099732; Tue, 06 Oct 2026 20:51:39 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6abecfdf.3a8dc.610fc5a7@gitrepo.freebsd.org> <86jynwnvls.fsf@ltc.des.dev> <86cxtmojly.fsf@ltc.des.dev> In-Reply-To: <86cxtmojly.fsf@ltc.des.dev> From: Maxim Sobolev Date: Tue, 6 Oct 2026 20:51:27 -0700 X-Gm-Features: AclHuK-Jb3Z82y6EomBD5vwHeV9n_cs73DOPyvycHMORv0R9aVdTUOv8LQPfH3I Message-ID: Subject: Re: git: 43b0384bc7e8 - main - mountpoint(1): new utility, implemented as a stat(1) hardlink To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000570d10065d380890" X-Spamd-Bar: - X-Spamd-Result: default: False [-1.00 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; FORGED_SENDER(0.30)[sobomax@freebsd.org,sobomax@sippysoft.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.216.54:from]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_COUNT_ONE(0.00)[1]; FREEFALL_USER(0.00)[sobomax]; RCVD_IN_DNSWL_NONE(0.00)[209.85.216.54:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[sobomax@freebsd.org,sobomax@sippysoft.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4hzzhF1Zh5z4ktx --000000000000570d10065d380890 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This has been suggested by reviewer @kib citing similarity to readlink. Original implementation was a standalone. I frankly don't care one way or the other, but arguably you could have raised this earlier while it's still at review stage. If that's important to you I suggest you do the conversion now. -Max On Tue, Oct 6, 2026, 9:54=E2=80=AFa.m. Dag-Erling Sm=C3=B8rgrav wrote: > Dag-Erling Sm=C3=B8rgrav writes: > > Maxim Sobolev writes: > > > mountpoint(1): new utility, implemented as a stat(1) hardlink > > Why was this implemented as a stat(1) hardlink? There is aboslutely no > > common code between the two. > > I'm serious, Maxim. Implementing mountpoint(1) as an alternate move of > stat(1) adds more complexity than it saves. Please revert and re-commit > as an independent binary. > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org > > --000000000000570d10065d380890 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This has been suggested by reviewer @kib citing simi= larity to readlink. Original implementation was a standalone. I frankly don= 't care one way or=C2=A0the other, but arguably you could have raised t= his earlier while it's still at review stage. If that's important t= o you I suggest you do the conversion now.

-Max

On Tue, Oct 6, 2026, 9:5= 4=E2=80=AFa.m. Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> wrote:
= Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> writes:
> Maxim Sobolev <sobomax@FreeBSD.org> writes:
> >=C2=A0 =C2=A0 =C2=A0mountpoint(1): new utility, implemented as a s= tat(1) hardlink
> Why was this implemented as a stat(1) hardlink?=C2=A0 There is aboslut= ely no
> common code between the two.

I'm serious, Maxim.=C2=A0 Implementing mountpoint(1) as an alternate mo= ve of
stat(1) adds more complexity than it saves.=C2=A0 Please revert and re-comm= it
as an independent binary.

DES
--
Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org

--000000000000570d10065d380890--