From nobody Tue Oct 06 17:39:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzk5t2dqCz4nGqM for ; Tue, 06 Oct 2026 17:39:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzk5t1SzGz3HcL for ; Tue, 06 Oct 2026 17:39:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791308370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SSDnYyf5JhrZeQXatn7nIv0Gjg+DkeQhiDulra2iCTs=; b=wAz/VS3f/KX1UhXwoCcvS2rwXlIUGcmexJsrOx4q5hAm5vWY7hDq+4EZVm+s61MM7Ibd76 fVZXPNly2lA0Jkg84J2w3oupBwevEhwcjw60K3CselQncTV9vQlHeTsaVFezMj2YEktFS4 HMSrGOt7zckLoFIf42k6ssxBEuXpQowzRjHty2AaayFnnmHUdst+ePhcJFLF4HmJ72A6kH hbmWxHiTD70s7mIixBOmOeF9mXXt10dw4skq002pX6D8wO3nCGyRrhzb9zCK+gDfRs9u6c 7olJrZM1/lVrSTF71NqMMUi8Q/N/7vk2ei98hVkv/9vKbfOxXD5YBbK5TG9TnQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791308370; b=x5YHhId3HEj7evfcrXkdeASGf4EfXRnx3Be/fjCdO8Pp5tbCdQ7RlUlGaQX7VUMdlFt5uk m5HWA0aQ4uQbIp83woCB1G6PrGtieC0cHO1EmpDwKxsMKqvoqsMtkAB/c5l+SStMb1/p9J sKP5cpu06f8B/q/SBrRKsvgtkuFS9L/1aJsl6rVXBbdm450DIZy3pvTC0v38of+gc/jMEH 6qPpoOV9YimUvgWFVYC9JQUEU485gJyGxT3EeSBQSnQJo1puMpaEaxkbnorfJHt3lHOcXb Ta0Mpf1w0731TJcMihRp8KJwCmzjZZUWJY00Jmiw2rhDhn2SBtBuRZjLTMvbHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791308370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SSDnYyf5JhrZeQXatn7nIv0Gjg+DkeQhiDulra2iCTs=; b=A8+73gOAhjC1VBg1usjFadMkcJBxD0a1UGNpgBJPp1HxtzDG/v5euS76IIr5DhP0YhpR2h DEOiQieszEhbh9jDOxhbeU3YvGy2xCNiXArMZLVPb1vN/Nrpey5hBxWqs872STbqSdeyvw DXqNcWYq1Qlqz0Vs3AVI+nxGcBtUNhXUI+62lO2UUPWBTedjMXxhRmasi4acVai8wVCRHE 9HMA+oE2NsoYPxY6eRgIs2ArQ9m2rmFxQvCrd/PjEOmCuN2s3LvpLuh511VQWh+69q1492 QWIXugQDCVTsw/uOd75PJMUhBPRw3QTg4hmxkVUMYW8684HNX1OEX6OHqzW7xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzk5t08T8zFbn for ; Tue, 06 Oct 2026 17:39:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37025 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 17:39:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Maxim Konovalov Subject: git: 2da109690be8 - stable/15 - dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: maxim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 2da109690be8f29f03b68150c827f47db81ad8b5 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 17:39:24 +0000 Message-Id: <6ac5324c.37025.72601dd1@gitrepo.freebsd.org> The branch stable/15 has been updated by maxim: URL: https://cgit.FreeBSD.org/src/commit/?id=2da109690be8f29f03b68150c827f47db81ad8b5 commit 2da109690be8f29f03b68150c827f47db81ad8b5 Author: Maxim Konovalov AuthorDate: 2026-09-21 23:32:09 +0000 Commit: Maxim Konovalov CommitDate: 2026-10-06 17:36:21 +0000 dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array Otherwise, the following would segfault dnctl pipe 1 config bw 1Mbit/s profile 1025points.txt Found with: Claude Code Sonnet 5 MFC after: 2 weeks (cherry picked from commit 04fcf30961266cd77139b40774cb0d6ef6eb2be5) --- sbin/ipfw/dummynet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sbin/ipfw/dummynet.c b/sbin/ipfw/dummynet.c index a0cefcffd183..3cf9a1854365 100644 --- a/sbin/ipfw/dummynet.c +++ b/sbin/ipfw/dummynet.c @@ -959,6 +959,9 @@ load_extra_delays(const char *filename, struct dn_profile *p, } else if (do_points) { if (!is_valid_number(name) || !is_valid_number(arg)) errx(ED_EFMT("invalid point found")); + if (points_no >= ED_MAX_SAMPLES_NO) + errx(ED_EFMT("too many samples, maximum is %d"), + ED_MAX_SAMPLES_NO); if (delay_first) { points[points_no].delay = atof(name); points[points_no].prob = atof(arg);