From nobody Tue Oct 06 07:51:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzT3C4KFjz6cWBk for ; Tue, 06 Oct 2026 07:51:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzT3C1mSGz4H2Q for ; Tue, 06 Oct 2026 07:51:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nHYobN4HXRYLUuulvGW7a3iBEkss/9shpnQ0vkV/tiA=; b=B1WJloqTB6rwKUecyGJt8rTWyJ2Fq9cXYdxxLc4kHZNoLJYLZQXpcx50fGXu1c+5posQk5 +DuhQu3CMA3Z2CXOVEwmORIYHwGYM0HBVdEvw23tf8e9x/G4MRjRJYMZdh/XvRnIvDz13F /mmsrWplOMOZOn2nfBypA8Q241ymWaLcN51orLzbo14zX7bsMRL/T0VYeE9ww4aqHxiXeY 503TOqWI4d4mCuvN5ES/lzDEpWZAdr8O//KTgh1zkvla7O22aW1LLfuqmu1BYTV+uXVNqu DyJmhtsP8Z3AISHjo+RL7a9I4VRiiRSBGCFm/peyAG+8M/KW2h0f1rTglnQWig== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791273079; b=PGGW8A/bjOS1qvv8lwxfYNzG7AY5sIJHRBiiZE+9Dk/c2d3hsQaxmr0q9OMwc/XQPk8U4w bgsppCOVtEv3117nGkUQPVi3EN61GJG3Xj4DL81OEvMYVvM8GsYbHD3LIjzyPq2STle7vg n97cjiVGiZaYJwIfult35t24gMqCWL9XFjb4V0nqF7o6KnZwBDPtXr811TidPtp55x5fWj lzQT2vDr7dQ8dR7/8RozY7eOJMuefzu6iQbgymbajdVJ70+ju8gXDG+l98Q+/y/6ULaz8Q vXbwyT21v6Y6qW2HjiRZ8diK5wTeig1nOtPZn5zF1FSD4dFU8XmBMnMqCSRvEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nHYobN4HXRYLUuulvGW7a3iBEkss/9shpnQ0vkV/tiA=; b=aj5k+57SFfSeKNn0GNp98eWqWkEP+Jkqa2TzRh8KlWd3elXP36xieehRaGtQ6jaunoPeC/ E0p84iyUVtJmuqCSQUuChqrT/RK27+nNzzIG3DOrbgKr+OMhw9lCRT2l+eqptLoTJQxUHh SKiKnwgngyg33PC0eefxElBmRW0SbOB0+RwCC7LouJPmHE6QHhnFwMPFE8ne0HiD99qXJx a33FoU5lFvu6htDnjbmacIy7jr0fhc3mQgUrh4QuXzauba+cYNKXEKEbQksz1O/3yjW7vf GrHayb1jFLhd2ny2i7s1GS0E7VeSQaSVP/JwGJ6lKNg8+J+Q4GL6XMERM2g3OA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzT3C05yqzxt8 for ; Tue, 06 Oct 2026 07:51:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 475c4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 07:51:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jaeyoon Choi Subject: git: 748239b973e2 - stable/15 - ufshci: free the taskqueue on detach List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 748239b973e2c24160b29742d7e90f0670a6d203 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 07:51:18 +0000 Message-Id: <6ac4a876.475c4.60722db5@gitrepo.freebsd.org> The branch stable/15 has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=748239b973e2c24160b29742d7e90f0670a6d203 commit 748239b973e2c24160b29742d7e90f0670a6d203 Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:52:37 +0000 Commit: Jaeyoon Choi CommitDate: 2026-10-06 06:28:01 +0000 ufshci: free the taskqueue on detach ufshci_ctrlr_destruct() never freed the taskqueue. Every load and unload cycle leaked the taskqueue and its kernel thread. A task that was still queued could also run after the module was gone. Free the taskqueue in destruct. Do it after the interrupt teardown so nothing enqueues new work. A reset task that is still queued at this point races the queue teardown. That race is older than this change. The planned in-flight recovery rework will close it. Sponsored by: Samsung Electronics Reviewed by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D58670 (cherry picked from commit 2d32961316248fdff54a2a9fc24ac8b712fee9b0) --- sys/dev/ufshci/ufshci_ctrlr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/dev/ufshci/ufshci_ctrlr.c b/sys/dev/ufshci/ufshci_ctrlr.c index 421aa1e28124..bb07ad5f76da 100644 --- a/sys/dev/ufshci/ufshci_ctrlr.c +++ b/sys/dev/ufshci/ufshci_ctrlr.c @@ -448,6 +448,15 @@ ufshci_ctrlr_destruct(struct ufshci_controller *ctrlr, device_t dev) bus_release_resource(ctrlr->dev, SYS_RES_IRQ, rman_get_rid(ctrlr->res), ctrlr->res); + /* + * The interrupt and the timers are gone, so nothing enqueues new + * tasks. Free the taskqueue before the SIM teardown below. + */ + if (ctrlr->taskqueue != NULL) { + taskqueue_free(ctrlr->taskqueue); + ctrlr->taskqueue = NULL; + } + ufshci_sim_release_wlun_periph(ctrlr); mtx_lock(&ctrlr->sc_mtx);