From nobody Tue Oct 06 07:51:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzT371WF9z6cW4H for ; Tue, 06 Oct 2026 07:51:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzT365zGnz4GcT for ; Tue, 06 Oct 2026 07:51:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yxJ9+mnUs+RJbSIteAUr1uSYTzdIIP1EAzLEex2Ag0o=; b=XZp8MrtK6o1oGMtgfzcyodSVFHrOx8XPAdn27OsWZmPSllRmLYHUOUZjm/1sSK4dpNVMp9 ZmCGCbqcvnl5PLSpp+c0P40etOqup0zC2HOxwu0vAGWFVRIvpJ2tQZy0Dkq+myyDeam3o4 t4S3vUJTeRBCfVeE2qAC/Wc58+0QXuiZB/dhKv7WBlxkB3TShzgO6nNFJ2rjHjkh0IomjK QGinlekpLC+AO9LIWcRG7WCk8nxoZg/qXzEkK+As2RF7M2wG6kYXq9HIpkNBcIA9WPTnsq Ss8nmuI3sIDAvyp2HpvHjlgD8PNxAMrSJu8F0R4mGRCRTEo50mqDLKkHr7l7nA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791273074; b=l1keJvHsrTlbyz9TyfwvXUa+iEmq79vDKW0sewcJld5QcUxWOO/fHUCTZmJw0GTbEJ2InJ rC/xdOwzugQs3Ka2gXgt29/RP7O8rwh9Hro6+NsAgv/Owyd1EKa9QGo0Cy7AJuB7VsGP4h Em9jv2MESYG3mrZZs/PyJK5iIx9UkV/VSlSpkbueHjvML+IicRT7rT0hfTkmVmpFU8+BVX Wiy6tOudeX9TB18o135OKYnVc1SbzM9F3LtkjpuJhL7XryZiGtfz9NsjKbBwGFHVCmq6M2 y0WFzeOGKEJnnqhd35jRvsdDUZJevSqGAJDQGXK8vKfO94u0oJRWhDTfQEd4sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yxJ9+mnUs+RJbSIteAUr1uSYTzdIIP1EAzLEex2Ag0o=; b=TYCV6FOSPzI/Wn7qJ+L5v/d4Un5QybKTt6DKB4Mw8OeKYW8LCz8CzAVtlUxwtNOsD1zP/K D4qYeqUYkkDEYKpwrH8ZvuiOE1jJkuU9dBO2DWhsmcqMwG/G8Nh7VJazLll+PTZ9kyuY3s 4dDPEMuKiJvb+mgnbsa/edQ4N1Yu5zlrKp7gPwTVcxEvpHLqXIPgc+nEqtU8xmAzn0+R0D 1ImgYCn7t1mRgypI+DPKnBpsahV7vIQIGmxszKGPYTVqvoLxgG2SLBPOlBFz7fAvkZ6eGo EeW6p4r4nUHAvERwBUvtq25d6d/QNhkg9agGroYNp6x9DeDJwMzbzo2DBgRA+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzT364LfHzxpC for ; Tue, 06 Oct 2026 07:51:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18631 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 07:51:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jaeyoon Choi Subject: git: b6e20a5ae8a1 - stable/15 - ufshci: initialize desc_size for non-descriptor query requests List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b6e20a5ae8a1782749495e4caa018e2e2cb26123 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 07:51:14 +0000 Message-Id: <6ac4a872.18631.6b1f4e14@gitrepo.freebsd.org> The branch stable/15 has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=b6e20a5ae8a1782749495e4caa018e2e2cb26123 commit b6e20a5ae8a1782749495e4caa018e2e2cb26123 Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:47:38 +0000 Commit: Jaeyoon Choi CommitDate: 2026-10-06 06:27:59 +0000 ufshci: initialize desc_size for non-descriptor query requests The flag and attribute query builders left param.desc_size uninitialized, so stack garbage was sent as the query UPIU length field. Devices generally ignore the length for these opcodes, which hid the bug. Zero it explicitly. Sponsored by: Samsung Electronics Reviewed by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D58665 (cherry picked from commit af00e00f23a1d427d96fecbb39e276fc2d7dfde1) --- sys/dev/ufshci/ufshci_dev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/ufshci/ufshci_dev.c b/sys/dev/ufshci/ufshci_dev.c index 454572f966d5..18546d7120c0 100644 --- a/sys/dev/ufshci/ufshci_dev.c +++ b/sys/dev/ufshci/ufshci_dev.c @@ -86,6 +86,7 @@ ufshci_dev_read_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -118,6 +119,7 @@ ufshci_dev_set_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -148,6 +150,7 @@ ufshci_dev_clear_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -179,6 +182,7 @@ ufshci_dev_read_attribute(struct ufshci_controller *ctrlr, param.index = index; param.selector = selector; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -212,6 +216,7 @@ ufshci_dev_write_attribute(struct ufshci_controller *ctrlr, param.index = index; param.selector = selector; param.value = value; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr,