From nobody Tue Oct 06 07:51:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzT2t5cFlz6cWMZ for ; Tue, 06 Oct 2026 07:51:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzT2t4K0vz4GNt for ; Tue, 06 Oct 2026 07:51:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DtP9xwf9UojCK7hMi/U2dI7cMCBQRg5H5azobLn3b2s=; b=hJiIwI1Op2WFQCjZTgALd+2qKB/jlQNRIW0kdzrpg2UKI3pDSIkCCWEr6W2pQYHlGSzNBp 63z9r8mk/sBrnViXbrtPRtpAlnk2Q3OSX2+8aL9sGziAmPODORq2Dpr12ncM2sXMhduXqK bbPxqa15aG2WF4PUBb7gOeLhubUMD4XbANK6mPvoFM7ABpvygsA4LVuzCPhL5N9Gy72RMG +u9e2HQIB77cLAdega6YvNWESEtfiIr+JT0LGWuLX/VdLWoLXOp82rg1Et9n65sPdUQX3Z 4Tk14+PiF4jQRXSsRXgYYaCbcN0ZuYH4BvhKFOdwu083KIljo/bvjh6bM8jC3w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791273062; b=LYQhTztzJ9Km4HCe/DtLH17HbqKPxbw763M2ypI6cU6H5qNgo02ckq8K3mif86D0aKWGwV 9XS4RZOXVS4QTkOLNAd7AxRKDbxgLa21cJ0tBWi5zeSclDJUGfI8WlrH4n8CTdKWJkmzH7 lF1gwQra4dkav3yMOxtNcOivqckJXT+EYQbDjtnq2pAjxBHkm0LjHpPr7EF5cmdYNIlO2o 8KmHSfIZzZi8Dm4Y78NIpcRTze7X/+FCEqBSozC4Kc2ht8YYLVdDsqMwGPADk9Uuuk+t/K 9yY1YgETBbJpbiRFatMWTNGASfHlYBsIlihNZytTAjpHyb439BWOXqg1y9lOBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DtP9xwf9UojCK7hMi/U2dI7cMCBQRg5H5azobLn3b2s=; b=G39QWG4+bw/K+Bnn7i9I2pR1JUePlYpXII0ExafM0zkpFW5TnEGtejfWVZCU4tgPvwjTOu BwQo/WS5LpRQms7dRPJtaTCtIt+tL+WQ2WfENvnmfCXvkCsVrs08cNMRYv2X2GfpvEVxR7 5a8MgYl7/mcbc8aRPQHNnRvdYqhrrXnqyEQTLe+585ZbpwhPJ9aQRqkXKpYpPpxluveWnd a8PmJj3g6Mvvfj26f76eJ4YHrYmev98kiQM7BtNTVr/ImSKuse2lGywjZmlZWJ7jAk3tox 55kd2GITJAZkMSBaN3rLX91+nOSjLoLKmoSVUWxzuYgla0AwmHK3fmmF1oYpiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzT2t35Nrzxp5 for ; Tue, 06 Oct 2026 07:51:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1882c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 07:51:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jaeyoon Choi Subject: git: d8ed29dcb9f3 - stable/15 - ufshci: fail attribute reads on a non-zero config result code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d8ed29dcb9f3fa7cc2a91c20f2f17e23664db663 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 07:51:02 +0000 Message-Id: <6ac4a866.1882c.67afe850@gitrepo.freebsd.org> The branch stable/15 has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=d8ed29dcb9f3fa7cc2a91c20f2f17e23664db663 commit d8ed29dcb9f3fa7cc2a91c20f2f17e23664db663 Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:33:00 +0000 Commit: Jaeyoon Choi CommitDate: 2026-10-06 06:27:54 +0000 ufshci: fail attribute reads on a non-zero config result code ufshci_uic_send_cmd() only logged the error code and returned success, so a failed DME_GET gave its caller a stale value as if it were valid. The gear and lane settings could then be programmed from that garbage. Return ENXIO for reads instead. Writes keep logging and continuing, because a device may reject an optional attribute and that must not fail bring-up. Sponsored by: Samsung Electronics Reviewed by imp (mentor) Differential Revision: https://reviews.freebsd.org/D58654 (cherry picked from commit 154e335cd635436c69ad98723e25988852bd11db) --- sys/dev/ufshci/ufshci_uic_cmd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/ufshci/ufshci_uic_cmd.c b/sys/dev/ufshci/ufshci_uic_cmd.c index c6e6afe3f688..03ea8b2ba9f1 100644 --- a/sys/dev/ufshci/ufshci_uic_cmd.c +++ b/sys/dev/ufshci/ufshci_uic_cmd.c @@ -199,6 +199,14 @@ ufshci_uic_send_cmd(struct ufshci_controller *ctrlr, "Failed to send UIC command (Opcode: 0x%x" ", config result code = 0x%x)\n", uic_cmd->opcode, config_result_code); + /* + * Reads fail here: there is no valid result to return. + * Writes only log the error, so that a rejected optional + * attribute does not fail bring-up. + */ + if (return_value != NULL) + return (ENXIO); + return (0); } if (return_value != NULL)