From nobody Tue Oct 06 07:51:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzT2s1fmfz6cVyM for ; Tue, 06 Oct 2026 07:51:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzT2r6S0Vz4GL5 for ; Tue, 06 Oct 2026 07:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gHtsUm6qNPGLEw9wN7nsxLG6xWkLEFsDFjzE5+343Zg=; b=OOSQlPmfK7LSs9C3di8f2Iax2oVWYzchDZssZFRrCciXq8CBLHuYWvsd3HSbdprNg8UXks J3lcmRAEJWFmkh30FbCuPTFuVjkxG72oSuE9/GshJLwCyeSHhFbgrxYN0xNhNLkJLgG68X u3gxJgEUPmbN0BoyPPa72zzBbqkFy95q3XYCG/LU/rP8B4V2fPwV9OJNVCssbQDWbvmXC7 T2Z+rk9EtBYab60S+HYqApIg8ryVSQEZOkhH5xthe73sRI6eQEhgcm4nra8DoL/FVeeSR6 zWwxxtspEDVdOCXd6RjFP04e3zqkQesWLIBSBv2MgR5TVFYXuWcMxoi/93TkWw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791273060; b=fpblkbS+XTegaZxRCAS9yH+gRId5XR6RAASpkRwXakK3vXZevrEEm5PpI7Y3OkN8q+YttV bUtvV1OjJ9f4Lf5ZusJs6qRvFXoCRaEDPquve9sko8t1E1KPc/+BcdR1APRZJ+pZ8ACxSF Jj+LFVlTxSHUvRSTPAnMqtmbVXxbu5BfhADdaWa90JFnfFF4nFqqZwGK1EhNhGDcobpoPj dpIn0jNWIu+agmzy7+OoJaQc4mUTa3kJ8ZjaL9U7Ot22nPploY0PyZXL58IIoI+hhHls1h Y6pFpG0/J5rYJeO7mksQZievTjtCnEb3OS6JKtf5jml8+U9891xuIDMpvjDb7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791273060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gHtsUm6qNPGLEw9wN7nsxLG6xWkLEFsDFjzE5+343Zg=; b=JMcWx5kneriRLNQbcwS16DMmZ22rDFdhf9bL/MV38hBRqaZfKMnfySpDsmxK/4p6DTt5TK W7CD7KyVM8BMHlw5xZ8rcog30B9PjYIrzrsNbuKXIidGdCURl1Cu4C8UiBQVmJlcvEHwyD KaHr9U9VqxuBgwbsOniPOMzAuwyEx08flaws0FhsgQwhzB4O0jPBbg0golNTtI9vDTnzwc hSgqOuyfqfQgR+zh9KGWsp5u/My4ugpiPRJz3bc+e/qRpbr6zz9X75QEPqOfqW/M0efe/M SKGalqmpfxsnwn2IThqSclgbqAClakRjaV5E6ftQX8+xjxRoirEGQwTFpI8ppg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzT2r1N7Jzx01 for ; Tue, 06 Oct 2026 07:51:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 185b8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 07:51:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jaeyoon Choi Subject: git: c9e2fd2eb3b9 - stable/15 - ufshci: fix data direction encoding for read commands List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c9e2fd2eb3b91cbef7295e556b22ab249b14686e Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 07:51:00 +0000 Message-Id: <6ac4a864.185b8.92cb44c@gitrepo.freebsd.org> The branch stable/15 has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=c9e2fd2eb3b91cbef7295e556b22ab249b14686e commit c9e2fd2eb3b91cbef7295e556b22ab249b14686e Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:30:11 +0000 Commit: Jaeyoon Choi CommitDate: 2026-10-06 06:27:53 +0000 ufshci: fix data direction encoding for read commands The data_direction field in the UTP Transfer Request Descriptor is only 2 bits wide ([26:25]). UFSHCI_DATA_DIRECTION_FROM_TGT_TO_SYS was defined as 0x10, which truncates to 0b00 (No data transfer) when stored into the 2-bit field, so every read command was described to the controller as having no data phase. Only writes (0b01) happened to be encoded correctly. Define all values as 2-bit binary literals, matching the existing RESERVED = 0b11 entry, so read is encoded as 0b10 as required by the specification. Sponsored by: Samsung Electronics Reviewed by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D58652 (cherry picked from commit cf04a05424f1a79e55303de252e5873abeae7b88) --- sys/dev/ufshci/ufshci.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/ufshci/ufshci.h b/sys/dev/ufshci/ufshci.h index 766d8de0535b..c2bef5c9a807 100644 --- a/sys/dev/ufshci/ufshci.h +++ b/sys/dev/ufshci/ufshci.h @@ -154,9 +154,9 @@ enum ufshci_command_type { }; enum ufshci_data_direction { - UFSHCI_DATA_DIRECTION_NO_DATA_TRANSFER = 0x00, - UFSHCI_DATA_DIRECTION_FROM_SYS_TO_TGT = 0x01, - UFSHCI_DATA_DIRECTION_FROM_TGT_TO_SYS = 0x10, + UFSHCI_DATA_DIRECTION_NO_DATA_TRANSFER = 0b00, + UFSHCI_DATA_DIRECTION_FROM_SYS_TO_TGT = 0b01, + UFSHCI_DATA_DIRECTION_FROM_TGT_TO_SYS = 0b10, UFSHCI_DATA_DIRECTION_RESERVED = 0b11, };