From nobody Mon Oct 05 15:19:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hz32Q6MbDz6k1nT for ; Mon, 05 Oct 2026 15:19:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hz32Q4rtnz3R5k for ; Mon, 05 Oct 2026 15:19:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791213550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FODi7qRtzInxvJgEQZ7A3u43/BXEMWiWQvbv/SK3VCA=; b=F/yiJl77oNWdxt9gk6izwtGs/+NfIHiSi5FxV35PxbyaEykzl4ym9CI/9xWe37faBUmaAZ rBgglsHbd43+X6uA34rUqVevWT/ka71JASomn04bHC8ZtI3w5rbndL0bgxSE+fJWcyUDqO AcC7KyzmqP/CDWnMkp7vlMnoqK1LYWNp/RLHeZ+SsEVppdR4qtNws1/kPolEgmc8MkvDhZ BHKCKwH3X6F6f8QNujNlxrwnyIQhZev//EtWg95qP7a9tAp5YwzB9H5i3qf8rY27kjyhMa 58Cf3uY07E/hx/oWJxFCGAybil00/CSbim67YeCwkcbU6mlsp86OnT6AM061aA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791213550; b=HXGBExoO/SnsoBfs0ShpLZbm3x1pc5gtC17lscBdfYkJuZC9MWIW/AASIaJGMoxuDKVfUY sLkUZnRs+oFoCuZe5iBlrY2UBx0ZeAUV5TsQ6l83FO49Bz17Dk6TydtzYrtWXWG+gv/wYp mcAHD3tHw4OtSebaOujzRAcvY5otrw9dBTyYYhoce/38SJOWP8I1/OH9JXKWsZ3uzZgP37 ov6Rh2gdh39tEDeq2/z6ZKffhkRYnN4YV82diD9FMWrNEWdQFeQ04qswXORAlLCrce0XP6 yfnjwbzXHuzaNBmHxnpJhInicmd50kD1YQEFwsJGVZXTVJvij1+f0AlN8Llstw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791213550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FODi7qRtzInxvJgEQZ7A3u43/BXEMWiWQvbv/SK3VCA=; b=HZ1REsMWUVRak+XuY3zuvzSEqh92mTpBlmMsOncHcW2tEoC0lBGs8m9p4kfnTxmu5Susx4 vA4ZbehV1pPpbvd1e9c3lqflXW6t8BPWZShFm+QMizoDhCcoaHra1KQiTPwQyqzD6e1hYn AWNXFThi8PhnsydmKS5jBzILXpIY0YWdJg7lcVuiL4GVVc9XPrakckEfEen6fJWA0NYEXy wHWcr5Km/EqT4bx+MVAqTVsFIl17MLNJv/aO6vLdZiVPf5aLoF/UiaJjnQLAOlCr8y2Mk0 BvjYBCRFil2ShF0CIbAF9bvzTHMfUqUtvMQ95C1Zvyyl/Kic5hjccXbA1j0J5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hz32Q3gNxzPl8 for ; Mon, 05 Oct 2026 15:19:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ca4a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 05 Oct 2026 15:19:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 4a0ec469934a - main - iflib: Do not ring the transmit doorbell when nothing is pending List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4a0ec469934a5de60b9b540689703a698ac44105 Auto-Submitted: auto-generated Date: Mon, 05 Oct 2026 15:19:05 +0000 Message-Id: <6ac3bfe9.1ca4a.1d0623d2@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=4a0ec469934a5de60b9b540689703a698ac44105 commit 4a0ec469934a5de60b9b540689703a698ac44105 Author: R. Christian McDonald AuthorDate: 2026-10-05 15:17:13 +0000 Commit: R. Christian McDonald CommitDate: 2026-10-05 15:19:01 +0000 iflib: Do not ring the transmit doorbell when nothing is pending For a lightly used ring iflib_txd_db_check() may defer zero descriptors, so its "pending >= limit" test is true even when nothing has been queued since the last doorbell. iflib_txq_drain() calls it before, inside and after its loop, so a sender that drains its own packet wrote the tail register three times per packet, twice with the value the hardware already had. The log of 81be655266fa ("iflib: ensure that tx interrupts enabled and cleanups") calls skipping the doorbell when db_pending is zero "an obvious missing optimization"; the comparison against a limit of zero defeated it. vmx(4) and mgb(4) have dropped such repeated requests in the driver since 2019. Return early when nothing is pending. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60290 --- sys/net/iflib.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index c2e70d946bf6..834cc37cb6ab 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -3457,6 +3457,13 @@ iflib_txd_db_check(iflib_txq_t txq, int ring) if_ctx_t ctx = txq->ift_ctx; qidx_t dbval, max; + /* + * Nothing has been queued since the last doorbell. The threshold is + * zero for a lightly used ring, so the test below would not catch this. + */ + if (txq->ift_db_pending == 0) + return (false); + max = TXQ_MAX_DB_DEFERRED(txq, txq->ift_in_use); /* force || threshold exceeded || at the edge of the ring */