From nobody Mon Oct 05 14:44:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hz2GG6GD5z6jyP2; Mon, 05 Oct 2026 14:44:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hz2GG5hHVz3KkB; Mon, 05 Oct 2026 14:44:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791211462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ABjxIgOPlZAqo4VaUuRiMJ1EggrKNKMjjx6m4A9/8U4=; b=gdj38Rof2hehH+VbY57broFSmN+4GQXO2hcKwAU3DqpNcLIOx/ULRsOBrzCxzQwSx0CfaQ VSUy0OiOcq99OduzcTrs2H25tip9vttlWTfTqWxfSoinseyt+QZU4RqiDV5GJwx688ujl6 FoB4enrNJjAmOWzZdP+US4wkSf7EHJWceYf6tKghpJTEv3BKLBG9NgrsVACZfaALqONtOG GUPs96XdWeNzPs40Y+5xpLUUSNGaGTmB/wVpLH9a7vN03+khHIsZVJz92K2OwZ9xRkms3f ochEp//XfablfNQssnlke6134l836wMlr2QjL7RcP59YKRgmtQPHD2uoVd4oig== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791211462; b=wgvzfNi/XJvayi8K2gam5hdEe0+Z5A889ZRZkp8lC7bJi3LxjNXt6EZJTins/yD1IQMory SxizgwLcknfLdZsATkONnA0kiTJnb9Bhw94WlHUNcOiZ1oNMH1DQxOmFave95tUXvCCL89 wlIRcxLTU9S7SW6wG6IUQ38hVvQc6e9UST7PsAoACR3IvHN/WkGihejM4hJNQ24xCAP6iN s6Lve69cV0Y0tsyMuhR7EgVCDXL5xk/22etILeZQvslK1SlV2BG+4wqzvnj1KjJiWVX0il qIs3vNnLk1Bbgys9P2q3xd2r1A/+55Y5bEy87ZkprdqVU2qiyOp9NQVKqr5veQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791211462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ABjxIgOPlZAqo4VaUuRiMJ1EggrKNKMjjx6m4A9/8U4=; b=PfuET31NAozNw+FxiLokuGB+ef9DpcCx+DEiUUbVSjuww6fUzTpFsZCPB3mraE6agkJ7V6 OU92b4ndeZKr/UHcpZwlyi3FEUOLnMG2LCvfStllCA1jIY1ijYPt8L2S5qNX3m7BIt3JDu 78gB8H0ITXAuVh5TskPxH5xVi2IoOHi/ic14dmW5jRxrvklz6b3hrzxcTjlskuwCzQvMXq 4Z3Mgrse7HjzmAaUTMtxsjzOUaczBspszZOPLxOs3mb8LlS+Odocp2RbvgECHNhigMmexf vLRT87bt16HUvkm3zT/ozlh92uw3tygoLPZZWLaEKwEKqVfEEgjlSyfsKJ+dxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5cc:4402:82e0:5818:5068:f2b1:7f58] (unknown [IPv6:2601:5cc:4402:82e0:5818:5068:f2b1:7f58]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hz2GG38rCzZmK; Mon, 05 Oct 2026 14:44:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0d4a78d6-0d67-4fa6-aaa4-4dfc19858f72@FreeBSD.org> Date: Mon, 5 Oct 2026 10:44:21 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 32137c41065c - main - sound: Retire the version constants Content-Language: en-US To: Jason Harmening Cc: Christos Margiolis , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <6ab2bc22.412bd.10bb456f@gitrepo.freebsd.org> <2df20868-4983-4169-a94e-da6adf2fb3ea@FreeBSD.org> <6280fdf4-0254-4953-b948-b6bac7796f80@FreeBSD.org> <8ecda432-8a6f-46b3-b4f3-2a5761404b59@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/3/26 11:48, Jason Harmening wrote: > On Thu, Oct 1, 2026 at 4:08 PM John Baldwin wrote: > > > > >> Hmm, I guess the trick is what counts as gratuitous which is fairly >> subjective. The policy I've tried to follow when refactoring APIs used >> > > I don't think it's quite so subjective. If a breaking change doesn't have > a clear benefit (e.g., improved functionality/ease of debugging, reduced > maintenance burden, even renaming an offensively-named symbol), then > there's a clear cost but no clear benefit, therefore it's gratuitous. > Whether the breakage can be dealt with easily enough using #if[n]def isn't > really the point. The other possible factor to consider in your list of benefits is that removing old/deprecated "ways of doing things" for code hygiene purposes avoids future developers copying from the "old" way instead of the "new" way. For this particular change of removing these constants I do find it a bit borderline. If someone does actually refactor the macros at some point to largely remove the versions then I think that would be a more compelling reason to remove these particular macros. -- John Baldwin