From nobody Fri Oct 02 18:39:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxHdZ0nyDz6vrGQ; Fri, 02 Oct 2026 18:40:02 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxHdY5DwVz4CcP; Fri, 02 Oct 2026 18:40:01 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790966401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vl1R4RTpPLf26EprPk69yKX4OPB31yIWJMxbbkoSxuw=; b=ITOgN2WDYEplVIJOX6gBw5slE1PJtqz6AnKtDWlD7Or3iRYceGaFhXZcAl6gdowcZY508t m/DdNxgtSMByghWgW4qv3sykLnOhbNpSbWV9hwZDUpRIa2khOEgSd7jRN2falINSLVstPf Gc/+RmEzJ6a7PJTJ2XaqUOnRFEPcp34C92w/2/pTdFqwcLmMEkMBUaGB+pFhMR6TD6VbpG H5vZpJWdn0NmBnfMR1CltF5kcPJCKz8pPji8ZdPZh3eWJ9CknZ8lczk2OoycQewPOLwjXC WrRU7uSR8ifponky6i5pA8wjDK6bDznrinyqhBRGoX4A7PqJAQD7GYQcMhR1PA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790966401; b=kZ6BsvcronWX0YLCfbT7IzZfEDmghAWrIbasP6cLzU4wfp9D/qcAL3k7A1OgHAaTpTiE/O D8gCn0wajlwDvWhMU2fE9uCLTZcEYuQFvUoqGGX+mMaHlnaupx4oH9eH6X4xY3hxo1jGcl CLRO6r4MisbhVDO5l1urmmnRtKXRm2/eXYuQiAC3WgiuWVVYRbcKf2NC+UAPS8fKHApnRk UWl0dBGfaU43TqtI1QpGM+kfUgB9cSYSjKSau7qOTY0uRAQC8SAR0ZT7tcOGykvvCQJD4U q0LHjug9UO+FcihbDEB0A3mlkWZa8F+0D8EFOPDUo4Cdu9xRooNrcN0UJ6a9Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790966401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vl1R4RTpPLf26EprPk69yKX4OPB31yIWJMxbbkoSxuw=; b=eP4MBhFjHpEB9ZJWAuIP6IEMxbamn/JoRJo+pVqQ3b+EO5TNxUUtkRO7RhrM7VxPn2/eP2 K4QDizNFVWISbB9nYqgfbrUgWB8Lt9dXXeDm29qQ1Yz72TDRIc036QKK9q5y1/Da9mEbq0 37bUulWIBLxHt5l1CSBSfOdchH3ZtrDycGM33FlvSlbcfZi9zIRhvX/PlXZ7jiLiQCfRQj m2vDMrdraN1JChM6k/mfN+3Inx+guf1W1s8WdcWGLInK7DrYovheV1lz2WnsOHPAlkoK7i hkkCn3ngIgHl4+7yZjRi8Vc+UohcLHutVaYPso3bisU+ENdGtMVD+/Aas/RjVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hxHdX6y2gz14Dq; Fri, 02 Oct 2026 18:40:00 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 2 Oct 2026 11:39:57 -0700 From: Gleb Smirnoff To: "R. Christian McDonald" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 82ab4adec955 - main - pf: leave the epoch to purge unlinked rules Message-ID: References: <6abd9bcb.44eeb.9102c31@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6abd9bcb.44eeb.9102c31@gitrepo.freebsd.org> On Wed, Sep 30, 2026 at 11:31:23PM +0000, R. Christian McDonald wrote: R> The branch main has been updated by rcm: R> R> URL: https://cgit.FreeBSD.org/src/commit/?id=82ab4adec95578b196eaf431d6ca87dd209aca6b R> R> commit 82ab4adec95578b196eaf431d6ca87dd209aca6b R> Author: R. Christian McDonald R> AuthorDate: 2026-09-30 23:30:54 +0000 R> Commit: R. Christian McDonald R> CommitDate: 2026-09-30 23:30:54 +0000 R> R> pf: leave the epoch to purge unlinked rules R> R> pf_purge_thread() calls pf_purge_unlinked_rules() in the network R> epoch, where sleeping is not allowed, and it takes pf_config_lock, an R> sx lock. If a rule is being added at the time, the purge thread R> can sleep on the lock, which panics with INVARIANTS. I wonder what actually requires the pf_purge_thread() to be in the epoch? -- Gleb Smirnoff