From nobody Fri Oct 02 15:50:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsT5j3Lz6vc0D for ; Fri, 02 Oct 2026 15:50:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCsT2rXRz4hXY for ; Fri, 02 Oct 2026 15:50:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oxrm1e1f+78j8fNz3OfxLM2RxO6B0FI4xdsnkQAgXZc=; b=fU0NO0yyTZgxBxmVu+9agrms/5qqF6EUnqw9+506xxApOdS+Dli6upKMSBAvjIziO5V6bC zHe+lb9+Y9PI0f77XXzbfFaLunwwNvU0SRuAWgwqZG4K3BfQpqhxl5vATrrRsCoWmt9SIK LoGyoGTFuZPUPJppfmVJwm1xr+7JiEtgm/mu12pjjVAsK6EdS63fYpFnFl8kyBBOmNzezM HewmRz4y1Sg0DAVU+YaLaEV7Z32GP7d0jNjNwHk3vkJkiHcGtEQkZYGWEePBrL3Y+VirE5 dNgVGgkRaqtbroPuYSpIKTRnOlwNY5GBZkZo7U58LUt44IpUIdgXHhGq32xTiA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956205; b=PBILVKozacXe+ICDV67p6AnJeH4B+/PVyFwjB9F9vhiI41RTp/zNG7iklMh5nxFk+QUV8L AN/tSeQXZgGcNKebb7bVlMsrk3PFRuzSSBuueOmPZs2HqO7IMS49dlzTUPmbfJMd5sY4oj yQo+hjU+qMaB3ml484Ac8rFBU0+3ZFxtW0Vv/utq+G3hoUKgAoT5rOdbQrtp4SuBtf0jqp ziWuER20T4wygvvCqEOPKf5PNMK2XYvb+WrPIMIKbHbfIl0pARstN0h/cp/jrpvC/JjfZf H56EC/J4pT6O+5mvx2hHhrIIi1QRGOmywhRFSBmp7BmvrOd6yKzQCGfqGkFecQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Oxrm1e1f+78j8fNz3OfxLM2RxO6B0FI4xdsnkQAgXZc=; b=KkJTgONKaKwPKnny4efFhmgac3wFa/9IqFpl6Wxj0Y0r1BUcH45dMhNmmq7iidbef0ymiy ydEXyXoUIrzRpvfNrG2DPehekFt21xs+oNb1124QLd1CCt087yQWXBBQUBamRqNtKii323 T/Bj2x5HU8m9tz0js3oMhlOHbXSR968QfG/RV4oDqPXWS5kyQ4Kioyow66nIptQokF6ir8 y/+xUYuMyxjuqme8TUgSejfm9xjNGqaOSXes88fDf7FfATPKYWvBRWDKfgQUGinGyIsy71 tqFwCxg3dcU+5NssZ+8LwY9SMtph15T4UtsFSLukAMx3yemqzDUOAs0guWY+ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsT1r0kzNJ1 for ; Fri, 02 Oct 2026 15:50:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40b40 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:50:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: a7cedda69532 - stable/14 - sched_ule: fix invalid tdq_slice() and sched_slice_min List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a7cedda695323a4865a08df33fc4f2a80b2e4699 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:50:05 +0000 Message-Id: <6abfd2ad.40b40.3171b2fe@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=a7cedda695323a4865a08df33fc4f2a80b2e4699 commit a7cedda695323a4865a08df33fc4f2a80b2e4699 Author: Minsoo Choo AuthorDate: 2026-08-24 23:35:27 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:44:54 +0000 sched_ule: fix invalid tdq_slice() and sched_slice_min sched_slice_min should always to be greater than zero. When modifying sched_slice through sysctl, if the new value is less than SCHED_SLICE_MIN_DIVISOR, sched_slice_min is computed to zero. Add imax(1, ...) to prevent this. tdq_slice() should not return a value less than sched_slice_min since that will cause integer underflow of ts2->ts_slice in sched_ule_fork_thread. SCHED_SLICE_MIN_DIVISOR is currently set to 6 so when load is 5 and sched_slice is 4, the two if conditions in tdq_slice() will pass and the function will return zero. Thus use imax() so tdq_slice returns sched_slice_min at minimum. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59408 (cherry picked from commit 477d2ea79252054596c73fa5f485bd224c028fd9) --- sys/kern/sched_ule.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 0e0b424ae060..b0b351aa19a2 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -680,11 +680,9 @@ tdq_slice(struct tdq *tdq) * cannot be higher priority load in the system. */ load = tdq->tdq_sysload - 1; - if (load >= SCHED_SLICE_MIN_DIVISOR) - return (sched_slice_min); if (load <= 1) return (sched_slice); - return (sched_slice / load); + return (imax(sched_slice_min, sched_slice / load)); } /* @@ -3435,7 +3433,7 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); - sched_slice_min = sched_slice / SCHED_SLICE_MIN_DIVISOR; + sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / realstathz); return (0);