From nobody Fri Oct 02 15:49:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsM2X50z6vcFF for ; Fri, 02 Oct 2026 15:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCsM0c1Rz4hDc for ; Fri, 02 Oct 2026 15:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zRQosl6ChMHVzv15WlLgGyOCvs/fI+Z9UgXKf2VgncM=; b=LiF6EoQk6bg776ei3cRn59K3OrbYWASf33P22awizAg/LYjGNKEeRxnDFqD1wqcS4nFGgm 0OSeD0D0R1xiNXwDkiflB5IDSHSlIscTCKkNmRa1Mkr97qTtWjYWZ/xQlOCOjWiYKX2Sjv JEJo1BYlVol+7f7mqYrQleSXiX4ACGgNv29qgsXKuIeArpzO0SHT8bXLOcH7sx24+NdEfO h8khTuP8UIjGAl42FBBjnTvwD2ebwxV6KIYELTD0YVzaxKO7gi/5BWTN4rRGfAygM/VKtD RQUgKUsWU++76sWuMZm3baa26CfNi6QKPxCDYD6BYUb9g98wl4XAb1ahPO//vg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956199; b=bdI8iydGkta21CqrPG9pI1VdxZP9j3NYQDKVB8EiqrE51QiTDWmoQGY++w8A3+Q58U/xKb ooVJDB2pLAhV+zplgQ8sAgXTBLpQ7trJRPWcu2SdBw+M+3ma+w+EMm+qUd/8Aoix/BzMEY Q2BPsKA6O7+wO6h0YNYRtylz2TEMQr/gQ/M7XQQ3DMVMXklMw6MrE1JFtwlVcLA/xNV4sI a7HMrCSMlLYnzZDSUWOWayr57PPaISuaTRhEURHkbm6Q+uBW6l3IJoFERTha4At/DVaSao SEwrDMcQQCIQWynFxH5n1P5cBKzeniD/5FBj+4bPJKRhTWTAAdh+SB2dxL1uxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zRQosl6ChMHVzv15WlLgGyOCvs/fI+Z9UgXKf2VgncM=; b=Eh40x9wtCpByvo9iw0lTpneEq5yjk8ZmezYOUGwF2Ke/hVybwvuk4QC2gRIPOIyNV5WArL fa+ERZuCC5mQMUWEp+KS3pLehTETqFyUnOljRrX9R+wNjnB9sjukAskHD13p4TSN9p3MBh nL003imGHPpNoW15QiqecmU2bo+gnALZxRv5DWdwTpuRGQ0q0rwvBbQJeB/UhQZfGcU1Ay 07cUeRAGLm9rpOR3DWTnyxGcg5gRGW2W4fvfNfNL8uGbBuEHmK9aDzdESKo5D2pzAiYt+j ofk0xxqa8+fuwJORtcJ9LOelQUqHC0ThAEz/ugXMfUDMNLgmW1ljABWjacI8fg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsL6nsHzNhF for ; Fri, 02 Oct 2026 15:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40bfc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:49:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: c087ee05b525 - stable/14 - sched: fix kern.sched.{4bsd,ule}.slice List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c087ee05b525c7dfc0a2370e5770c89651d56588 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:49:58 +0000 Message-Id: <6abfd2a6.40bfc.13f6d735@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=c087ee05b525c7dfc0a2370e5770c89651d56588 commit c087ee05b525c7dfc0a2370e5770c89651d56588 Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:35 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:44:50 +0000 sched: fix kern.sched.{4bsd,ule}.slice Fix three problems with kern.sched.{4bsd,ule}.slice: * Guarantee minimum slice is 1. * Recalculate hogticks on sysctl write. * For ULE, recalculate sched_slice_min on sysctl write. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59401 (cherry picked from commit 179f5b2bfedccc762352f06057f4e389bfabb2ea) --- sys/kern/sched_4bsd.c | 21 ++++++++++++++++++++- sys/kern/sched_ule.c | 22 +++++++++++++++++++++- 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 9147b4418b8d..6c204d62b213 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -214,6 +214,23 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) return (0); } +static int +sysctl_kern_slice(SYSCTL_HANDLER_ARGS) +{ + int error, new_val; + + new_val = sched_slice; + error = sysctl_handle_int(oidp, &new_val, 0, req); + if (error != 0 || req->newptr == NULL) + return (error); + if (new_val <= 0) + return (EINVAL); + sched_slice = new_val; + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); + return (0); +} + SYSCTL_NODE(_kern, OID_AUTO, sched, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "Scheduler"); @@ -223,7 +240,9 @@ SYSCTL_PROC(_kern_sched, OID_AUTO, quantum, CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, sysctl_kern_quantum, "I", "Quantum for timeshare threads in microseconds"); -SYSCTL_INT(_kern_sched, OID_AUTO, slice, CTLFLAG_RW, &sched_slice, 0, +SYSCTL_PROC(_kern_sched, OID_AUTO, slice, + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, + sysctl_kern_slice, "I", "Quantum for timeshare threads in stathz ticks"); #ifdef SMP /* Enable forwarding of wakeups to all other cpus */ diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 44425fa97770..f5d01e85b0a5 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -3441,6 +3441,24 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) return (0); } +static int +sysctl_kern_slice(SYSCTL_HANDLER_ARGS) +{ + int error, new_val; + + new_val = sched_slice; + error = sysctl_handle_int(oidp, &new_val, 0, req); + if (error != 0 || req->newptr == NULL) + return (error); + if (new_val <= 0) + return (EINVAL); + sched_slice = new_val; + sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); + return (0); +} + SYSCTL_NODE(_kern, OID_AUTO, sched, CTLFLAG_RW | CTLFLAG_MPSAFE, 0, "Scheduler"); SYSCTL_STRING(_kern_sched, OID_AUTO, name, CTLFLAG_RD, "ULE", 0, @@ -3449,7 +3467,9 @@ SYSCTL_PROC(_kern_sched, OID_AUTO, quantum, CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, sysctl_kern_quantum, "I", "Quantum for timeshare threads in microseconds"); -SYSCTL_INT(_kern_sched, OID_AUTO, slice, CTLFLAG_RW, &sched_slice, 0, +SYSCTL_PROC(_kern_sched, OID_AUTO, slice, + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, + sysctl_kern_slice, "I", "Quantum for timeshare threads in stathz ticks"); SYSCTL_UINT(_kern_sched, OID_AUTO, interact, CTLFLAG_RWTUN, &sched_interact, 0, "Interactivity score threshold");