From nobody Fri Oct 02 15:49:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsF5MSbz6vbhC for ; Fri, 02 Oct 2026 15:49:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCsF4W2nz4h8M for ; Fri, 02 Oct 2026 15:49:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ycCXXXT0uwa1ptInQQ6tTnpkYtJ8qd3MVQbudXdI3D4=; b=DRNJgPsQWPrlQwrvw3lIyg5cnAsVfbXV6UUxgOQ3k+R32g4ceGpSz1BJ4NpBS7fDlp28tK Am3zJLsgLlqFAt4sahR2r5FAtgOAtC8vn33nR70YKDdJYfqNxTpAo604squP3oYaJQpufG 1Fdi+ZAtraZmlp6C9SedvRrFs2I439vDOiqzz0bx2wJv0ebOE3ptyKvpEevmEpBmHhqgHF OhLZ0EuPf2hiiGGckqg7ySwT3zGd5v/O+AqjmSrjstqzy4jUz+V4zlwOYRKUB6Jf9e0m55 XfbXH8LCVDHc0+AD1lwWS1vah2tFzxIsBrbLH8ieL7troFuRVl4rKFhtA7+8zw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956193; b=Qg65NVGhP+Ks0ddrWr0VZn3amW7KC56Dk7xtFkCqJe4lyj64+QrrccPhcvPVvu5dGMqBw7 HQJHWQ2opcDWmrmT8lUPKmRsYSne9Lki9G83VwPrZRzObcCB9H9lPrU4mlVLnXwE1wEdQp rt3Y3c8gu1TRvgrzTd8CjShyEXXHbnQkt5L/BwHa4a4b3UxVyquh5+FaMEvNq4Tr6q9ZeU BFV1WXd3DxsboufU/6LtvRWMRf+7NwRDnw2HcZhLWS2NqF1piHtQl52rGhX+GhfSGwXRFY lQdB0GTQZw54gCGYLuES5R/GqikOep5G+D41kOXQLEGrMOd2k/sF9cjD6QU0xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ycCXXXT0uwa1ptInQQ6tTnpkYtJ8qd3MVQbudXdI3D4=; b=LkjxVmpvbD5RMNNEMjvr3ysiPwMQ6nUnzgucuLpORbXwr38MvTQS8jq9eAtqeaROp0RjVG mYsYeAQD5hBAoO7wj4iKAghDE+/BxTsmDEdKMoBk+CDDEt1FpVPGPee0vuo68OLfOaGFvz /qglAVCvPkS5EOBdnX41Mb9yN29GhmhSIZ5M9jWeRYCz20g60mHEYw/wWftle+PvGVEV52 1+xeWWf2WwN4lrJUU51uAYVLFairNXTb+egEpvl9wwmFle7H5hJ7uI09BsdY4PA0sgi3o4 HxqwlbBu6wYrmu1+XlgrAbcypyQ4OFfjg1nBjnZnKUQVFs/XtuJSbfrsGPEyEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCsF3QHHzNHt for ; Fri, 02 Oct 2026 15:49:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e47e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:49:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: c0e358871703 - stable/14 - sched_4bsd: add static assertion for nice weight List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c0e3588717033041e7bce8f0bdfe3212afdc6ca1 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:49:53 +0000 Message-Id: <6abfd2a1.3e47e.7f3709ce@gitrepo.freebsd.org> The branch stable/14 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=c0e3588717033041e7bce8f0bdfe3212afdc6ca1 commit c0e3588717033041e7bce8f0bdfe3212afdc6ca1 Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:32 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:40:08 +0000 sched_4bsd: add static assertion for nice weight When NICE_WEIGHT * (PRIO_MAX - PRIO_MIN) exceeds the timeshare range, two CPU-bound threads with different nice values can have the same priority as their nice values are clamped to the timeshare range limit. Add static assertion on NICE_WEIGHT to ensure that there is always enough room for nice values in the both end of the timeshare priority range. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59396 (cherry picked from commit e90be6fdf08526624f407923d003b66efa23d304) --- sys/kern/sched_4bsd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 02157fdee7a8..bde47e511a63 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -79,6 +79,10 @@ dtrace_vtime_switch_func_t dtrace_vtime_switch_func; #define INVERSE_ESTCPU_WEIGHT 8 /* 1 / (priorities per estcpu level). */ #endif #define NICE_WEIGHT 1 /* Priorities per nice level. */ +_Static_assert(NICE_WEIGHT * (PRIO_MAX - PRIO_MIN) + <= PRI_MAX_TIMESHARE - PRI_MIN_TIMESHARE, + "Priority range accounting for nice values cannot exceed the including " + "timeshare span."); #define ESTCPULIM(e) \ min((e), INVERSE_ESTCPU_WEIGHT * \ (NICE_WEIGHT * (PRIO_MAX - PRIO_MIN) + \