From nobody Fri Oct 02 15:49:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCrP4Bp1z6vc1K; Fri, 02 Oct 2026 15:49:09 +0000 (UTC) (envelope-from mchoo@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCrP3jG7z4glx; Fri, 02 Oct 2026 15:49:09 +0000 (UTC) (envelope-from mchoo@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956149; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yxM55DDmr7YWhrF0Xq8QUBDWd3p8lxY58UIePQoyHKE=; b=NpEWfVGhmG070knmpa2tI13AfI+sx36AK9wr6Vihnsf/tMo9U5aPkcsvYm/DfbmEL++MUZ qObsBYjVXU8FNOGeiU12v4vrpsMcGCUSLd0fxtoJWtM+n+tOyaXhDyUeoPnNJmiKG+5EqS 4T4klrtk0TMAEBqK23IZ69TPrOPtipp9LvUTP+mBTsMF8joDNcAo5i/wrDN8gOKB0H6wTL BZng9c/IXlYnD5+iUea+fc6glgC2Vp6lUGATBoK4cmlmIX2KIjeEM7A+nThnmYQ5a2Z0jH BtsQ//68QEVYMOdaY2JU2xDeBJt8YhRIBbWZFu2udLkxpxjc2IWCb9HFwMb0gQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790956149; b=cDdT+5mDX/tvzYLdePHvTyXgFGel5TAoFpd6LLgeLDNHsQuRNUELgixBstFiu1CDv8sD0f xmgUd6T2by9TO1NAJh+OP758BJluEYbIMajwJgoZ5/lXxAVtdbx/zO55kWnUzUeIXVa/tb HzQVH1EHo7XIjShOdgee87H5+iN+pm0CkiPWaAfSTjuOvhdhwHCxRQ5xKqWqjBdUm6yTNo GEwC6N6Bzhh+WYclJh6dMH8UiqhdfOKiRXOr5Rw1uWexi7gpC5V/D0e6GqyZwfYOa79wLY oYCWDfV2UBR3n2ER8HWPgYwzYZ3E+Bo9kw1w6nWxGQ2leq7RDZKLxm9StcpHNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790956149; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yxM55DDmr7YWhrF0Xq8QUBDWd3p8lxY58UIePQoyHKE=; b=qMn1WKwvqNRjyWXZ4ObM/8FXokG7VrUrdt10eCLb6sCHuze2+orEsLzCFhjXHD4sqK3VXD mWSTA4eGdzWIMnnItXker5aK2kBTHvgNJ8LSep2+fpk6ynpb5tuhIH5Nwr+a2vdJ3s5Q2i K5s3p4xtP7tq4uax1J5IDzQgnBmsXjZSRxvEZMpC31ARczmL2ZxuzP72j7HsCwp2IlMQfN vbSXZzgKlh7n0d/lrTvlhXGI94GRSET88UPNsqnTJfOJpjQb00Yp5wEotT1XRqE/5NF4Gd ix76vykX961jZjuShqaO9mBzA0OoFF1XphYFUapyg4PuLN/N+JKpr0IVSFHTOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2620:101:f000:7c0::a4dc] (unknown [IPv6:2620:101:f000:7c0::a4dc]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mchoo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hxCrP0KM3z11JR; Fri, 02 Oct 2026 15:49:08 +0000 (UTC) (envelope-from mchoo@FreeBSD.org) Message-ID: Date: Fri, 2 Oct 2026 11:49:08 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 962125aef24b - main - sched: rename sched_schedcpu() to sched_sysinit() From: Minsoo Choo To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Reply-To: Minsoo Choo References: <6aad4766.44a07.9ebf8e2@gitrepo.freebsd.org> Content-Language: en-US In-Reply-To: <6aad4766.44a07.9ebf8e2@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-09-18 10:15, Minsoo Choo wrote: > The branch main has been updated by mchoo: > > URL: https://cgit.FreeBSD.org/src/commit/?id=962125aef24b55b4bb8808dcab335abc4b3f0d4e > > commit 962125aef24b55b4bb8808dcab335abc4b3f0d4e > Author: Minsoo Choo > AuthorDate: 2026-09-05 01:02:07 +0000 > Commit: Minsoo Choo > CommitDate: 2026-09-18 14:14:15 +0000 > > sched: rename sched_schedcpu() to sched_sysinit() > > sched_schedcpu() is called only during SYSINIT to start kthread that > calls schedcpu() every second in 4BSD, but its name implies it's doing > what 4BSD's schedcpu() does. Rename this function to sched_sysinit() to > mark that schedulers can use it for its own SYSINIT routine. Note that > their SYSINIT routine does not necessarily need to be similar to 4BSD's > decay in schedcpu(). > > The scheduler.9 man page is planned to be rewritten from scratch, so no > change to it for now. > > Reviewed by: olce > Approved by: olce (mentor) > MFC after: 2 weeks > Sponsored by: FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D59437 > --- > sys/kern/sched_4bsd.c | 4 ++-- > sys/kern/sched_shim.c | 6 +++--- > sys/kern/sched_ule.c | 4 ++-- > sys/sys/sched.h | 3 ++- > 4 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > index 61b8c0e68691..5f0246323dea 100644 > --- a/sys/kern/sched_4bsd.c > +++ b/sys/kern/sched_4bsd.c > @@ -161,7 +161,7 @@ static struct kproc_desc sched_kp = { > }; > > static void > -sched_4bsd_schedcpu(void) > +sched_4bsd_sysinit(void) > { > kproc_start(&sched_kp); > } > @@ -1889,7 +1889,7 @@ struct sched_instance sched_4bsd_instance = { > SLOT(init_ap), > SLOT(setup), > SLOT(initticks), > - SLOT(schedcpu), > + SLOT(sysinit), > #undef SLOT > }; > DECLARE_SCHEDULER(fourbsd_sched_selector, "4BSD", &sched_4bsd_instance); > diff --git a/sys/kern/sched_shim.c b/sys/kern/sched_shim.c > index 2ff97a5774e1..9935c4e40aa8 100644 > --- a/sys/kern/sched_shim.c > +++ b/sys/kern/sched_shim.c > @@ -181,11 +181,11 @@ SYSINIT(sched_initticks, SI_SUB_CLOCKS, SI_ORDER_THIRD, sched_initticks, > NULL); > > static void > -sched_schedcpu(void) > +sched_sysinit(void) > { > - active_sched->schedcpu(); > + active_sched->sysinit(); > } > -SYSINIT(schedcpu, SI_SUB_LAST, SI_ORDER_FIRST, sched_schedcpu, NULL); > +SYSINIT(sched_sysinit, SI_SUB_LAST, SI_ORDER_FIRST, sched_sysinit, NULL); > > SYSCTL_NODE(_kern, OID_AUTO, sched, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, > "Scheduler"); > diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c > index ca55e5c1da7b..ea5f63311387 100644 > --- a/sys/kern/sched_ule.c > +++ b/sys/kern/sched_ule.c > @@ -3347,7 +3347,7 @@ sched_ule_clear_tdname(struct thread *td) > } > > static void > -sched_ule_schedcpu(void) > +sched_ule_sysinit(void) > { > } > > @@ -3465,7 +3465,7 @@ struct sched_instance sched_ule_instance = { > SLOT(init_ap), > SLOT(setup), > SLOT(initticks), > - SLOT(schedcpu), > + SLOT(sysinit), > #undef SLOT > }; > DECLARE_SCHEDULER(ule_sched_selector, "ULE", &sched_ule_instance); > diff --git a/sys/sys/sched.h b/sys/sys/sched.h > index 9d8268d43d63..e4cf848cf641 100644 > --- a/sys/sys/sched.h > +++ b/sys/sys/sched.h > @@ -323,7 +323,8 @@ struct sched_instance { > void (*init_ap)(void); > void (*setup)(void); > void (*initticks)(void); > - void (*schedcpu)(void); > + /* Scheduler init, to be called only from 'sched_shim.c'. */ > + void (*sysinit)(void); > }; > > extern const struct sched_instance *active_sched; The MFC only applies to the stable/15 branch. I forgot to add MFC to: stable/15 in the commit message. -- Minsoo Choo