From nobody Fri Oct 02 15:35:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCXM0MVzz6vb6f for ; Fri, 02 Oct 2026 15:35:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCXL2YpTz4Z2C for ; Fri, 02 Oct 2026 15:35:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YN/90ivCGUGbNR814QzVw3wswgtAwN7AHQLCHfBYTP0=; b=JS4b53drItkK7b3EVCzywuQxKQpyWzILtVB/XM3n/k0YUrfQu022vTykWCGmLhf0qfYWWX oTAhDc20MwsuaXTDs71JCtieIQMHP01JWjFgAwNKN0QM2zJ0n9ef+dCaXcMqQ+yHLptx9V /oNfbB8HTOWxz8x0cYL5QK84ymogT59/Ad/VzLF5YqZxFQGlGxhb8tOBKQjonumiWLsTzR 0IaCXMMJG5ra3OfG92Bzyl/PWjUf1R1Fj2Y3IoKPyWKfItXA70yjRk50vosH3oMAnCz6TZ JcRtL4ltoHDPtG0DpD/g6Bw8cDUAhr/KZAu3W5LyV+BLo6drU19Rlta6UL00UA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790955314; b=ClbifLLa6YdVV8RANgCwegz4PxoSRgO6mLcfP35i5FpW035rsRmEpd6uYrHafoz949iQp4 B1TerhkkwybdnXnYIGpvyd79ltPaxj/RUhX0PjdTy/anjnem/jn/Wq1NuHB4J6We52dVSm gw4kYF2KVPpnitMwAgF/8KINkbwIx0c1l07fWFD/RqO0lqGU+oAO9oqyt3qZpAiIGHUj5w m0bnSzBlf/dlQYPc9SNV9M3OJ/u/FNLJIH0H+899IeVSaI8L7dldSsJpdSdc+881L7P1lr nLyZBAmkGPSy6FTbpfLR1vLRlZ6W/cKs0gtB6uDG14uWyVDP1R/syKNCLzm/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YN/90ivCGUGbNR814QzVw3wswgtAwN7AHQLCHfBYTP0=; b=DJNcK4g0zwWorLNQRp2n2kkD37hJTiq8JrjGkPoP8fJVO0WX+3n1IbQx3EdrhyFopqctXS 5eX/EV95gn0dvEloyAKgdPawkag4fmwu6wquzd2l0R7fwHgkI5D0/nDqbuO7mLDdS7Z5ST cZBcVExIHr4O2o0ZwryJ7JKCK9EKMneXYNK1Y9yv6uLo30hfhgOaR9RMZHF2OtDoYloHzj qGVEb6HHqffwaBFsa5vRRnD4rNq5WdOz+3n4iSeIIixJ22GDCu/tzQyvgbA3VllP2awGFH 7WyZ48unNMjp4yRqHxMgVpEIcJ436XKffwjMS47d7/A1V7bJa1fLD+0arwKIoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCXL1cwPzNm1 for ; Fri, 02 Oct 2026 15:35:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fc08 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:35:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: b406f4ad382d - stable/15 - sched: factor out hogticks calculation into sched_update_hogticks() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b406f4ad382d213352caf469572c20fd6c899da7 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:35:14 +0000 Message-Id: <6abfcf32.3fc08.3101f83f@gitrepo.freebsd.org> The branch stable/15 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=b406f4ad382d213352caf469572c20fd6c899da7 commit b406f4ad382d213352caf469572c20fd6c899da7 Author: Minsoo Choo AuthorDate: 2026-09-06 22:49:02 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:34:32 +0000 sched: factor out hogticks calculation into sched_update_hogticks() Suggested by: olce Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59471 (cherry picked from commit 5a879394ba2eac14f65b466a46dae39326df00db) --- sys/kern/sched_4bsd.c | 16 ++++++++++------ sys/kern/sched_ule.c | 17 +++++++++++------ 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index cd039501b609..61b8c0e68691 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -133,6 +133,13 @@ static int realstathz = 127; /* stathz is sometimes 0 and run off of hz. */ static int sched_tdcnt; /* Total runnable threads in the system. */ static int sched_slice = 12; /* Thread run time before rescheduling. */ +static inline void +sched_update_hogticks(void) +{ + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); +} + static void setup_runqs(void); static void schedcpu(void); static void schedcpu_thread(void); @@ -206,8 +213,7 @@ sysctl_kern_4bsd_quantum(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -223,8 +229,7 @@ sysctl_kern_slice(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = new_val; - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -660,8 +665,7 @@ sched_4bsd_initticks(void) realstathz = stathz ? stathz : hz; sched_slice = realstathz / 10; /* ~100ms */ - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); } /* External interfaces start here */ diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 660e7ecdfd42..ad52d749593f 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -232,6 +232,14 @@ static int __read_mostly tickincr = 8 << SCHED_TICK_SHIFT; static int __read_mostly realstathz = 127; /* reset during boot. */ static int __read_mostly sched_slice = 10; /* reset during boot. */ static int __read_mostly sched_slice_min = 1; /* reset during boot. */ + +static inline void +sched_update_hogticks(void) +{ + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); +} + #ifdef PREEMPTION #ifdef FULL_PREEMPTION static int __read_mostly preempt_thresh = PRI_MAX_IDLE + 1; @@ -1659,8 +1667,7 @@ sched_ule_initticks(void) realstathz = stathz ? stathz : hz; sched_slice = realstathz / SCHED_SLICE_DEFAULT_DIVISOR; sched_slice_min = sched_slice / SCHED_SLICE_MIN_DIVISOR; - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); /* * tickincr is shifted out by 10 to avoid rounding errors due to @@ -3477,8 +3484,7 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); } @@ -3495,8 +3501,7 @@ sysctl_kern_slice(SYSCTL_HANDLER_ARGS) return (EINVAL); sched_slice = new_val; sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); - hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / - realstathz); + sched_update_hogticks(); return (0); }