From nobody Fri Oct 02 15:35:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCXG2Ld5z6vZl0 for ; Fri, 02 Oct 2026 15:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCXF6XfGz4ZF2 for ; Fri, 02 Oct 2026 15:35:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U0N+kAbJ9HQr+wsjhAHaEZ7FRUVeOV7pULnUpcPr6gs=; b=ld65FYkt+BTExCkxeg1XKzoXkyC1a214ChK2hByjwXVjaLN5wh3LtFqlihwDpqTmoYAn85 K6yQ1vLkJxybC/n9ZVN5AQZ1o0Mx1cSDSs9sYRkLmdWMLUTpI/csqxToLfCKI+/ggkwpZb D9FLCEobCTb8RlYF5/Yc3AeEW1ouiUV5U3GHRZirfsYgDcwyGZFDJh4ePpK0RUTmApeEbO 8nrm7Ukfqot3mGjaOKgVbIfJ0iLvohy8eB2129OZ5jaPIEurDQgwa+wCZVrgyvKpsWL1vB U2btoSf3o6JK5RrbYQfDe3hJKe5ayz+znj9m/VnMf/QlKYpEXKmIRH8XByekkw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790955309; b=OCsViMWAW5YeITN1Kw1WgvlM9i/cs/uI2sdCMGRSHhjhuFn+CFgBmh2OXDiryTRZ+7apJc Tn1pU/HPT7faB7umzYZUv3/jHiaT6GOPvLPanxN7zg53+Ho8U1hONYCJBMmyTUv2ddeV0j yiBr2DC1UYeqeTXUU+Me2iVcsVF/uNukpwkHUGQJEfIGiQoOdzCLbnPPZoU0tr1SQ5N1dN X+/fIOBktjkR+btBELZeO0JVAvVgXAIVTT+domIFR14KeZJm2WaAPdHRIOXhmK3bmBkhZt ucrRt41lNgTrfNwKWgW5LcZG9pu+wshw4DWSOUo+63+kvibZ7hH1WYSvdztK8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U0N+kAbJ9HQr+wsjhAHaEZ7FRUVeOV7pULnUpcPr6gs=; b=n/RZY66ZYRL+3NelaeQMLG5fB5LjYIQPAAQGJL9EaP53+QNyd9JKazvNf60Fz3JxF6lPSn i5pCvfDrt3DHmmTIMQEoUZqDE4aHNy2UrQw/Ft/c2DgUbD9n4Y6q1olsWwEFn23b14Ckrk o49MnY77boCBEV4UJqIJEgyABaPCfNRkn6odnR+Y1PxlTbqgPfJ/oujrCUj2bdG0x0Dp65 XVg6bLzGoZEVqe8MJl2WD+notBypPfh1aryW7ayxSEM5/vvEWxfoXiHhIhzKVoPoQdJdtv 76zcETG2WZGLs7RSmLq9/sNJyiIWCuYJ9O/CaZbIvyhtZbod3VhremvURtU8Rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCXF5bcXzNNG for ; Fri, 02 Oct 2026 15:35:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f39c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:35:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: b74d31398a24 - stable/15 - sched_4bsd: fix vague comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b74d31398a240c341cc52c41551d38ac5a541b20 Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:35:09 +0000 Message-Id: <6abfcf2d.3f39c.76421929@gitrepo.freebsd.org> The branch stable/15 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=b74d31398a240c341cc52c41551d38ac5a541b20 commit b74d31398a240c341cc52c41551d38ac5a541b20 Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:37 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:34:31 +0000 sched_4bsd: fix vague comment The comment "was incremented in schedcpu()" doesn't give enough background for decrementing ts_slptime by 1 (thus ignoring decay_cpu() for 1 ts_slptime). More accurately, ts_slptime is decremented by 1 because decay_cpu() has already executed once in schedcpu() when ts_slptime was 1. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59406 (cherry picked from commit cd33abbce5a5c3b454f00ca3d0ecd71c2234106c) --- sys/kern/sched_4bsd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 27fbd3c5bdca..cd039501b609 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -585,7 +585,8 @@ updatepri(struct thread *td) ts->ts_estcpu = 0; else { newcpu = ts->ts_estcpu; - ts->ts_slptime--; /* was incremented in schedcpu() */ + /* schedcpu() performs one decay_cpu() on its own. */ + ts->ts_slptime--; while (newcpu && --ts->ts_slptime) newcpu = decay_cpu(loadfac, newcpu); ts->ts_estcpu = newcpu;