From nobody Fri Oct 02 15:35:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxCX9637Bz6vZsq for ; Fri, 02 Oct 2026 15:35:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxCX94G05z4YsK for ; Fri, 02 Oct 2026 15:35:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EGFzyZJl931xA1B0KnQohV41yUWJ/z/vivNWmBpxYS0=; b=SMzNzyf25/aRpCSM832R4gUBYmx4PwgUjV1TmggWM5nGXsLSMxTqs5T0rKEDno0cZCH2DI 1b1S7ivrLg1tyZjmtHbXMmJ6HVSavJl/Do7QPgJI7xcIumFHW3Q7cuAx5mKf9J5OlVD0Cu IRjW0kRYO4g/s38tP50XL6uvaiDLdoiGmk2NcmyhlyMiuoBFjdS0h2UuWXDna8P/EBZU+2 hscnKH8AnUJewdoulO32ZssxxopPv/95prBuUafMpgdgDHLvAylR0B+qMLKtymW1tIqjXb 1uzHgMKF4d/VM3oKYyuecpyY3Roi7sppYtJZzgT0dTbuRPoEMzoCYDm9blj2jA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790955305; b=upAJUFE08E0IGtuU0N86G0MSznuN8uMS6DoRg/wQWqQ0HzA6pMZptGFj+NKdYLWIjbNgz1 qUVqV7L//v8AaObZxlh9fMif/d07YN6LWJjR6dphffIZQV27ZhO1zc/lQuqDNNWB0x+YV7 37PabftRXrSKk/ZmwHh+oyyDTXWPxffG/OY+wNxlT8iYXiWjc71KwwcwipV7NOHwEmIAJB vAU7veJZ0IFdRBKKTI0xw/3CY8XPg3dZCrHiQCNfZUKpyUQ9H3vAvRIs3hU+b2IJXZuRxb c9hvfFuXYQ/Ykehq55Iosv21pdUqMMRvtt637HtguJXwbnE4xoDhOvC4lxD64Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790955305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EGFzyZJl931xA1B0KnQohV41yUWJ/z/vivNWmBpxYS0=; b=aYxzxezy6oktOk1RPuhUBVXg2IHFQqnregSv++s4/Sn3EskyWxNPNAaoNKygzjDZzbP5zo dpNzUsq9jqLEjvfyJN0dCum8aSoBkL21IT7hMocXbVJm2S2NNRy3B49eba7THvqwcqbVIl AQswBrpCttaCvJXJj336QVeA1Gpw/qnL5oLwkk8rz+0NzAHko8iNZHsHJ+E3bco8CvFpI9 jSxFYkk3qPM3x7J2kk8APFPVsp89HS/sLQU8PvGZru3kyThaRAoQOtCjMr7CIeC0iiksZS +SUF2aFT8ErSoRwYYxTvd8Ud0c80ivolKrwExT76hH//iZf5YJ9a9D7Wf2BPLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxCX93Gs9zNLy for ; Fri, 02 Oct 2026 15:35:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ec45 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 15:35:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Minsoo Choo Subject: git: a97fea97e351 - stable/15 - sched: fix kern.sched.{4bsd,ule}.slice List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a97fea97e35122e4dafc2342b77767a1584468bb Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 15:35:05 +0000 Message-Id: <6abfcf29.3ec45.10a79f6d@gitrepo.freebsd.org> The branch stable/15 has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=a97fea97e35122e4dafc2342b77767a1584468bb commit a97fea97e35122e4dafc2342b77767a1584468bb Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:35 +0000 Commit: Minsoo Choo CommitDate: 2026-10-02 15:34:30 +0000 sched: fix kern.sched.{4bsd,ule}.slice Fix three problems with kern.sched.{4bsd,ule}.slice: * Guarantee minimum slice is 1. * Recalculate hogticks on sysctl write. * For ULE, recalculate sched_slice_min on sysctl write. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59401 (cherry picked from commit 179f5b2bfedccc762352f06057f4e389bfabb2ea) --- sys/kern/sched_4bsd.c | 21 ++++++++++++++++++++- sys/kern/sched_ule.c | 22 +++++++++++++++++++++- 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 7965357e072e..4db2364785f6 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -211,6 +211,23 @@ sysctl_kern_4bsd_quantum(SYSCTL_HANDLER_ARGS) return (0); } +static int +sysctl_kern_slice(SYSCTL_HANDLER_ARGS) +{ + int error, new_val; + + new_val = sched_slice; + error = sysctl_handle_int(oidp, &new_val, 0, req); + if (error != 0 || req->newptr == NULL) + return (error); + if (new_val <= 0) + return (EINVAL); + sched_slice = new_val; + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); + return (0); +} + SYSCTL_NODE(_kern_sched, OID_AUTO, 4bsd, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "4BSD Scheduler"); @@ -218,7 +235,9 @@ SYSCTL_PROC(_kern_sched_4bsd, OID_AUTO, quantum, CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, sysctl_kern_4bsd_quantum, "I", "Quantum for timeshare threads in microseconds"); -SYSCTL_INT(_kern_sched_4bsd, OID_AUTO, slice, CTLFLAG_RW, &sched_slice, 0, +SYSCTL_PROC(_kern_sched_4bsd, OID_AUTO, slice, + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, + sysctl_kern_slice, "I", "Quantum for timeshare threads in stathz ticks"); #ifdef SMP /* Enable forwarding of wakeups to all other cpus */ diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index cd8fd2208480..e4dde92e181f 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -3484,6 +3484,24 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) return (0); } +static int +sysctl_kern_slice(SYSCTL_HANDLER_ARGS) +{ + int error, new_val; + + new_val = sched_slice; + error = sysctl_handle_int(oidp, &new_val, 0, req); + if (error != 0 || req->newptr == NULL) + return (error); + if (new_val <= 0) + return (EINVAL); + sched_slice = new_val; + sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); + hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / + realstathz); + return (0); +} + SYSCTL_NODE(_kern_sched, OID_AUTO, ule, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "ULE Scheduler"); @@ -3491,7 +3509,9 @@ SYSCTL_PROC(_kern_sched_ule, OID_AUTO, quantum, CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, sysctl_kern_quantum, "I", "Quantum for timeshare threads in microseconds"); -SYSCTL_INT(_kern_sched_ule, OID_AUTO, slice, CTLFLAG_RW, &sched_slice, 0, +SYSCTL_PROC(_kern_sched_ule, OID_AUTO, slice, + CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, 0, + sysctl_kern_slice, "I", "Quantum for timeshare threads in stathz ticks"); SYSCTL_UINT(_kern_sched_ule, OID_AUTO, interact, CTLFLAG_RWTUN, &sched_interact, 0, "Interactivity score threshold");