From nobody Fri Oct 02 05:05:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hwxYM2Ggkz6vJ82 for ; Fri, 02 Oct 2026 05:05:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hwxYM1mC1z4JlX for ; Fri, 02 Oct 2026 05:05:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790917511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vBRRdmE0OfEF8BYBVc4nNQ8GG6te9WNM5NvkZSXZ1rU=; b=uhK3813B3XnSzw5MwAx3zfjI/QIoX9dVou0+69vaRPr/zYpw3RmGQH3MzId4N0WwPly4p+ WwrdNQOvsqqQp4OLMql8+HVXlHJX+2lBkDp8RQ3qDb1jV1YdxV4qYOZpzJZ1xCd3mZdxuG 7yLoMdR1nes/JqBSZ1KD0Dpvo49m7EeAu3XudNAO44mFj7hKpaReo8up5yx8H8HiEf3L4/ Ptr6R8Si9Bo7kdX/KaQaj17OsetUGOV2CfBJTOEhRyN6HcWOT2hDIRyPcYV8AGm+HbgBU3 2akgy5jqP6FdbCbuTp60R3HSJDBIBaD7nsizNJmwo8DvhZAs8etR7nkKG8SVXQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790917511; b=AAVKE+r7k5YuWVAvZHdUADRDyret+rWdeWyEH/BlkTL0L2UAqOUyLuK68wIX0uHt29XHy+ gu134+TgAVp5RQe1Xrh7O6bSRaO1gGbjGfy9LyzBr07pUx8TLeLZw4dJvVvbW3eiUr9mda 5WD/fk52RPV7DHGEfIcve7pL6YcQ7cyKaqDIGSl/G0X7nbhZD3aSam20Hc7R2/Wo6HyAsu ej+3Xt6AYxkZ/4tqWdgNc6nFfmSgWvqd1I1Wn79IbhToBYR6+LH4+AUq7WOpqX0tFmoecT kS1qMgaV7xamNm6lMLToDztg9ida9Ehpd8k9YFjYztj4ECIXRIa8ptma88NTvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790917511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vBRRdmE0OfEF8BYBVc4nNQ8GG6te9WNM5NvkZSXZ1rU=; b=C+wjqx2aSOWzmf3un/NGNJ5VSCw0x/LV9sn6h0ghePcZK962EHGR9AvSlv1Fu11qNA3XgA 6spnJAQogAkZHDTdo+FgAAspJNlNpoTXD8CLah+teZaQYoj0ow/rp9RdB7B4kxDLVH/XX6 qDhEv/YPP5VvfAYEvN/5u6eIsXa9umxgDzPB+jGDoCCatMy+R2ht45Yf8szCCJDZePuNSv aH7IWaaa0Nobm56e9CGKtg7mYA8PBdXTNdfu826UEIzbmySGk5XA51785QtKlroMc5bKxh k904//2FptAbvbezxbDtpw71+cCMgGXem8WbIrY5s9aaRlH1g/zcQG42gIb/+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hwxYM06mVz13VW for ; Fri, 02 Oct 2026 05:05:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19aef by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 05:05:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Yunheeee From: Xin LI Subject: git: 70f6696f0f90 - stable/15 - MFC: fsck_msdosfs: fix head bitmap over-allocation on 32-bit platforms List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 70f6696f0f90b0de9dba554faafc50ec3444443d Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 05:05:10 +0000 Message-Id: <6abf3b86.19aef.765e2beb@gitrepo.freebsd.org> The branch stable/15 has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=70f6696f0f90b0de9dba554faafc50ec3444443d commit 70f6696f0f90b0de9dba554faafc50ec3444443d Author: Yunheeee AuthorDate: 2026-09-26 03:10:04 +0000 Commit: Xin LI CommitDate: 2026-10-02 05:04:40 +0000 MFC: fsck_msdosfs: fix head bitmap over-allocation on 32-bit platforms bitmap_ctor() computed the allocation size as roundup2(bits, LONG_BIT) / (LONG_BIT / 8) The dividend is a count of bits, so converting it to bytes requires dividing by 8 (bits per byte), not by LONG_BIT / 8 (bytes per long). The two divisors happen to coincide on LP64, but on ILP32 platforms the head bitmap was allocated at twice the required size; for a FAT32 file system with close to 2^28 clusters, that is 64 MiB instead of 32 MiB. The extra half of the allocation was never accessed, so there is no functional change other than the reduced memory footprint. Pull Request: https://github.com/freebsd/freebsd-src/pull/2440 (cherry picked from commit 269002da453895fc935101afefeb02d2c7d10360) --- sbin/fsck_msdosfs/fat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/fsck_msdosfs/fat.c b/sbin/fsck_msdosfs/fat.c index 7d0ad9a595cf..ef788c9826a4 100644 --- a/sbin/fsck_msdosfs/fat.c +++ b/sbin/fsck_msdosfs/fat.c @@ -121,7 +121,7 @@ bitmap_count(long_bitmap_t *lbp) static int bitmap_ctor(long_bitmap_t *lbp, size_t bits, bool allone) { - size_t bitmap_size = roundup2(bits, LONG_BIT) / (LONG_BIT / 8); + size_t bitmap_size = roundup2(bits, LONG_BIT) / 8; free(lbp->map); lbp->map = calloc(1, bitmap_size);