From nobody Thu Oct 01 10:33:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hwStW3Mjgz6vRtt for ; Thu, 01 Oct 2026 10:33:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hwStW13ZBz4ttZ for ; Thu, 01 Oct 2026 10:33:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790850803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ldfKqulO6MxiBOe5N6ye2TSVwpQM61PE1zfx8c15GHo=; b=booJRf0eLc+OQg3SlSOkNsAEf+ak1UFAIEV2adZHt11byhK23PRccfeRctRSi/RrFT8EAk GyvpAnSXtf2YlFkvQCF0M0LCGYTGfc62xxYocV1jIg9BX7wjMgmeIaktB3FXmunfmSqVjJ kw7c536NWODGv89vFobiQ2VWGL1LCRTntg9ZvjRRbAFZA1rP4w2SxdQ/neZZ56vcc5uAbA d5O+xjKrEtIkw64xmXROBmrPY7s6AsNFhgBFDfOudkHYgNFRdHZMaZNark0/wjD5a4J95U JeYQVdXHT9ImSOo0LHRQFWZ1UymZcXo/hRZ82nXV10LedChHPWCIl3Cz1JTpEA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790850803; b=jOIYTekNe3biyuqYjJv0SAyU4bzc/ssA3nBZX/dJwcUaPeU/Hjku1/SblUsZZuKstt33+o hP3sWJXIEri1eJf7bt9j2uMMQ+w4n4X9z+WKcnMS6BSeASbrv9grqtGN6Vas9QEuTlE3I2 RyMw2jBCb6d0+Dux0f1pYzoL7UIDFYjT/6/C4k4NlpBfC8+1ga/s96M/yROzErmVXGwOlL 0xveMQYHqSrLFjprUhqb4GSaCOIwbJwx36OaiBhsxuGA2EgGgLHZX9KB5ZyR5qismAEOrJ 4fyq7qJonsqA3iG7lWgozuLV4xNL03W4IYXgu2OFCFpJyLhzJFF2UdKDVsCtfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790850803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ldfKqulO6MxiBOe5N6ye2TSVwpQM61PE1zfx8c15GHo=; b=bkSO63q764A8wHDNNr2sWvxMJ1OzhuMp+LP3K6oiGmNCX1MlLGTlkCksQb0utSv4HWWMrN 0+B5vmElL7Sb7C6wTf161/zpWC0LE6qsjnYXUJ8TNZn8drHFensIs9UnTOQn0RUOs/6CGB pCC0TvROP4vALhuYQxHpyVdqAcFll0cWXCsdLxONuiv7uXuoiwhlPBh6xthh5Mgo1e3LOY esCULWB1Hjyk4alHfjVNSyEvpLROKSyR7ZprFadmbIEUmQif68FvvL+zJpTdWoZihl0Wc/ 6EKj3t7/LS1i7NTFi1nJYjN62Lq8HwBMK86rgF8spvmNsjAI0j6qInQAon9L7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hwStV6kmczS79 for ; Thu, 01 Oct 2026 10:33:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c2a0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 01 Oct 2026 10:33:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 2fa4ef491608 - main - pf: free the packet rate counter of a rule List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2fa4ef491608aad827f8ceef3eb389d8c07451fb Auto-Submitted: auto-generated Date: Thu, 01 Oct 2026 10:33:17 +0000 Message-Id: <6abe36ed.3c2a0.7867c3d2@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=2fa4ef491608aad827f8ceef3eb389d8c07451fb commit 2fa4ef491608aad827f8ceef3eb389d8c07451fb Author: R. Christian McDonald AuthorDate: 2026-10-01 10:32:32 +0000 Commit: R. Christian McDonald CommitDate: 2026-10-01 10:32:32 +0000 pf: free the packet rate counter of a rule pf_ioctl_addrule() allocates a counter_rate for every rule, whether it has a max-pkt-rate or not, and pf_krule_free() never frees it. Free it with the rest of the rule. Reviewed by: kp Approved by: kp (mentor) Fixes: ff11f1c8c76c ("pf: add a generic packet rate matching filter") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60190 --- sys/netpfil/pf/pf_ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index ab2140a60ce7..76cc6074cd8c 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -2758,6 +2758,7 @@ pf_krule_free(struct pf_krule *rule) counter_u64_free(rule->states_tot); for (pf_sn_types_t sn_type=0; sn_typesrc_nodes[sn_type]); + counter_rate_free(rule->pktrate.cr); uma_zfree_pcpu(pf_timestamp_pcpu_zone, rule->timestamp); mtx_destroy(&rule->nat.mtx);