From nobody Thu Oct 01 01:17:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hwDXt5lp2z6tcDS for ; Thu, 01 Oct 2026 01:17:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hwDXt4tn9z4Zns for ; Thu, 01 Oct 2026 01:17:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790817438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ou0JBCkfbYRRTmmxqR7xS187rrT1NzSP5lnqfsc6hK8=; b=dSGJgQ5OeFl8rr3l9atY8uAYNiY8e8Xcic72PDEoHADuI2wzfug1aPJWBttYK3k2+F88Lt 53WmP3cBkDEbqLcso3bps5mVpm5XvoawUoqp0HELGEYObgzbs/0NraMjbQZCubNe9sB7v6 vJiiIgvGzfAJoi3irpsY5eGUXF+OqhYXr4zLJO37MQqZyR9STwCbucko0W4BmjfuEiYAXD GvBEVBkACYjpfo4lrd+jBQ4DgxBgNMruDGiIsVwIy6mqutAsiQmOu6qYYalTdRzjAJ6Mgn GEw9vcOWo30Un4Z+hzQnx9YtvMmJS4IULrhUHoqkazU5uUXI7FX1s4nRJB0lPA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790817438; b=KgvZ6nr78a3uK5K5xo/9bI9jaEIMW7S7J5aSoEoaUTV+0GhM4pnoqvuhtmIcIvrDmZ/4zW NbccS3ZuYlVpXhOTTBa1kVE/njTcsFD6gmpa2MmOnzB4KxB3lXqtI4pfP2OQqe81HcH/W+ SGAM/MVKPkK2n62QI994uk5kSPUvqql7HKQNAYtbdnU9s4gTqqzVkFm0h2khLiIn1M2NiE zeqb1wGq/XHueUlseU7gI4qmylmass6YWe9i3760RjGEFPfAEPxj9m0+F8f740GPr+xjCq vmsU0h81BDC9MCq94hkfjaC9Cfjy/cQVDfCTQwjaR5qjcbAQDIp2xnEuTcPyaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790817438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ou0JBCkfbYRRTmmxqR7xS187rrT1NzSP5lnqfsc6hK8=; b=a71piXWbBPg1FcjFNYNCzAdMCmBSfP1HbEZgceP96A38qWbGwgtbzAMTSUcBxEACsWBa63 /n3jHy/EmJgQTnPHVd7jcs4UKkJz+3v2p4fNNQ22Rz5UBJ1IxjsvdIRi9MRB8e4j8fkmSv bAbY/V3Q2pzYU/tZ/hS3qKjcV9BeeWstwgLgSf4POUfPnVh3ZLAHzbdkPsnyzruS+z1BRO xJXT1QMHxHCAURP5MVWgTLllb2r9k2bg617QadmeDnWzWiwAY8Em7GtaVo8C9HF64tesoy GxmhyjGY4ZtVG9KY+K65Ep7rCsa8/WTTQ0kkJqUWJ02hYVKthODEc5BMeB/qKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hwDXt3xSRz18WJ for ; Thu, 01 Oct 2026 01:17:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 207ad by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 01 Oct 2026 01:17:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 592ed51533a2 - stable/15 - VFS: require locked vnode for fsync() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 592ed51533a2e333efbe48277af9b6530de139d6 Auto-Submitted: auto-generated Date: Thu, 01 Oct 2026 01:17:18 +0000 Message-Id: <6abdb49e.207ad.31525c7@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=592ed51533a2e333efbe48277af9b6530de139d6 commit 592ed51533a2e333efbe48277af9b6530de139d6 Author: Konstantin Belousov AuthorDate: 2026-09-20 03:22:39 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-30 21:37:19 +0000 VFS: require locked vnode for fsync() (cherry picked from commit 30ad8440b46838b050360ed87e6165a067f1cf8a) --- sys/kern/vfs_subr.c | 20 ++++++++------------ sys/kern/vnode_if.src | 2 +- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 0e3376929cdb..b11ae42eb1a7 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -5925,8 +5925,6 @@ vop_fsync_debugprepost(struct vnode *vp, const char *name) { struct mount *mp; - if (vp->v_type == VCHR) - ; /* * The shared vs. exclusive locking policy for fsync() * is actually determined by vp's write mount as indicated @@ -5942,16 +5940,14 @@ vop_fsync_debugprepost(struct vnode *vp, const char *name) * should still be caught when the stacked filesystem * invokes VOP_FSYNC() on the underlying filesystem. */ - else { - mp = NULL; - VOP_GETWRITEMOUNT(vp, &mp); - if (vn_lktype_write(mp, vp) == LK_SHARED) - ASSERT_VOP_LOCKED(vp, name); - else - ASSERT_VOP_ELOCKED(vp, name); - if (mp != NULL) - vfs_rel(mp); - } + mp = NULL; + VOP_GETWRITEMOUNT(vp, &mp); + if (vn_lktype_write(mp, vp) == LK_SHARED) + ASSERT_VOP_LOCKED(vp, name); + else + ASSERT_VOP_ELOCKED(vp, name); + if (mp != NULL) + vfs_rel(mp); } void diff --git a/sys/kern/vnode_if.src b/sys/kern/vnode_if.src index d20ff39b314e..96e826ec86b6 100644 --- a/sys/kern/vnode_if.src +++ b/sys/kern/vnode_if.src @@ -292,7 +292,7 @@ vop_revoke { }; -%% fsync vp - - - +%% fsync vp L L L %! fsync pre vop_fsync_debugpre %! fsync post vop_fsync_debugpost