From nobody Sun Nov 22 19:29:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jXfK44tpzz72c88 for ; Sun, 22 Nov 2026 19:29:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jXfK44Jtvz4W7f for ; Sun, 22 Nov 2026 19:29:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795375768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tvbOX5L0wgVogXwyN42HQ2dxrSckGmQYUSJGpxRpTdA=; b=x7QGq0Qd9bwCVmNmcCpHCcSJ4xMSS7j3BR/jMlUjLgWrdEH//aLDjWSnDmK93ZmQTqHnGc eP9jcSbsc/7OuU4/t9tbauYguPfzKELrREfHFfCqPJTdeRlPSlwTXOz8dQwPDRD/NV7dwr 04+ywonskwUbnC4fXhDhRg56KG7CFWEnHNLBg1Bc2YPcBKqPuWKT5cIrE4VydGDXZiZ2ux vT4COpJ4UO+qJq5Mp4womaWvAs0OHyQSDtZ6LvtjwhPacj4+yQYV5RcsA5wc9mqYzqxdtZ QbEDyfqsVZpbm9bDCECfcs+kokcKJ9KaRpLv5OA61DqO8imB940T9QZbPMHJsA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795375768; b=ESjWkywbz6loZCE9t1jWlygM6JI9UtMxmHS72JvCGLVzIKN5xXIJEAqiQdy7IWvkrIiGz+ fIo8F+h05kPCZ2a0zQRgRRnE31eItjakM6u7xe8TdcHcHIMZZgV4s7kQ6S4WPzCGH0ltLC H2SEpwhK++mR2/W4qH4pjeQLACvLlWeTwHReQ+yJL6hJCrALpmVnEL6TGGnKu9ejtIE1Gc YYfJGaObjc86/V9gm0U2iZXFW+tNzOXEF9LjF5tB+xbq+lEHfcVoFOnrXssSMhqVrez0gU p3ueu3tJ1gixe9Burflvi9mS+mzE/cKlu2RT1xT8FV5XJ+gvGBE3CZ8fUbdQzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795375768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tvbOX5L0wgVogXwyN42HQ2dxrSckGmQYUSJGpxRpTdA=; b=D7O7HKPmrYgvoxZQGJXO/yXc5vuwtQwD0DJjQCA3PKPy4Y64UTZA1aIckyiX6lULMhUaKT OBInHi3TiY27UG8Kw/BooagIxwf+5GGnnAtH/IQ+aLVRNR+blIqHh8nFFxwFZx/6M3lkh2 jrLUdA25obC7PX7QT6VyYFHgCWInH7OtffVCzC/sHsVHUZdn4Hwzz4JuaZRApyJmLRjJaP iyUlnQT0qdh4g9Sk6MB68+8NlxuDB22F4qCpD0EQlECFnL8OVyailNlTMaCoE18hN0Qh1U BSfXTB1BRIGkFkL5R19t8Tr2wY2rgyclTtP1KvJ2AnLvK0yAihhkWR1JSoDTvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jXfK43zzxzHFD for ; Sun, 22 Nov 2026 19:29:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23c7e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Nov 2026 19:29:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Piotr Kubaj Subject: git: c7b5351a0a75 - stable/14 - powerpc: don't drop FPU and VMX ownership in grab_mcontext() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c7b5351a0a75c7a17645718550c1aac8467d0de8 Auto-Submitted: auto-generated Date: Sun, 22 Nov 2026 19:29:28 +0000 Message-Id: <6b034298.23c7e.18dfd909@gitrepo.freebsd.org> The branch stable/14 has been updated by pkubaj: URL: https://cgit.FreeBSD.org/src/commit/?id=c7b5351a0a75c7a17645718550c1aac8467d0de8 commit c7b5351a0a75c7a17645718550c1aac8467d0de8 Author: Piotr Kubaj AuthorDate: 2026-10-18 10:41:36 +0000 Commit: Piotr Kubaj CommitDate: 2026-11-22 14:41:02 +0000 powerpc: don't drop FPU and VMX ownership in grab_mcontext() grab_mcontext() saved the FP and vector registers with save_fpu() and save_vec(), which drop ownership: PCPU(fputhread) becomes NULL while PCB_FPU stays set and the thread keeps using the unit. A later cpu_update_pcb(), at fork(2) or thr_new(2), then skipped the save, since save_fpu_nodrop() only saves for the thread that owns the unit, and the child got the registers as they were at the getcontext() or signal rather than at the fork. Use the nodrop variants. A child forked after getcontext() saw the parent's f14 as it was at the getcontext(); it sees the current value now. Reviewed by: adrian, jhibbits MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D60837 (cherry picked from commit 8a79b6398f06f31947a2dada576c5f489c69d498) --- sys/powerpc/powerpc/exec_machdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/powerpc/powerpc/exec_machdep.c b/sys/powerpc/powerpc/exec_machdep.c index e0e20f7cddf8..1fe22f504f92 100644 --- a/sys/powerpc/powerpc/exec_machdep.c +++ b/sys/powerpc/powerpc/exec_machdep.c @@ -414,7 +414,7 @@ grab_mcontext(struct thread *td, mcontext_t *mcp, int flags) KASSERT(td == curthread, ("get_mcontext: fp save not curthread")); critical_enter(); - save_fpu(td); + save_fpu_nodrop(td); critical_exit(); } mcp->mc_flags |= _MC_FP_VALID; @@ -448,7 +448,7 @@ grab_mcontext(struct thread *td, mcontext_t *mcp, int flags) KASSERT(td == curthread, ("get_mcontext: altivec save not curthread")); critical_enter(); - save_vec(td); + save_vec_nodrop(td); critical_exit(); } mcp->mc_flags |= _MC_AV_VALID;