From nobody Sun Nov 22 19:23:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jXfB412nfz72bbW for ; Sun, 22 Nov 2026 19:23:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jXfB374Fpz4Tcd for ; Sun, 22 Nov 2026 19:23:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795375404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Cx9U1gUodZgq8PQyQ5oby9ABJLka0t191MXgBSrQgfM=; b=MkQQ2VNyQkV/QaZOa1wx7JlGjZmtDHPqVxWuH1gokjhXXkGWW6qjwryWvD9Q5xHnPBY0s+ AST2y8IjpmPqbcc6xZw8H4yDgCFJkz8OhfYbcAvdtykUipcLlUFNuVYLqQp/UpyFrJJHfr qy2lkWgQtqH+xwjN97x3x7zVxxreFAXLXmUe3e3Xq2uLvRTJkN+1JbKW8hXLKWGz734sh2 pwXXK1+buQ4narbhV7RtRWy0EvNdAFjsR+iGCJukxXF3fgbhMJo8lM7uLsw3U68QiQFj6P TPS0hVeEsBIOBeIhkHvr8anNzqSKPFPTSx0FrSulkyjv2e2yMnTOa7+MCJpcLA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795375404; b=hVG94O/9aHHIhOYThub3E5Xm8rbQCb1QJUnOhVH6fLctOQ1oPQMc0lbaR+cO4xUVY7k5Vx W8T/XTIEsGsy19XfKO0C2lBS2LLmfX2vof3ICT7TY3tnUoN4QQLs25LkOU3rxcoblUsc9Z 5ouxkJ+DusieNOKX/+s3sfUNt2F9Q8Tj0yyKsbMjJ3esgvmieFl0JpZaNIivpAT4kKP0zq EEpLIqy4YscSgTRBMvjNNoxo4t5iDS3ThMG7h4gMv34xrEp7JSYEMTPIXr4YUjg/RvBNed EQfvJmyzSNyw9uW5kHijuslWgKs+M3KAN9nPECONElXO2bkNYmWD2i3Wwdvh2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795375404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Cx9U1gUodZgq8PQyQ5oby9ABJLka0t191MXgBSrQgfM=; b=OT08jRMUZiwVuT+HKjSIjBv+qi/zpUQ+wPWDwusPNZJDdY51NZylnvUy6aG67H76aWnCNo mLfRyXycoS0I8Yh9R2pRQSQJ0CtjSoideR4ulB5iZQllFeHH8ovkWf31r1p+RQscelD5IL 1yoJqryOpaDhkZDJBvOuLy3Es7kVKVjNot+A/hZlAkmrNQb8UWAukrylMlzrM6jxfmxjPT H8bOQmrZcv5hQDJq/pjGgFluqNQ0igDLrS0FmzGZ2ovNwDDNe1nt72tc0RPyci9h+kvZXP zEi1WeqAmJKzMNm5wV8zUZZvBH5jpgsaBptC3dTAEFZ4QFja6T5dpJDY1VEs2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jXfB36kQQzHQN for ; Sun, 22 Nov 2026 19:23:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 255b3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Nov 2026 19:23:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Pavel Grakhov From: Enji Cooper Subject: git: e40785bcb232 - main - libthr: Enable the thread name test List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e40785bcb23241d1de7759df781b260b0385e640 Auto-Submitted: auto-generated Date: Sun, 22 Nov 2026 19:23:23 +0000 Message-Id: <6b03412b.255b3.6da8bb13@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=e40785bcb23241d1de7759df781b260b0385e640 commit e40785bcb23241d1de7759df781b260b0385e640 Author: Pavel Grakhov AuthorDate: 2026-11-22 19:22:57 +0000 Commit: Enji Cooper CommitDate: 2026-11-22 19:23:07 +0000 libthr: Enable the thread name test Adapt NetBSD's thread naming tests to run it on FreeBSD. Account for differences in `pthread_setname_np()` and the absence of thread naming attributes on FreeBSD. MFC after: 1 week Reviewed by: ngie, kib Differential Revision: https://reviews.freebsd.org/D61609 --- contrib/netbsd-tests/lib/libpthread/t_name.c | 31 ++++++++++++++++++++++++++++ lib/libthr/tests/Makefile | 2 +- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/contrib/netbsd-tests/lib/libpthread/t_name.c b/contrib/netbsd-tests/lib/libpthread/t_name.c index d17895efe70e..cfbf35a12051 100644 --- a/contrib/netbsd-tests/lib/libpthread/t_name.c +++ b/contrib/netbsd-tests/lib/libpthread/t_name.c @@ -54,10 +54,29 @@ threadfunc(void *arg) pthread_t self = pthread_self(); char retname[32]; +#ifdef __FreeBSD__ + /* Check initial name is empty on the created thread */ + (void)strcpy(retname, "foo"); PTHREAD_REQUIRE(pthread_getname_np(self, retname, sizeof(retname))); + ATF_REQUIRE_EQ(retname[0], '\0'); + + /* + * FreeBSD sets the name explicitly after the thread is created, + * whereas NetBSD supplies the initial name through the thread + * attributes. + */ + PTHREAD_REQUIRE(pthread_setname_np(self, NAME_JUST_RIGHT)); + PTHREAD_REQUIRE(pthread_getname_np(self, retname, sizeof(retname))); +#else + PTHREAD_REQUIRE(pthread_getname_np(self, retname, sizeof(retname))); +#endif ATF_REQUIRE_STREQ(retname, NAME_JUST_RIGHT); +#ifdef __FreeBSD__ + PTHREAD_REQUIRE(pthread_setname_np(self, non_const_name)); +#else PTHREAD_REQUIRE(pthread_setname_np(self, non_const_name, NULL)); +#endif (void) memset(non_const_name, 0, sizeof(non_const_name)); PTHREAD_REQUIRE(pthread_getname_np(self, retname, sizeof(retname))); ATF_REQUIRE_STREQ(retname, CONST_NAME); @@ -68,8 +87,13 @@ threadfunc(void *arg) ATF_TC(name); ATF_TC_HEAD(name, tc) { +#ifdef __FreeBSD__ + atf_tc_set_md_var(tc, "descr", + "Checks pthread_{get,set}name_np() API"); +#else atf_tc_set_md_var(tc, "descr", "Checks pthread_{,attr}_{get,set}name_np() API"); +#endif } ATF_TC_BODY(name, tc) { @@ -78,12 +102,19 @@ ATF_TC_BODY(name, tc) char retname[32]; PTHREAD_REQUIRE(pthread_attr_init(&attr)); +#ifdef __NetBSD__ PTHREAD_REQUIRE(pthread_attr_getname_np(&attr, retname, sizeof(retname), NULL)); ATF_REQUIRE_EQ(retname[0], '\0'); + /* + * NetBSD rejects 32-character names in thread attributes. + * FreeBSD's pthread_setname_np() does not impose a fixed name length + * limit, so this length boundary check is specific to NetBSD. + */ ATF_REQUIRE_EQ(pthread_attr_setname_np(&attr, NAME_TOO_LONG, NULL), EINVAL); PTHREAD_REQUIRE(pthread_attr_setname_np(&attr, "%s", __UNCONST(NAME_JUST_RIGHT))); +#endif (void) strcpy(retname, "foo"); PTHREAD_REQUIRE(pthread_getname_np(self, retname, sizeof(retname))); diff --git a/lib/libthr/tests/Makefile b/lib/libthr/tests/Makefile index 286d46feac45..ba8cbb8f2ab1 100644 --- a/lib/libthr/tests/Makefile +++ b/lib/libthr/tests/Makefile @@ -4,7 +4,6 @@ WARNS?= 3 TESTSRC= ${SRCTOP}/contrib/netbsd-tests/lib/libpthread -# TODO: t_name (missing pthread_getname_np support in FreeBSD) NETBSD_ATF_TESTS_C= barrier_test NETBSD_ATF_TESTS_C+= cond_test NETBSD_ATF_TESTS_C+= condwait_test @@ -15,6 +14,7 @@ NETBSD_ATF_TESTS_C+= fpu_test NETBSD_ATF_TESTS_C+= join_test NETBSD_ATF_TESTS_C+= kill_test NETBSD_ATF_TESTS_C+= mutex_test +NETBSD_ATF_TESTS_C+= name_test NETBSD_ATF_TESTS_C+= once_test NETBSD_ATF_TESTS_C+= preempt_test NETBSD_ATF_TESTS_C+= rwlock_test