From nobody Sun Nov 22 17:41:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jXbwV719fz72K1B for ; Sun, 22 Nov 2026 17:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jXbwV3qYPz3GTy for ; Sun, 22 Nov 2026 17:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795369290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6wwocf1PpUXReaC68GhWG6XjgrZ64L07JQW8DrshCkI=; b=XRiXIPjeQKdlPWSkHrXCn0PlnHKiEIYAOSZwqA3ei0upDx4YM75kYeTlJ9wXkzzEcAgyAj o9kgJ13m1ayIe2r36DgEw6O9uksOo0yQREIeDMdkl1ijAG2w9O4Bt9pEiw1TQTm0TiCD7f 4cIRRX2F0QJrldKcxL8AQur/hwitY3kvTHEnCv64mhsP2XkAu2ubD94qvx45oNePv3xV4I x3WOonJB3MDw0PzqFfQGUfaDtktzBMypuxC/3ctyZ8QjSI5GG0GenKqCJzzG2eyndrgtVb P1LeGW1velsgdd3g99yvnsrBn0qJbd47cwwcghxNjGFaLYe2ktFt9yhvnrAtiQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795369290; b=eX3ODKCN7SMQ9B/iMmz1FIGKd5H6Usyfr8I3pb349UkldWaf7QTGP5p83GjxtnnAwuZ4Qp 0lfqgwSSRhzU3jrCknM7qAHOXPpw/kZOLqhwYTVX0sf40PLJQ9nObm1yhbDiUp0vh471Hq 7DJ3Eu/PU2CP2qgD/ud6dfMgMWCIzblPOisDFn/sMkIIpR6Lj3k+OXy4TIz0JRcnQHMKs7 QLIuwnzZITMY/mU9KrWiH/V4cLco7yqFMfayjiwgKRUx3G6BCKWAWggG9Dc2lDFkKifDMh R0VSuMjR1LgEFxtP/pQR6+4DhOmNFhjAchRUx21gE97z1ogxFQtr/Lj2iZUhRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795369290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6wwocf1PpUXReaC68GhWG6XjgrZ64L07JQW8DrshCkI=; b=dwe8juymBKd+VoDvO8vlswIkKcPI0SjPmfVMPjIZl8ZdnDpVj9y8eIySMK1MWlL09FLhme yXkOPfA/Qiq/f/yDVocuJk0zmOBfXFFTvIxcNtZ6Wjx2+2Jo6OakD+dE8rB9kyCcgPiDRW Bq4r/JwjaA9+J5DV2uyJCTzBHf9KJEszj/14IhxCW7K/HY0RiBr+lE2XRGDAmd5I9vXxKl XEhRuz+R4f6zbhQxOuAIpbTsmcfY6A04e7/FA9rOc7MiMZEWrn3RU+bdSLpyI19S66Oo+x 8I8Ngcyz76YDwBna/FGYWhLNDkQKVGd3jB+OJ7jAvlx5JIhO+C5H0EZDEbWoZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jXbwV3Fhxz1SFv for ; Sun, 22 Nov 2026 17:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19dec by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Nov 2026 17:41:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: bae776b8a5bc - main - shm: Fix a shm object refcount leak in shm_rename(SHM_RENAME_EXCHANGE) List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bae776b8a5bc9cb0896a14c88bd2aa5458755304 Auto-Submitted: auto-generated Date: Sun, 22 Nov 2026 17:41:30 +0000 Message-Id: <6b03294a.19dec.255913b1@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=bae776b8a5bc9cb0896a14c88bd2aa5458755304 commit bae776b8a5bc9cb0896a14c88bd2aa5458755304 Author: Mark Johnston AuthorDate: 2026-11-22 15:14:20 +0000 Commit: Mark Johnston CommitDate: 2026-11-22 17:41:07 +0000 shm: Fix a shm object refcount leak in shm_rename(SHM_RENAME_EXCHANGE) With RENAME_EXCHANGE we acquire an extra ref on the destination object so that shm_remove() doesn't free it. However, we failed to release that ref if the rename fails. Reported by: Laam Alif at Ibteda Digital Library Fixes: 9afb12bab41f ("Add an shm_rename syscall") Reviewed by: kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D61806 --- sys/kern/uipc_shm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/uipc_shm.c b/sys/kern/uipc_shm.c index c71f216fbe08..a5a95c25ad2d 100644 --- a/sys/kern/uipc_shm.c +++ b/sys/kern/uipc_shm.c @@ -1549,6 +1549,8 @@ kern_shm_rename(struct thread *td, const char *path_from_p, */ error = shm_remove(path_to, fnv_to, td->td_ucred); if (error != 0 && error != ENOENT) { + if ((flags & SHM_RENAME_EXCHANGE) != 0 && fd_to != NULL) + shm_drop(fd_to); shm_insert(path_from, fnv_from, fd_from); shm_drop(fd_from); /* Don't free path_from now, since the hash references it */