From nobody Sat Nov 21 17:39:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jWzx53XvMz71ccY for ; Sat, 21 Nov 2026 17:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jWzx530Tgz3PjF for ; Sat, 21 Nov 2026 17:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795282793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DiwFuQTfHdp3aufF4F928Z5ay7WvNWDickQcwmr67R8=; b=AsBGYMgVxV9ufnIHJZE3B3Uf/rGy1VTkGp35NzJPiA0neHG1X+xwDPiFekDf1axzzmdT+f qrD6q9tNAVy9oV8bhRYORYdGP2Q2laD9MavK2ZiwD9t4KER4GcvrkOlYOcYmms7B16+e0m SrMHdquUXKMMvaEzUZJvsmV0WAXTPJ52kfLkN75uVRkmj4r8+rm/g3yrGMy/2loZkY+EJt x/idHbxVQpmydIwnvjt611Po6eAqevoM9hDGbcXI7IhsmIMPzHZav3CaNcnvTWx4abIbTv G9JccAZ0GYWB0WmrZ8PXtDUyzk9JyjBl/s6dCao+hGvVu+Xsetc1VhsiYcb5Dw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795282793; b=BDdu9Xqd+8xcvbgeBNBPfZ6UeF6aT6Wz3xzwGvdkvryvv04u+Y9HnZr2EY09uSw9ZiEzVc hi0sSob2HaO+fXdJF7rFK8DeHCLAB+lrKtYlY+rnKhxW/5QhEWVJrTbxBulrZFZIt2R+nW l+pKFsNFAH3SnN5X6DMc2SO0MiTx/XbOEbsOKpWucG+aVfCCSSy5SWF5qTsPCV/NwSK5BW Tlwcp0uGZ0xRjde4edA9zdSSn4etj0LdSN41qRkd7NTzy/sEI4s0sIpn4VDc0JF139iRyX l+tMZxKPybiKpNBrgy1gU2PbTXAit+EfqNcz4ggitRHkn4NM/6aXFVsjKzGNJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795282793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DiwFuQTfHdp3aufF4F928Z5ay7WvNWDickQcwmr67R8=; b=wFbP0m+jV6t4o0cW4bCIcegfvVJnwIusFmkSxECARk/5SFWYpywX03n1sLwWFBd0ZhlaFc Y9UDqBXlL9BQct1V3Bu2zKiftKS0pDgyJlxcSkTSZ4ZKQjhOElhKc6I+1M1R8rpvcSVM0c 3EVvlQi62PBnP8utucx9oQ6VoFuSUG6SyVfhYr1RBwQgd2z6z2ea30cyDHjvv0ATdrzLjU A5be+AFWf/LPtzewh7MnROEaGm01dxQ3FNWNKqcpPIhudXYzZ0pS3cWwJrMtU+txwSH0xy FbX7IyU5bDX3sDRlEjGk+iGvnX/2XDNc6YqqD3/fXa8WuX1rGKgEBlv/tdHKIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jWzx52g3zzk2H for ; Sat, 21 Nov 2026 17:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id d9d5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 21 Nov 2026 17:39:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Piotr Kubaj Subject: git: 6a83ecfe812e - main - powerpc: don't save the FPU state again in freebsd32_sigreturn() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6a83ecfe812ea97f06b3d3640edb41c7dfa8702e Auto-Submitted: auto-generated Date: Sat, 21 Nov 2026 17:39:53 +0000 Message-Id: <6b01d769.d9d5.140e7c7@gitrepo.freebsd.org> The branch main has been updated by pkubaj: URL: https://cgit.FreeBSD.org/src/commit/?id=6a83ecfe812ea97f06b3d3640edb41c7dfa8702e commit 6a83ecfe812ea97f06b3d3640edb41c7dfa8702e Author: Piotr Kubaj AuthorDate: 2026-09-23 09:29:10 +0000 Commit: Piotr Kubaj CommitDate: 2026-11-21 17:39:43 +0000 powerpc: don't save the FPU state again in freebsd32_sigreturn() set_mcontext32() restores the floating point registers from the context, then freebsd32_sigreturn() called save_fpu(), which writes the hardware registers, the ones the signal handler left behind, back into the PCB. The process resumed with the handler's registers instead of its own. sys_sigreturn() has no such call; drop it here too. A 32-bit program that loads f14, takes a signal whose handler loads another value and reads f14 back got the handler's value on a COMPAT_FREEBSD32 kernel; it gets its own now, like the 64-bit build. Reviewed by: jhibbits MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D61792 --- sys/powerpc/powerpc/exec_machdep.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/powerpc/powerpc/exec_machdep.c b/sys/powerpc/powerpc/exec_machdep.c index d7166b13f67d..d66afe02a9d1 100644 --- a/sys/powerpc/powerpc/exec_machdep.c +++ b/sys/powerpc/powerpc/exec_machdep.c @@ -938,13 +938,6 @@ freebsd32_sigreturn(struct thread *td, struct freebsd32_sigreturn_args *uap) if (error != 0) return (error); - /* - * Save FPU state if needed. User may have changed it on - * signal handler - */ - if (uc.uc_mcontext.mc_srr1 & PSL_FP) - save_fpu(td); - kern_sigprocmask(td, SIG_SETMASK, &uc.uc_sigmask, NULL, 0); CTR3(KTR_SIG, "sigreturn: return td=%p pc=%#x sp=%#x",