From nobody Fri Nov 20 22:43:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jWVkN5DxRz7148d for ; Fri, 20 Nov 2026 22:43:56 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jWVkL5xPkz4ZqP for ; Fri, 20 Nov 2026 22:43:54 +0000 (UTC) (envelope-from rlibby@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of rlibby@gmail.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=rlibby@gmail.com Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-8b4e2ec4b42so8492257b3.0 for ; Fri, 20 Nov 2026 14:43:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795214634; x=1795819434; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oj2V+QSIZTnD7GMXldyExlPMbkpOSB7Nd5FOidzfCfs=; b=NkdnLRAXTeDpagHTOyHrLorSAVEPdDqtUJGrqSgitBzmfdd9+k7qr+iI3y3uzukM05 kB8aMW337gAMZL2Xjp/iAJSZ25HSr4OvxbcEw0t5jcQP1QlmHvRvHYpt357QqzJuanlz v44IiwWuRnHp/ylt8W/03ZL5OiFokuI+dcocXdcbTvTT9LInnlmvypCknJ15n7pJ7eAK vl10XKzludq2zj0VA9czkNj554LxNInwU7hOh4wY86PgIMc0abh0vGnOH0KLltoaz0fc sOdZw9ySUATljEKMRiR3wBItKHJRp7pFjk9yxLoR+WlOtEco/i75bi4DtHKmUmZAVT4t yJxQ== X-Forwarded-Encrypted: i=1; AL+hErGxJzeEWywzsQu4PZsmlJYoYseEoxodIVlrgqHPt0z34pEFjmpkQrgYpQzvz4ja3sRfCAisozQV1i765sUbBmVpygXr@freebsd.org X-Gm-Message-State: APuU4Z9djwJj1OMqOP9IN8YivUb2FfA6PNpGjEWtHgjHHE1tYvQL8rdQ 4i4/8uuX1EOWib7P6KdzcjFrJnO+aj10Q1ovn4DR/jJKxFXWjacT1n916FBvGw== X-Gm-Gg: AZFdTZcIBSzcXnktSA+ruBRC8vL0YtEgH3+AK9eDSONioQJDf6ZEnzWB4uZtmuwdMsX vvEZQmZPDVS9JuXoB65Cbk5luRTMzMH/kHNL1/GQPnRU3ca0jJTO+QZFNM8yLCO0ygNB7AoRTUM YxSZwbEZzn8c+6ZORCv6UDkbpycUIh5KfoMqD4MGTKNqFuZxlUxX/FsrHHAHGW+t6+m+MpN+LCR UC026O6UKmSyw/E52Rih2kxFX4OK0xsxparBFaU3K4eNEpp6j2q/hW/fHnOUCuDBXFNK/LBq8Rx HzyiO2f1MzcK7POeZRO3da8adC9E45v6cg6EQhmi0xoLoqG1yrO+i0mARBUYOd5E1Or3uuQNR8M dNQA1dK1eOB+HBVnmj9D9Bthr9Oe5e/OYyakcTDJuKG5ZAvrYgC2VngT/c9HnK9moNT7Vn9nmGq gO5dea0oDfjTSdGB/xCEU1Bffy14RRJL0Aar6BlAYzzXF+7JG9uTyxQ6csdTqr9fW/yI+I+3fGA iQhtyGcak+uYsGEShmMEbk7DOP2/Ulkm9xLecjltLxuAaHQx0W8XZh46xIALz/A10dAqxhRMdRr aI5wq52BdMmTcKdlvjL0hDzBIbDhFMN/KZVmFFYtBrF3s4Xufq4xtlWz2t2WIsTQ X-Received: by 2002:a05:690c:6c8a:b0:8b4:a76a:f628 with SMTP id 00721157ae682-8b52042e7c5mr22170757b3.20.1795214633735; Fri, 20 Nov 2026 14:43:53 -0800 (PST) Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com. [74.125.224.47]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b520354770sm19457787b3.42.2026.11.20.14.43.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2026 14:43:53 -0800 (PST) Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-67da564d9f2so2154337d50.1 for ; Fri, 20 Nov 2026 14:43:53 -0800 (PST) X-Forwarded-Encrypted: i=1; AL+hErFu/yBhVV75iKGvk27p4J9fCPpjLSU7i5buMYmz6QnOVn9YSUHXiyoM4hASmLrr2aZy1AYI1or53QcPN22Ix55xc8SW@freebsd.org X-Received: by 2002:a05:690e:43d3:b0:67d:bf83:75bd with SMTP id 956f58d0204a3-67df42d0a8cmr1197968d50.12.1795214633125; Fri, 20 Nov 2026 14:43:53 -0800 (PST) List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6ac93697.22ace.51b60016@gitrepo.freebsd.org> In-Reply-To: <6ac93697.22ace.51b60016@gitrepo.freebsd.org> From: Ryan Libby Date: Fri, 20 Nov 2026 14:43:42 -0800 X-Gmail-Original-Message-ID: X-Gm-Features: AclHuK-Df9dc1er_EUDO3VT7whx7oZfCQxSlRnCkxZr4gJ9T_ZuZdSQa8_wba5M Message-ID: Subject: Re: git: e959f2a7d8a8 - main - ctf*: exit with error upon terminate() To: Ed Maste , Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4jWVkL5xPkz4ZqP X-Spamd-Bar: / X-Spamd-Result: default: False [0.10 / 15.00]; FORGED_SENDER(0.30)[rlibby@freebsd.org,rlibby@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[rlibby]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.178:from]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[rlibby@freebsd.org,rlibby@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.178:from,74.125.224.47:received]; MISSING_XM_UA(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_FIVE(0.00)[5] On Fri, Oct 9, 2026 at 11:47=E2=80=AFAM Ed Maste wrote= : > > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3De959f2a7d8a8ac942983328f91= cd5c566e3f72cb > > commit e959f2a7d8a8ac942983328f91cd5c566e3f72cb > Author: Ed Maste > AuthorDate: 2024-02-04 21:47:50 +0000 > Commit: Ed Maste > CommitDate: 2026-10-09 18:23:42 +0000 > > ctf*: exit with error upon terminate() > > The initial port of the CTF tools had a FreeBSD-specific patch to pri= nt > the termination message but exit with a 0 status, with a goal of gett= ing > as much to build as possible and silently ignoring any issues. > > We're now past the point where silently ignoring failures makes sense= . > Any future issues need to be found and addressed. > > PR: 276826 > PR: 276930 [exp-run] > Reviewed by: markj > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D43743 > --- > cddl/contrib/opensolaris/tools/ctf/cvt/util.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/cddl/contrib/opensolaris/tools/ctf/cvt/util.c b/cddl/contrib= /opensolaris/tools/ctf/cvt/util.c > index 0eda56dbf65a..5139725bb9cf 100644 > --- a/cddl/contrib/opensolaris/tools/ctf/cvt/util.c > +++ b/cddl/contrib/opensolaris/tools/ctf/cvt/util.c > @@ -149,17 +149,7 @@ terminate(const char *format, ...) > > if (getenv("CTF_ABORT_ON_TERMINATE") !=3D NULL) > abort(); > -#if defined(__FreeBSD__) > -/* > - * For the time being just output the termination message, but don't > - * return an exit status that would cause the build to fail. We need > - * to get as much stuff built as possible before going back and > - * figuring out what is wrong with certain files. > - */ > - exit(0); > -#else > exit(1); > -#endif > } > > /*PRINTFLIKE1*/ > It appears that the gcc builds have not succeeded since this went in. I see a few fixes have gone in since then, including 40371e514185, but there are a few more problems I am hitting. 1: There are some asm files that pass the check for having any debug info, but then don't have child DIEs, I guess because they have ENTRY() macros but nothing else, e.g. exception.S. We could just warn and skip such files. 2: There are some asm files that end up as entirely empty, for which gcc produces no .symtab, and we now balk at that, e.g. how we build aesni-gcm-avx2-vaes.S, resulting in "cannot convert stripped objects". Again, we could warn and skip. 3: gcc emits debug info for typedef types even if they aren't otherwise used, and some of those types aren't supported by ctf, e.g. from intel_sha256.c a 2-byte float introduced via headers but not used. We could sub in an opaque type or something? I assume no one actually cares about 2-byte floats. We can make ctfconvert handle each of these cases more gracefully, or maybe you all have something else in mind for how these should be fixed (maybe elsewhere in the toolchain?). I have a small diff to cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c and ctfconvert.c from claude that allows the build to succeed, but I don't want to assume that that direction is correct. I think it would probably be better if someone knowledgeable worked through the build failures. Here is an example build recipe that currently fails: pkg install amd64-gcc14 env MAKEOBJDIRPREFIX=3D/usr/obj/amd64-gcc14 CROSS_TOOLCHAIN=3Damd64-gcc14 make kernel-toolchain -j$(sysctl -n hw.ncpu) env MAKEOBJDIRPREFIX=3D/usr/obj/amd64-gcc14 CROSS_TOOLCHAIN=3Damd64-gcc14 make buildkernel -j$(sysctl -n hw.ncpu) KERNCONF=3DGENERIC That should be enough to hit all the issues. Last successful gcc build in CI: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/4887/ Next build includes e959f2a7d8a8ac942983328f91cd5c566e3f72cb and fails: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/4888/ All gcc builds have failed since. Best, Ryan