Re: git: e61c4b81374c - main - tests/sigtramp_test: re-enable test on aarch64
- In reply to: Siva Mahadevan : "git: e61c4b81374c - main - tests/sigtramp_test: re-enable test on aarch64"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 20 Nov 2026 16:10:49 UTC
Пт, 20 нояб. 2026 г. в 18:31, Siva Mahadevan <siva@freebsd.org>:
> The branch main has been updated by siva:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=e61c4b81374c3785d97088c3f6634a9effc3db3c
>
> commit e61c4b81374c3785d97088c3f6634a9effc3db3c
> Author: Siva Mahadevan <siva@FreeBSD.org>
> AuthorDate: 2026-11-20 14:57:48 +0000
> Commit: Siva Mahadevan <siva@FreeBSD.org>
> CommitDate: 2026-11-20 15:27:22 +0000
>
> tests/sigtramp_test: re-enable test on aarch64
>
> This now passes on both aarch64 (since 6a936d939b88)
> and amd64. It still fails on other architectures, so
> keep the xfail.
>
Wow, thank you!!!
> PR: 289096
> Sponsored by: The FreeBSD Foundation
> ---
> lib/libexecinfo/tests/sigtramp_test.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/lib/libexecinfo/tests/sigtramp_test.c
> b/lib/libexecinfo/tests/sigtramp_test.c
> index b440781aa857..32d41acd7a9e 100644
> --- a/lib/libexecinfo/tests/sigtramp_test.c
> +++ b/lib/libexecinfo/tests/sigtramp_test.c
> @@ -45,12 +45,8 @@ handler(int signum __unused)
> ATF_TC_WITHOUT_HEAD(test_backtrace_sigtramp);
> ATF_TC_BODY(test_backtrace_sigtramp, tc)
> {
> -#if !defined(__amd64__)
> - /*
> - * https://reviews.llvm.org is deprecated and
> - * this review is never going to be updated or completed
> - */
> - atf_tc_expect_fail("https://reviews.llvm.org/D155066 and
> https://bugs.freebsd.org/289096");
> +#if !defined(__amd64__) && !defined(__aarch64__)
> + atf_tc_expect_fail("https://bugs.freebsd.org/289096");
> #endif
>
> struct sigaction act;
>
>