From nobody Fri Nov 20 15:32:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jWK8q2KHdz721hs for ; Fri, 20 Nov 2026 15:32:43 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jWK8p4mpYz4tgt for ; Fri, 20 Nov 2026 15:32:42 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c51239b0e3bso169298366b.2 for ; Fri, 20 Nov 2026 07:32:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795188761; x=1795793561; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JOn1mZCMSIECZcHHhF1lwr/zGQkkxDF4oCUsGKcEadU=; b=dDL03384E/I0nFjmt5yllIOIxPjQyHOvWGUyZaO0hyfC889bReYAJEBKlg67djZ4IB w2Le1fvSKQvjUpp1VvwmuHvXNYapgsi12idNUT+jByly6zN2qDQUx1+AMFCrUcLx/PIw eOEbYD2kCbdSBE3CKbS3Mc+w5LhScYJ/fce3I+oybWuAu2tB9mVEgKyX2g+LfrfU0duc 5kMag2Rlfw4ufeQQO+ACzOMCbpO4HqFX9uYblIiAx9XINyi1igB1W/z3eidcE7gr54BQ +f7reUGbQ7w7Qk3ytE03GgJ6DfPwgUJ1eRedkhyn5/OEi0Z6RQtPesLq3VPZx4bU+N6x hLHg== X-Forwarded-Encrypted: i=1; AL+hErGqV0er12vrhFfLreyVQK2FnUj2oT6wt9sy3usaCDSPb3iWhnWfvHk6cJl4Z0DhwAvQf6Z3SOhaTZ2Eu5BITQ/sV0qZ@freebsd.org X-Gm-Message-State: APuU4Z83w+CuBGEDs4dVKB/h2lQpXSfzDr9gPmllfKUs4AMWN5MBFRfL FaxMMipJPA7B5rsGlC/p4qf8l5iHVT9sv2osapAeIvWBO6QDsVe5RBijDRxHeBHDPgtu+MC6ZsW 7V1KoLho= X-Gm-Gg: AZFdTZds4joALxTRXgF7Hoe56lm0jUrjs6KhNB4ZZR0SmqoEwjtp3G083rxy6hI/uMc LjW7m7Ywr+9SG/E4Uq5tP/k1gcAclwl/7mt06TwXloFCStnKgTynQECp1/t+usaZOTfjHGKsh+U mD8CnZaxC0D09ckankzzVNvw+fNby7TRu19z9Txdjk1LXjFNJEgPtLZeWnvggtNTkeRIyEKxDdk y1UhU+QuDgkDOY/33YXCRdFFZZ1x113+tTLfPu0raEIOWPE9l4FYtzVwIA3iVgNpqkM7K3gKgWr 11KrbU3tWU5faWVMPz+5m7dV/O1LWyUL1Em9krJZ6DmXHs4j5PNhdgJhJfSeQ4lRPEeZq4QQ3/k f/Xx+eMVxcS7vrPxRbz+TnKlRjlO5UY90ierCEUViIFRVk9s4Jx5ufjtDX3wFQh1p7nwlXwKFhI czpUJywrtnu76ZtSgGTKoYQSBLpMlBLTy650/u22LUUYhxLE/YThon4TnvNcHhG3AhfTyqNmvta FJMTmcMAiEY6w4aJm8Wl/3GRgi4z2BEYHVAb/itxJrYRVG412Vpn5cpIfpn9EaNsFt4emKKxaeN Pk74WbOOwRTUeT0BZTwbyuy0ey2qGZLqj5FB2PTDHnRzjPg6Coyz7xOb4AWHTYncXpyHgRDdpf7 YPiPlT924VKLDeArjb8aIc6o= X-Received: by 2002:a17:906:29d0:b0:c50:5005:8ecf with SMTP id a640c23a62f3a-c513a88b122mr245429566b.8.1795188760805; Fri, 20 Nov 2026 07:32:40 -0800 (PST) Received: from smtpclient.apple (host86-142-176-254.range86-142.btcentralplus.com. [86.142.176.254]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c513aea1fd8sm106029966b.38.2026.11.20.07.32.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Nov 2026 07:32:40 -0800 (PST) Content-Type: text/plain; charset=us-ascii List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) Subject: Re: git: bf362c1b41c8 - main - kobj: convert KOBJOPLOOKUP() to returning pointer to function From: Jessica Clarke In-Reply-To: Date: Fri, 20 Nov 2026 15:32:29 +0000 Cc: Zhenlei Huang , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Elliott Mitchell Content-Transfer-Encoding: quoted-printable Message-Id: References: <6b001ca8.17a65.140055b6@gitrepo.freebsd.org> <20261120133642.ED99E1D0@slippy.cwsent.com> <2E303DF5-FFE0-4BEF-8915-DC26E1CF09DB@FreeBSD.org> <20261120072122.679034c4@slippy.cwsent.com> To: John Baldwin X-Mailer: Apple Mail (2.3901.200.71.1.16) X-Rspamd-Queue-Id: 4jWK8p4mpYz4tgt X-Spamd-Bar: / X-Spamd-Result: default: False [0.50 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.218.52:from]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; FREEFALL_USER(0.00)[jrtc27]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[freebsd]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.52:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; ALIAS_RESOLVED(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6] On 20 Nov 2026, at 15:14, John Baldwin wrote: > On 11/20/26 09:25, Jessica Clarke wrote: >> On 20 Nov 2026, at 14:21, Cy Schubert = wrote: >>> On Fri, 20 Nov 2026 21:48:37 +0800 >>> Zhenlei Huang wrote: >>>=20 >>>>> On Nov 20, 2026, at 9:36 PM, Cy Schubert = wrote: >>>>>=20 >>>>> In message <6b001ca8.17a65.140055b6@gitrepo.freebsd.org = >, Zhenlei Huang >>>>> writes: >>>>>> The branch main has been updated by zlei: >>>>>>=20 >>>>>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbf362c1b41c803c7320147b89915bd65= >>>>>> 88dd6071 >>>>>>=20 >>>>>> commit bf362c1b41c803c7320147b89915bd6588dd6071 >>>>>> Author: Elliott Mitchell >>>>>> AuthorDate: 2025-01-10 00:45:05 +0000 >>>>>> Commit: Zhenlei Huang >>>>>> CommitDate: 2026-11-20 10:09:02 +0000 >>>>>>=20 >>>>>> kobj: convert KOBJOPLOOKUP() to returning pointer to function >>>>>>=20 >>>>>> This makes KOBJOPLOOKUP() rather more suitable for purposes = outside the >>>>>> macros generated by makeobjops.awk. Of note other callers can = lookup >>>>>> the function on their parent class and call that explicitly. >>>>>>=20 >>>>>> Reviewed by: zlei >>>>>> MFC after: 2 weeks >>>>>> Differential Revision: https://reviews.freebsd.org/D48408 >>>>>> --- >>>>>> sys/sys/kobj.h | 20 ++++++++++---------- >>>>>> sys/tools/makeobjops.awk | 6 +++--- >>>>>> 2 files changed, 13 insertions(+), 13 deletions(-) >>>>>>=20 >>>>>> diff --git a/sys/sys/kobj.h b/sys/sys/kobj.h >>>>>> index 890ad1d39a13..3cdbf14d124c 100644 >>>>>> --- a/sys/sys/kobj.h >>>>>> +++ b/sys/sys/kobj.h >>>>>> @@ -247,30 +247,30 @@ extern u_int kobj_lookup_misses; >>>>>> * slow way. >>>>>> */ >>>>>> #ifdef KOBJ_STATS >>>>>> -#define KOBJOPLOOKUP(OPS,OP) do { \ >>>>>> +#define KOBJOPLOOKUP(OBJ, OP) __extension__ ({ \ >>>>>> kobjop_desc_t _desc =3D &OP##_##desc; \ >>>>>> kobj_method_t **_cep =3D \ >>>>>> - &OPS->cache[_desc->id & (KOBJ_CACHE_SIZE-1)]; \ >>>>>> + &(OBJ)->ops->cache[_desc->id & (KOBJ_CACHE_SIZE-1)];\ >>>>>=20 >>>>> This has caused a number of errors as below as an example. >>>>>=20 >>>>> --- aq_media.o --- >>>>> In file included from /opt/src/git-src/sys/dev/aq/aq_media.c:43: >>>>> In file included from /opt/src/git-src/sys/net/iflib.h:31: >>>>> In file included from /opt/src/git-src/sys/sys/bus.h:893: >>>>> ./device_if.h:115:2: error: no member named 'ops' in 'struct = kobj_ops' >>>>> 115 | KOBJOPLOOKUP(((kobj_t)dev)->ops, device_probe); >>>>=20 >>>> It appears that the generated file `device_if.h` is not = re-generated after `sys/tools/makeobjops.awk` >>>> been updated. >>>>=20 >>>> Can you please try this first, >>>>=20 >>>> ``` >>>> make cleankernel >>>> ``` >>>>=20 >>>> and then rebuild ? >>>=20 >>> This resolved it. Thanks. >> Hi Zhenlei, >> Please figure out an appropriate depend-cleanup.sh patch or revert = this >> ASAP. WITHOUT_CLEAN is a supported configuration, and even our = default, >> so we cannot break it. >=20 > Probably all the foo_if.[ch] need to depend not just on foo_if.m, but = also on > sys/tools/makeobjops.awk It seems we already do for the suffix transformation rules in kmod.mk, but not for the MFILES rules in kern.post.mk, nor for the uses of NORMAL_M in sys/conf/files*. SomeoneTM should test and commit such a fix. Jessica