From nobody Fri Nov 20 10:26:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jWBM80b6Tz71Y6G for ; Fri, 20 Nov 2026 10:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jWBM76gCGz3CwG for ; Fri, 20 Nov 2026 10:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795170371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pjPpbbM2UOcpGtq4yxvsVwtgT0F8UOw6sL/s/oc9Whc=; b=XZdha9fQ+8xyGFSTunXHWp8NKxZk4KHFdusIL5zpjOBes8so5JdlSoaDgy1RzgNsjtP357 lNovnKvXyKgGTcWnMt5DraTYnSiwF+mCNn47HZfMoyjaz3tweDijAEHvdAghPlDaVjtqBH BrUz6hPh4/dPS0o5Gt9uDI3gYH4WrY0lrQfUm5CJl9VqeFc8xzQYOqABfHF/l7dn2BKpVP wx8PH2Z0B3LgNuELhhGT7971FX76sFH3ccDNjCX4JM2QWe/HDT3Dn2bsWumejUAnuDX7L/ 0ilKHCw0y5VK0RoPXA+IDq9eeHgVEzeLX1wMCozj67juY30dTw0qKyhFl61O5w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795170371; b=uQ/qsZDNz+DWzOA9Mj/u0ed6PXOdu28e+05y1gEXE4S4PMTjCrokyuXrZ3Yen2JMR/Gn2O T4ewun8j1X7xi/414aPak5vxifgUECqPMm0mRuyABGjUwIblZykOt1OJNRXFsAYezhwo0r l+NoC+Lw69/YUnXLnzQ4AmWzjeJCvI3/GWAtR3TrWfHabzEeWjl3+bnoA/ACb7VojZu9QT CPAR5y348S1uOYZqqKWA4LdJpCMwwevMDu9QSwUHFu7/bU17euozo8gKEeBd3Vr2NApP2x dl3bHGll3i8DsdDTv81KHKyhDyr/xO7ABVKq7wIb4922j9z4O6rKGac1KUpbiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795170371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pjPpbbM2UOcpGtq4yxvsVwtgT0F8UOw6sL/s/oc9Whc=; b=AaTvGTVTrarkm3XKNfYp1ROUewDwRxomaBj4r9+2arT3NdTuUktjVWaLU92zIi5ViLnyMh Ie4HdZc73evQWw2DbAEtG56M4te7u4YRr9opx9vkd0tCCnTvKsupOj+eZyOeCzxAU+QswF iypYKIMmfVvjGLR+i1zC+lSWDL7DnG8fneZ2lpfGhBVnzSUhXiFtd5ltnHL6DxlWdRzDL2 +TAoDs9lI9+8QHZZ9qnxI8el1JMP1m6XsrSDOTRbuQAIKHLCJwXOieUaBb1+xCtS48chdY XA96BT0LMpE6k39bHjbAMFlygt/kFCcrXHgv8/dNCxTz1E/Pm0isRRGmwyw7fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jWBM75nxkzkmt for ; Fri, 20 Nov 2026 10:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18560 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Nov 2026 10:26:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Brooks Davis Subject: git: d6f99f67507d - stable/14 - swapoff: don't leak vnode pointer to device List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d6f99f67507dc012806d3404250bd00e559b98c9 Auto-Submitted: auto-generated Date: Fri, 20 Nov 2026 10:26:11 +0000 Message-Id: <6b002043.18560.6bda7416@gitrepo.freebsd.org> The branch stable/14 has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=d6f99f67507dc012806d3404250bd00e559b98c9 commit d6f99f67507dc012806d3404250bd00e559b98c9 Author: Brooks Davis AuthorDate: 2026-11-13 10:06:53 +0000 Commit: Brooks Davis CommitDate: 2026-11-20 10:25:42 +0000 swapoff: don't leak vnode pointer to device After looking up the device path, we compare the vnode to the vnode of each swap device. Prior to this change we leaked a vnode reference to the device we're trying to remove from the swap pool. Effort: CHERI upstreaming Reviewed by: kib, markj Reported by: llm-postcr MFC after: 3 days Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D61464 (cherry picked from commit 9506d8e0b1788068cbd4c2cbc984cb6ee0dcb0ab) --- sys/vm/swap_pager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c index 5a01a5075f52..18eb251070d8 100644 --- a/sys/vm/swap_pager.c +++ b/sys/vm/swap_pager.c @@ -2504,6 +2504,7 @@ kern_swapoff(struct thread *td, const char *name, enum uio_seg name_seg, break; } mtx_unlock(&sw_dev_mtx); + vrele(vp); if (sp == NULL) { error = EINVAL; goto done;