From nobody Fri Nov 20 09:34:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jW9Cc4q37z71RQB for ; Fri, 20 Nov 2026 09:34:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jW9Cc3zxzz4pFv for ; Fri, 20 Nov 2026 09:34:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795167276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SkMsGeD/vmIsahrtOElI0X4zJ7N/F9FB/C7NUOnDZSo=; b=k87E4ZCJGmDNwtAIJFWhIopzhRDF/R5cmvdvMsyFRTmN5dUpkmI0ExTVvR+jdt/4CqJhmg RE6tETXirmg3goxQYgIQ5k+XNU+ntqAw0dGH9XwGCRxVmlD2xy7Y5vAH0cUexh1hPl1j32 MvcInYgdq72lwAIqnc+XCiWnHNEkhNkBFZ6thB5eoEnDjOz2DQ5qdmOHSvrjqIaByio+h+ cXwS+nxCIBl/c6406fPwmo6EMLzqFJBRwPvqgDrJoVyNX9TfUFNamuocMcdyKCjZsyC8SQ 98eQbB165mL/uJKiSCuTnOQQJXfPTXOdL/BgVnRTD5Ex/jqxndFU5cjpXXJ6Jg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795167276; b=LRhKNb6c4pm57sZWIn7BVYe9rKKxoWiOu4opmIBwHgcIUKNu6N+x7O6VcdZo2P/KvWnwPO sl8ufdnNkS2RwFQ+1utRQjwYra34qr/hejpKR1TXqk08xJKgaawTasIllpE9e7TGGLENum M8lXFO2eayPVi7ZX8lgLmajhP24dqVT6yTRFEROpUV84m/Frr9mtuF2wn7HhWVAH3Ymlig ueB3eUIzATWOVhmPveHnEiIy77zuyVqUd5zXu9HfwSPgCeVSX4YbLnHg3sECV1QUuMRutP jsbvZD5GtqwyfdD3GRcBDbBYae+AE4dspJFSseGq/vBEg/13X7FYI+TXsM2X7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795167276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SkMsGeD/vmIsahrtOElI0X4zJ7N/F9FB/C7NUOnDZSo=; b=PTBjNYJclhtxRNC7ffo/JLalB85QC5TLAixTJJ/2iuoBmh49d62R3o5f0f4VGSx/x2e/xt KCKVaN8AcLwUtoA0LWeCuO+iQLcMbYfw5+i1qYooSUjjujjEn6K/tIeOJVPkOXrtZT3jjy gaksA3yKxYtOrjehGbmBdqaty2Dx1icuV86IRTQvSFwMyhnCnAVszVGCD+/RaflEJigIy2 qJwvbVfDr8jwZiksO8CSWAppNi7IS0EWwWfk/E5DJAYj60w+4RK8f1MNr1mXtZLNCYplfz pSL6EFOcbqDdD/RCd8j0+iXwN692X5POOF2fyiorKVdHUVCNvSZiU+8GlvlVqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jW9Cc3fQ4zjjj for ; Fri, 20 Nov 2026 09:34:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 145eb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Nov 2026 09:34:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Piotr Kubaj Subject: git: 4588b6358ab1 - main - fbt/powerpc: don't instrument the trap entry path List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4588b6358ab140be5553377ec203b65d5f1d0728 Auto-Submitted: auto-generated Date: Fri, 20 Nov 2026 09:34:36 +0000 Message-Id: <6b00142c.145eb.712919d8@gitrepo.freebsd.org> The branch main has been updated by pkubaj: URL: https://cgit.FreeBSD.org/src/commit/?id=4588b6358ab140be5553377ec203b65d5f1d0728 commit 4588b6358ab140be5553377ec203b65d5f1d0728 Author: Piotr Kubaj AuthorDate: 2026-09-21 19:48:04 +0000 Commit: Piotr Kubaj CommitDate: 2026-11-20 09:34:28 +0000 fbt/powerpc: don't instrument the trap entry path On powerpc an fbt probe is a program interrupt that goes through the normal trap path, powerpc_interrupt() -> trap() -> dtrace_trap(). A probe on trap() or powerpc_interrupt() fires again on the way to its own handler, so it recurses until the kernel stack runs out, and enabling fbt::trap:entry panics the machine right away. Skip both functions, like aarch64 and riscv skip their exception handlers. Reviewed by: jhibbits MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D61660 --- sys/cddl/dev/fbt/powerpc/fbt_isa.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/cddl/dev/fbt/powerpc/fbt_isa.c b/sys/cddl/dev/fbt/powerpc/fbt_isa.c index d0b3ccdeb906..ebfc9ac8acfa 100644 --- a/sys/cddl/dev/fbt/powerpc/fbt_isa.c +++ b/sys/cddl/dev/fbt/powerpc/fbt_isa.c @@ -127,6 +127,13 @@ fbt_provide_module_function(linker_file_t lf, int symindx, if (fbt_excluded(name)) return (0); + /* + * fbt probes are delivered through trap(), so instrumenting the + * trap entry path would make them recurse. + */ + if (strcmp(name, "trap") == 0 || strcmp(name, "powerpc_interrupt") == 0) + return (0); + instr = (uint32_t *) symval->value; limit = (uint32_t *) (symval->value + symval->size);