From nobody Fri Nov 20 01:13:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVy5Z6bd6z71pYt for ; Fri, 20 Nov 2026 01:13:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVy5Z5zpmz4YMw for ; Fri, 20 Nov 2026 01:13:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795137218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WZGkVtXHnP0QFmEGOV+6qvOKLkQSRw0eKC0SapMk7SU=; b=qSAYOn0wWv1tb/2BbbanMYcsU9mptrPa9S/zfGCdnKgUuwiP38ga5KLpJrmoyPhrn4uf9K 5XsXWC50MUL+XgI29X+8/iBFCXJ2iGUq+LWhqkCVc1daQUEpov5e1bWp/ZuwTk4uSfRR0V QqpKvUtmALK77KwTK1gDjA2gqHRvK1ABhf79VEglvucTv7akTBMVjjJ6S+EmHtDVgRJ7KN 5dgMzcGwI0+6L7KmWReeF/oVfF7EqFKuJzIo+crEnJ85gkseIVErIxIPZ4uBW9dmr787s+ DNdu7Ka5qjxzZOs7UEBpTb85MjFQaFwgXjD36aB++8+kZ3eAXiPFb6In7/SIcw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795137218; b=CNPHSYwZJiVNSIUvmiwqk+fdPnGIuFu1xTIBIvRHYk7ViZvbWOCcu8QTfRqY4zkTBncEmp DWxU/gjMkkCpOEbnCdv4qJp68opLx5coN8LDewoqoblCNZE3b19moEh55yDwqAc4/xC5vJ MYWzFUbwAdzDf8HngswHsfpZj+aSJ2H9StxF0a2wv5XZixtXS3Zu21TqhNsSB0evy1HGc5 zD+ivd9wQY/+75Mr/gPwxTN/HmXkD2og1BYmNRRHhSWMOsS4ob0/bQVIaegJu6g7gIqkDC 9VFQ5PAo5EbRlpxThsoU8httN4Zsjnj8T8pCppDnYvUXe66wx7Xtk3bkkfK1WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795137218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WZGkVtXHnP0QFmEGOV+6qvOKLkQSRw0eKC0SapMk7SU=; b=fCqHhmxCEJggg6T1FSRDZ8+SrsPDWknEqm4fAbw2MtKLpay7FHqXgVW2lqvU2jfDUTJisS Yjc5UhckydM4kA4bwOO7EXmgtEIp1BtyzNf7QqRaFDtmGbDHCQpHyy/Ei8wS2o6Ay+dQqd bX8bJPrtQJhdxmu01ZCX+NSn3Pg6cSnwO8cCFPDVefDmzuEM8wiYW+ONlC5qj9a92UBrMh bEa3J27Lq+bQq7zaVsmwvIcibzuewMe71SthXoLD8J0sKs3/Eqp+jdTDJiAM7qmT9mQm7D I3trO9SNLKi1PewDn9YkSMOAFawKHsfQRter8UHEvc3M7+tFSAmUXvJX7mFDUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVy5Z5fYDzQFT for ; Fri, 20 Nov 2026 01:13:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1320 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Nov 2026 01:13:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hayzam Sherif Subject: git: 60a559d7dec5 - main - arm64/pmap: Ignore pmap_advise() for stage 2 pmaps List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hayzam X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 60a559d7dec5344d2ef1f4ee225fbd0325feeb3c Auto-Submitted: auto-generated Date: Fri, 20 Nov 2026 01:13:38 +0000 Message-Id: <6aff9ec2.1320.60ed27e@gitrepo.freebsd.org> The branch main has been updated by hayzam: URL: https://cgit.FreeBSD.org/src/commit/?id=60a559d7dec5344d2ef1f4ee225fbd0325feeb3c commit 60a559d7dec5344d2ef1f4ee225fbd0325feeb3c Author: Hayzam Sherif AuthorDate: 2026-11-19 23:32:17 +0000 Commit: Hayzam Sherif CommitDate: 2026-11-20 01:10:52 +0000 arm64/pmap: Ignore pmap_advise() for stage 2 pmaps When vm_fault() handles a sequential fault that needs pager I/O, it calls vm_fault_dontneed(), which passes MADV_DONTNEED to pmap_advise() for the pages behind the fault. For vmm(4) guest memory the pmap is a stage 2 pmap, so a guest that reads paged-out memory sequentially panics an INVARIANTS kernel on the stage 1 assertion in pmap_advise(). MADV_DONTNEED and MADV_FREE are only hints, so ignore them for stage 2 pmaps. Reviewed by: markj Approved by: markj (mentor) Sponsored by: Alchemilla Ventures Private Limited MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D61622 --- sys/arm64/arm64/pmap.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c index 7340627e6721..e64d5a345f30 100644 --- a/sys/arm64/arm64/pmap.c +++ b/sys/arm64/arm64/pmap.c @@ -8205,11 +8205,18 @@ pmap_advise(pmap_t pmap, vm_offset_t sva, vm_offset_t eva, int advice) pd_entry_t *l0, *l1, *l2, oldl2; pt_entry_t *l3, *dl3, oldl3; - PMAP_ASSERT_STAGE1(pmap); - if (advice != MADV_DONTNEED && advice != MADV_FREE) return; + /* + * The code below changes stage 1 permission bits and invalidates + * stage 1 TLB entries. vm_fault() reaches here for a stage 2 pmap + * when it drops pages behind a sequential fault. MADV_DONTNEED and + * MADV_FREE are advisory, so skip them entirely for stage 2 pmaps. + */ + if (pmap->pm_stage != PM_STAGE1) + return; + PMAP_LOCK(pmap); for (; sva < eva; sva = va_next) { l0 = pmap_l0(pmap, sva);