From nobody Thu Nov 19 23:24:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVvgZ0Gg3z71Z6d for ; Thu, 19 Nov 2026 23:24:26 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVvgX5kGwz4Hcr for ; Thu, 19 Nov 2026 23:24:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4a32576da88so135329f8f.3 for ; Thu, 19 Nov 2026 15:24:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795130663; x=1795735463; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QokdhULuOJLYhtMgUMLadPv/nvSOh+Q5Qdj96PFaEuY=; b=wZDf8JbWpT9dm8JQAj54bFZBBYuE7aRZPQjhalnGj5NII+SHFM3AnDLbvWAtmYGIof eVwUbSdBoW8NpOy1XkjU26ry+wfc0Ay7csEW7/KHyGY5seXM3ost8eyL5s6beqGNlrMI K4tYFuVm68ewAlcCSnuhBdxH8E/DJtjgSMovQOLTtCQVdz6PMUuuXgI8kyTh9IdOPZrv o1xsGhBpyHYI8GCT19bk/0huUTx9vE91rPk8lWTBGurBHtpqR0gsnP7zfWwS6C3j+Cec 07NdrLizo+5PCG6k3zTUWzf1OwxSamulkwOAL/x8vPpRSpJasKuhWTHtg+W2cwJznS9O /gDQ== X-Forwarded-Encrypted: i=1; AL+hErFNpdLsm8Zo5Wm4B588Z749h8Q5CtOt3SpOvOcf2CK6Url/DfEoNRPBsUEfgXNkPpFG3aAkoIeOkvQZHftP3guGPcz6@freebsd.org X-Gm-Message-State: APuU4Z9IbZ6nBRF7TOjs/VImW/nZW/zbeYF5I72v8hSgGdCvoSiHfkqB NbvQhds4u/E5jJtm6NzicVVFeZiZVDZuS/yraxrE/rrhVxv21dCWVsl3LzdiVO2EhdE= X-Gm-Gg: AYBFou3YCuQbtltfGwIjuDcSJgKMAgpKzXgAKGRoe/jz23b+l0mQhL5IcmkZlYYFhgI y0OpxEeZhcFXvp3UyiMSed5HvadiahHXEADt52Co5JQGnC9CIcEuwpKKKcFFOwgvtVDOUJH1LLl 4vpWYjgEWzScNQi/obySkcLmTvfGB9c2tSXRjA86qmLpduvxDbNQSaBGx6AVu5o0wTo/878P7VM RHji4MO2ZcuMfB2PXcxCwyB343T98BRYHu6DzYrbr1ez7F7fCzRPNpSalRs6oqqp2UJf326j5PT b7ZTE5Q4loJGx6w92n/b9JlQT1fi+RcVLyiwnnAFBwIk0C8CdtRhOQvll4nKCoNIecQWUR2oUxu SWbrDzuepv1YogexdbvMZn/jZTgj8FLri4qkzRpmc0MuVGoKwhg/nQndnFYT2+rfAYBbyMjD2+k htotKc5YUUBK+00/b9O5kxClg6BGkn1O/JB0fwnrcHWJ92j/HDrwHozV7UV5p6/s9ol+z4xEf8G iUqyY4PuSjtIQYDyzpNmaotxeX1VfFIz0SNTyvp8YRpekA6W94JGo7efuEhqEhX8vSsSp1rwhOw PX/IO8l1E1amOoq0+jDgnzP0E9Mo7U8WNLtC5pbpZN+aKWTmm6+k6Us98PgIjlR4pONpKNShJYI 457Ykj0ownikp/rVKwNh5FCI= X-Received: by 2002:a05:600c:b90:b0:4a7:76fa:87e9 with SMTP id 5b1f17b1804b1-4bb8892cb02mr20875085e9.21.1795130663101; Thu, 19 Nov 2026 15:24:23 -0800 (PST) Received: from smtpclient.apple (host86-142-176-254.range86-142.btcentralplus.com. [86.142.176.254]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb853368d3sm70763445e9.1.2026.11.19.15.24.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Nov 2026 15:24:22 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) Subject: Re: git: 8b197806dcdf - main - libsysdecode: Teach mktables to handle enums From: Jessica Clarke In-Reply-To: Date: Thu, 19 Nov 2026 23:24:11 +0000 Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , FreeBSD Release Engineering Team Content-Transfer-Encoding: quoted-printable Message-Id: <60295FA7-6A07-4CCF-BB3C-215F5A5A1B4F@freebsd.org> References: <6a4c058d.3ff3a.44bb1175@gitrepo.freebsd.org> <1EE0178B-840A-448B-A666-A95A45139CC9@freebsd.org> <92F04590-94A9-4FD8-B288-536C0F6D4126@freebsd.org> <66090801-7FFE-4ACF-87AD-4C503429230E@freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3901.200.71.1.16) X-Rspamd-Queue-Id: 4jVvgX5kGwz4Hcr X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.50:from]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.50:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6] On 19 Nov 2026, at 23:06, Gleb Smirnoff wrote: >=20 > On Thu, Nov 19, 2026 at 10:22:21PM +0000, Jessica Clarke wrote: > J> The more adventurous alternative would be something like: > J>=20 > J> diff --git a/lib/libsysdecode/mktables b/lib/libsysdecode/mktables > J> index bb784c853e48..61dc089a42c4 100644 > J> --- a/lib/libsysdecode/mktables > J> +++ b/lib/libsysdecode/mktables > J> @@ -64,7 +64,7 @@ _EOF_ > J> sed -nE ${excl:+-e "/${excl}/d"} \ > J> -e "/^#[[:space:]]*define[[:space:]]+${grep}/p" \ > J> "${include_dir}/${file}" | \ > J> - sed -Ee = 's/.*define[[:space:]]+([^[:space:]]+)\>.*/TABLE_ENTRY(\1)/' > J> + sed -Ee = 's/.*define[[:space:]]+([_[:alpha:]][_[:alnum:]]*).*/TABLE_ENTRY(\1)/' > J> fi > J> cat <<_EOF_ > J> TABLE_END > J> @@ -95,7 +95,7 @@ _EOF_ > J> awk '/^(typedef[[:space:]]*)?enum([[:space:]].*)?\{/, > J> /^\}([[:space:]].*)?;/' | > J> # pick out the constants we want > J> - sed -Ene 's/^[[:space:]]*('"${grep}"')\>.*/TABLE_ENTRY(\1)/p' > J> + sed -Ene = 's/^[[:space:]]*('"${grep}"')([^_[:alnum:]].*|$)/TABLE_ENTRY(\1)/p' > J> fi > J> cat <<_EOF_ > J> TABLE_END > J>=20 > J>=20 > J> Tested only that the build produces a plausible tables.h on macOS, = but > J> I believe that in theory it only uses standard POSIX ERE features. >=20 > Jessica, can you please draw back your revertion request, since you = got fix in the works? >=20 > I really don't want to see enum changes reverted. Hi Gleb, Thanks for the reply as someone involved with this set of changes and able to comment on their importance; I=E2=80=99m not aware of the bigger picture here. If there are important changes that depend on it and people are happy to go with this kind of approach, I can look at doing some tinderbox builds to verify builds on FreeBSD at least aren=E2=80=99t modified (and = that Linux gets the same result, since I have a big Linux box available). That should at least give re@ assurance about such a late-binding change and help me sleep at night; I generally favour reverting to a known state over fixing forwards, but probably we can avoid that here. I=E2=80=99ll try and get some tinderbox builds kicked off later tonight. Jessica