From nobody Thu Nov 19 22:54:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jVv1T6km6z71WNy for ; Thu, 19 Nov 2026 22:54:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jVv1T624Rz4CgB for ; Thu, 19 Nov 2026 22:54:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795128893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9kLuVrcV5pSgArpXivD1ox3k+JDH1JH3p/W3uI3MVm8=; b=Noa7sSOWL3N1+lFF5jaEIvQ3x9g6B9ox2ulo5GLZvdXgXJnE8UarUSsyphlVaHIBhH1dcV zwwPamFqV57u+KeQkVUw8paBeyYY+1GHK4OjspZxqhH5U6EOjlnTqvbS38CyuaBP9hYf6Y yPF4f0otEPCeH92wgoFWyfjO9z7+cQucqV7iODujW72JlkWgCj4T/x0tOeSZj6JPGK5jS2 y0n2NJXQqfzaoNzItfL3MvwLsCBFUvIoEyOPaqLCUS/dY94F7OjGzoPl27iqFpG5Yy/TIW FHGZbvHk3GR2SYgDcVgMagnsx7e7X9eMHO0ubXIicDXydw3vXGOlkENpS1LifA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1795128893; b=Ouw6rhtDNxq19lWzpsPqa5JNVi4K7kk6DBsKmID4J1LJm76eCUvvVibIMXfWkbaph1FC/z O+72VB44tLrSLRqqPkCFWKk94PQi+L2ZgFR0A4dylQl1zr+2GELopLijyhiab5A21KnY3u qeJaOrVHhwdKjl9hoSErnH2DNRU9/1DeMRxKsMgHwbDqUR9xhq2NGAAtZqjY4ExNuC9yjt qXwYVMqkdUsaQcORuntnoEu3+f0za8UxATSrTHNdkC9PI39QIZuiocVIr+Jdey3tl+4arH uweciuMY/NYi6qq34T3GfYPffmwr/jEoatprNoOoDIOV51NFNBwOeyakMcwSwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1795128893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9kLuVrcV5pSgArpXivD1ox3k+JDH1JH3p/W3uI3MVm8=; b=sRuxjLMO6ixhNKqJGxSeoZkdYIPj5NR0lKM8DMtHPhReDffnWbwd1xoFi1kKgP/KbnApjO kstHGxbuBb0eJOfU3i9FlIRbVIiqAC9e3kj9grtSQQw6VL6dkSbgRuNpmgKVGnFci9iEb+ siY/eb0kU8JfdX/6abwWNpfJrptJbQaT8e98wyMDIlddQniCUKZs0VmFMrpwLOwTs9xi6U e162MgWCM4W44tzTDkUvjt5E07/KYLlejlwc38cbAFMSMdyK3PAaV0UmDSPHR+LFm2mCfs zg/uiygzrjM1IGtXGNOWDi1r8k48WT34Blo27icdaZH8kT8t4uP42iTuJ3XpHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jVv1T5hkrzLJl for ; Thu, 19 Nov 2026 22:54:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 190d5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Nov 2026 22:54:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: ef3c76fd2030 - main - mii: call only PHY_STATUS() from mii_pollstat() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ef3c76fd2030a4c7d0f9c981b7129595398e3f21 Auto-Submitted: auto-generated Date: Thu, 19 Nov 2026 22:54:53 +0000 Message-Id: <6aff7e3d.190d5.586effc3@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=ef3c76fd2030a4c7d0f9c981b7129595398e3f21 commit ef3c76fd2030a4c7d0f9c981b7129595398e3f21 Author: Gleb Smirnoff AuthorDate: 2026-11-19 21:58:02 +0000 Commit: Gleb Smirnoff CommitDate: 2026-11-19 22:54:43 +0000 mii: call only PHY_STATUS() from mii_pollstat() When we are in mii_pollstat() which effectively is called only from ue_mii_sts methods of various drivers, we are interested in polling the status and not making any actions. What PHY_SERVICE(,, MII_POLLSTAT) effectively did was PHY_STATUS() followed by mii_phy_update(). The latter is undesired, as we already may be servicing a link state change event and posting a second one is not what we want. Usually mostly harmless, this second event would panic when device is calling into mii during its detach (e.g. USB device). NB: there are few drivers that would do extra stuff between PHY_STATUS() and mii_phy_update() in their mii_service methods. This seems irrelevant to me when we are in ue_mii_stat/mii_pollstat. But I could be wrong. See the PR for longer discussion. PR: 290417 --- sys/dev/mii/mii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/mii/mii.c b/sys/dev/mii/mii.c index b63bfb6285bb..00bffe4dc546 100644 --- a/sys/dev/mii/mii.c +++ b/sys/dev/mii/mii.c @@ -613,7 +613,7 @@ mii_pollstat(struct mii_data *mii) */ if (IFM_INST(ife->ifm_media) != child->mii_inst) continue; - (void)PHY_SERVICE(child, mii, MII_POLLSTAT); + PHY_STATUS(child); } }