Re: git: 8b197806dcdf - main - libsysdecode: Teach mktables to handle enums

From: Jessica Clarke <jrtc27_at_freebsd.org>
Date: Thu, 19 Nov 2026 21:39:52 UTC
On 19 Nov 2026, at 21:12, Jessica Clarke <jrtc27@freebsd.org> wrote:
> On 6 Jul 2026, at 20:44, Dag-Erling Smørgrav <des@freebsd.org> wrote:
>> 
>> The branch main has been updated by des:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=8b197806dcdff5673dd4f77a97bf46035d14db2a
>> 
>> commit 8b197806dcdff5673dd4f77a97bf46035d14db2a
>> Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
>> AuthorDate: 2026-07-06 19:41:15 +0000
>> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
>> CommitDate: 2026-07-06 19:41:15 +0000
>> 
>>   libsysdecode: Teach mktables to handle enums
>> 
>>   While here, clean up and simplify the existing code.
> 
> This has completely broken mktables on macOS*. Please back it out
> immediately, MFC it and get that into 15.2 so we can go back to a
> known-good state and have time to properly diagnose and fix it.

The cause is that \> is not POSIX, nor is it a universal extension.

GNU sed     supports             \> and \b
FreeBSD sed supports [[:>:]] and \>
macOS sed   supports [[:>:]]

Note that, although we bootstrap FreeBSD sed, it still behaves like
macOS sed, because it uses the system’s regex(3).

I have no immediate solution I would feel comfortable deploying this
close to 15.2’s release, so still believe a revert with a later re-land
is the right course of action.

Jessica

> I assume this may entail reverting any enum conversions that depend on
> this.
> 
> Cc re@ as this commit is in releng/15.2.
> 
> Jessica
> 
> * The generated tables.h is full of #defines
>